PSP2DesignReviewChecklist
Student
Program
Instructor
MargaritaTorresAlvarado
Tdistribution
MariaJimenez
Date
Program#
Language
08/04/2015
5
Java
Purpose
General
To guide you in conducting an effective design review
- Review the entire program for each checklist category; do not attempt to review
for more than one category at a time!
- As you complete each review step, check off that item in the box at the right.
- Complete the checklist for one program or program unit before reviewing the
next.
Complete
Standards
Verifythatthedesigncoversalloftheapplicablerequirements.
- All specified outputs are produced.
- Verify that program sequencing is proper.
Stacks, lists, and so on are in the proper order.
- Verify that all loops are properly initiated, incremented, and
terminated.
- Examine each conditional statement and verify all cases.
- Verify that all functions, procedures, or methods are fully
understood and properly used.
- Verify that all externally referenced abstractions are precisely
defined.
- Verify that the program does not cause system limits to be
exceeded.
Verify that
- all special names are clear, defined, and authenticated
- the scopes of all variables and parameters are self-evident or
defined
- all named items are used within their declared scopes
Ensurethatthedesignconformstoallapplicabledesignstandards.
Tags
Verifythatalltypesofappropriatelinesfortheprogramareused.
Logic
FunctionalUse
System
Considerations
Names
Review Checklist Template
June 2010
2010 by Carnegie Mellon University
CodeReviewChecklist
Student
Program
Instructor
MargaritaTorresAlvarado
Tdistribution
MariaJimenez
Date
Program#
Language
09/04/2015
5
Java
Purpose
General
To guide you in conducting an effective code review
- Review the entire program for each checklist category; do not attempt to review
for more than one category at a time!
- As you complete each review step, check off that item in the box at the right.
- Complete the checklist for one program or program unit before reviewing the
next.
Complete
Includes
Initialization
Verifythatthecodecoversallofthedesign.
Verifythattheincludesarecomplete.
Checkvariableandparameterinitialization.
- at program initiation
- at start of every loop
- at class/function/procedure entry
Checkfunctioncallformats.
- Parameters
Checknamespellinganduse.
- Is it consistent?
- Is it within the declared scope?
Checkthatall
- objects are initialized new
- declared out of the main objects to be static
Checktheoutputformat.
- Line stepping is proper.
- Spacing is proper.
Ensurethat()areproperandmatched.
- Verify the proper use of ==, =, ||, and so on.
- Check every logic function for ().
Checkeverylineofcodefor
- instruction syntax
- proper punctuation
Ensurethatthecodeconformstothecodingstandards.
Checkthestartandcompletionofeachtag
Verifythatallfilesare
- properly declared
- opened
- closed
Calls
Names
Objects
OutputFormat
()Pairs
LogicOperators
Linebylinecheck
Standards
FileOpenandClose
Review Checklist Template
June 2010
2010 by Carnegie Mellon University
