willshouse

Your issue is around line 1132 where someone set the result of the call of an object to a variable of the same name:

$addThisConfigs = $addThisConfigs->getConfigs();

In other parts of the code this is done as:

$options = $addThisConfigs->getConfigs();

But in this case you’re just blasting away the global object.

As an aside, this is a terribly written WordPress plugin. The code is a mess. There are constants being defined and checked all over the place, and lots of require_once statements. All of the functions are in the global scope. There are no classes. Why would you ever do something like this in your code?

define( ‘ENABLE_ADDITIONAL_PLACEMENT_OPTION’, 0);

I had switched some sites to use AddThis instead of ShareThis but with fragile, outdated, non-objected oriented, and non tested code I will be uninstalling this plugin and looking for a more stable solution. This plugin took down several of my websites with it’s most recent update and that’s not OK. Even fixing this one issue won’t correct the other problems that I’ve mentioned. Perhaps if AddThis can rewrite the plugin using some of the best practices found in the Codex’s plugin section it may be worth another look – but right now it’s just a mess with a lot of future issues waiting to happen.

ps: nothing wrong with a require_once statement but put together with everything else that’s done wrong in the plugin the code just really says “I’m going to be cautious because I’m not confident that this will work”

Please review (and accept) your pull requests.

I think the author’s website is called “better wordpress” and so the plugin is thus called “better wordpress” minify – so it’s not really a better version of the minify plugin, it’s just his version…