michaelrich

I think I found the cause and fixed it:

The get_submissions() method in the file main/admin/admin-pages/submissions/crud.php doesn’t correctly use the page number. It tries to get the page number from $_REQUEST['current_page'], but WordPress list tables use a URL parameter called paged. Because $_REQUEST['current_page'] isn’t set, the code always defaults to showing page 1. The correct page number is actually passed to the function as an argument, but the function overwrites it.

The Fix:

To fix this, the get_submissions() method in main/admin/admin-pages/submissions/crud.php needs to be changed to use the arguments passed to it, especially current_page.

Code Change:

Inside the public static function get_submissions( $args = array() ) method in main/admin/admin-pages/submissions/crud.php:

1. Remove this block of code (which incorrectly resets $args):

			// This part is causing the problem by overwriting $args
			$args = [
				'orderby'      => isset( $_REQUEST['orderby'] ) ? sanitize_key( $_REQUEST['orderby'] ) : '',
				'order'        => isset( $_REQUEST['order'] ) ? strtoupper( sanitize_text_field( $_REQUEST['order'] ) ) : '',
				'per_page'     => isset( $_REQUEST['per_page'] ) ? (int) $_REQUEST['per_page'] : 10,
				'current_page' => isset( $_REQUEST['current_page'] ) ? max( 1, (int) $_REQUEST['current_page'] ) : 1,
			];

2. Add this code in its place (to correctly use passed arguments and set defaults):

			// Define default values
			$defaults = [
				'orderby'      => 'created_at',
				'order'        => 'DESC',
				'per_page'     => 20, // Or use the screen option default
				'current_page' => 1,
			];

			// Merge incoming $args with $defaults.
			// This ensures that if 'current_page' is passed in $args, it's used.
			$args = wp_parse_args( $args, $defaults );

			// Keep the existing sanitization for the now correctly populated $args
			$args['orderby'] = sanitize_key( $args['orderby'] );
			$args['order']   = strtoupper( sanitize_text_field( $args['order'] ) );
			$args['per_page'] = (int) $args['per_page'];
			$args['current_page'] = max( 1, (int) $args['current_page'] );

This change ensures the function uses the correct page number provided by WordPress’s list table system, fixing the pagination.

BTW: I think 20 is way better as a default then 10.

For some reason I cannot reactivate a user with:

UM()->common()->users()->approve($user_id, true);

I also do not get any error in my error logs if I try it.

Is this even the right way to re-enable a user after I deactivated him?

I also tried:

UM()->common()->users()->set_status('approved', $user_id);

what did also not work.

For reference, I used the following code before the Ultimate Member update:

um_fetch_user($user_id);
UM()->user()->approve();

And replaced it with:

UM()->common()->users()->approve($user_id, true);

That is how it was mentioned in the release notes. But it does not work…

As a sanity check I also tried:

UM()->common()->users()->set_as_pending($user_id, true);

An that worked. Are you sure the other functions are working properly? Did I do anything wrong?

• This reply was modified 1 year, 1 month ago by michaelrich.

Thank you very much, your code is working and restores the functionality. 🙂