Maciej Bis
Forum Replies Created
-
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsPerfect, I am glad that it works correctly now.
The patch will be added in the next plugin’s release.
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsThanks, everything is set-up correctly. Have you tried to check if it works for more than one specific custom permalink or for more of them?
Troubleshooting this further can be difficult, because I am not able to reproduce this bug any longer. After I identified it and applied a fix, the Permalink_Manager_Helper_Functions::force_unique_uri() function seem to work as expected.
I have tested it in several configurations, including both WPML and Polylang – but I think I might missing something – could you possibly record a screencast or send me extra screenshots showing step-by-step how exactly you edit the permalink?
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsTechnically, the “-2” can be appended also if you have auto-update mode enabled + slugs mode uses the default settings (“Use WordPress slugs”).
Could you send me the screenshot with:
- Permastructure settings (“Tools -> Permalink Manager -> Permastructures”)
- General settings (“Tools -> Permalink Manager -> Settings -> General settings”)
If possible, please also record a short video showing all the steps, so I can reproduce them on my test server.
- This reply was modified 5 days, 23 hours ago by Maciej Bis.
Forum: Plugins
In reply to: [Permalink Manager Lite] WP All Import/Export setting errorThank you, now I see that bug clearly. I will patch in the next release. Could you try to hotfix it by replacing the contents of wp-content/plugins/permalink-manager/includes/integrations/permalink-manager-third-parties.php file
with patched code?
https://pastebin.com/UyKVLfFAI apologize for the inconvenience!
- This reply was modified 6 days, 16 hours ago by Maciej Bis.
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsCould you try to manually overwrite the contents of:
wp-content/plugins/permalink-manager/includes/core/permalink-manager-helper-functions.phpfile with this code?
https://pastebin.com/raw/GPeZhMJd
The new patched function now also should check the language code to prevent the “false positives” when the URLs includes duplicated slug but different language code, so the URL as a whole is unique.
- This reply was modified 6 days, 19 hours ago by Maciej Bis.
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsYes, I will try to implement the patch to the dev version in the next 1-2 hours. I will get back to you immediately after I finish and double-check it.
Sorry for the inconvenience!
Forum: Plugins
In reply to: [Permalink Manager Lite] Not Preventing Duplicate URLsHi @fencer04,
The function that forces the unique permalinks ignores the language code, so it will automatically append “-2” to the slug for URLs in the different languages. I will try to adjust this in the next plugin’s release, but for now I would recommend to turn “Force unique custom permalinks” off.
The quickest way to adjust the previous URLs is to use bulk editor – if you use “-2” as search term – you should be able to find all the affected custom permalinks:
Forum: Plugins
In reply to: [Permalink Manager Lite] WP All Import/Export setting errorI have tried to replicate this error using the same plugins’ versions, but everything went smoothly. Unfortunately, I do not have any similar reports from other users, so I would need you to send me more detailed debug info with more backtrace info.
If you do not have access to the debug log from the server-level, you can try to access it from WooCommerce dashboard (under “fatal-errors”):
https://woocommerce.com/document/finding-php-error-logs/or using this plugin:
https://wordpress.org/plugins/debug-log-manager/Forum: Plugins
In reply to: [Permalink Manager Lite] WP All Import/Export setting errorPlease upload the screenshot to Imgur.com or another image hosting platform.
Forum: Plugins
In reply to: [Permalink Manager Lite] WP All Import/Export setting errorHi @keysuck,
Could you possibly send me the screenshot with more error details (backtrace info) and provide me with plugins’ version numbers?
Forum: Plugins
In reply to: [Permalink Manager Lite] Function _load_textdomain_just_in_time was calledIt seems like you are using the outdated or possibly nulled version of Permalink Manager Pro.
As other users reported the same issue in past, I moved ‘permalink_manager_alerts’ and other UI-related hooks to separate method get_output_globals() in 2.5.0 version:
https://plugins.trac.wordpress.org/browser/permalink-manager/trunk/permalink-manager.php#L159which is hooked to ‘init’ in line #125:
https://plugins.trac.wordpress.org/browser/permalink-manager/trunk/permalink-manager.php#L125You can easily confirm this by comparing your copy of the plugin with the main file permalink-manager.php. Besides the comments in the beginning, the rest of code is exactly the same in Lite & Pro variants.
Forum: Plugins
In reply to: [Permalink Manager Lite] Function _load_textdomain_just_in_time was calledHi @mcdeth,
Technically, the texdomain is loaded with ‘init’ as the official docs suggest. The translated strings in settings screen are hooked to ‘permalink_manager_sections‘ filter which itself is not called until ‘admin_init‘ action hook. The plugin’s textdomain is loaded with ‘localize_me‘ that is called with ‘init‘ hook.
If you are using Pro version, could you check if the same warning is displayed also when Lite version is temp. used instead?
- This reply was modified 1 month, 2 weeks ago by Maciej Bis.
Forum: Plugins
In reply to: [Permalink Manager Lite] Page Not Found Issue on View PageHi @rahuls17,
I am sorry for the inconvenience. The bug is the result of the code refactoring in one of the admin functions that I implemented a few months ago. The patch will be included in the next release.
Before it happens please manually replace line #118:
$post_name_esc = preg_quote( $post->post_name, '/' );with:
$post_name_esc = preg_quote( get_page_uri( $post->ID ), '/' );inside permalink-manager/includes/core/permalink-manager-uri-functions-post.php file:
https://plugins.trac.wordpress.org/browser/permalink-manager/trunk/includes/core/permalink-manager-uri-functions-post.php#L118I see – does the issue persist also when Yoast is turned on, but Permalink Manager Lite is turned off?
To troubleshot this bug, you will need to check how exactly that JSON file looks like. Could you possibly send me the screenshot showing the browser’s console log?
https://developer.wordpress.org/advanced-administration/debug/debug-javascript/#open-the-developer-toolsHi @daveyvanaken,
Does the problem started after upgrading to the most recent version of Permalink Manager Lite? If so, could you possibly check if the issue persists also:
- when “posts” and “pages” are excluded in the settings:
https://permalinkmanager.pro/docs/exclude-content-types/#exclude-content-types - when Permalink Manager Lite is temp. deactivated
- when the plugin is downgraded to previous version, e.g. 2.5.1.3 (you can download it using the below URL):
https://downloads.wordpress.org/plugin/permalink-manager.2.5.1.3.zip
Best regards,
Maciej