JulianR

Hi Daan

Thanks for your swift response. Have a great break and best wishes for the New Year.

Julian

Hi Stephanie

Thanks for getting back so quickly. Here’s my System Info:

Cheers

WordPress Environment

Home URL: https://www.odysseus-unbound.org
Site URL: https://www.odysseus-unbound.org
WP Version: 6.2
WP Multisite: –
WP Memory Limit: 768 MB
WP Debug Mode: –
WP Cron: –
Language: en_GB
Permalink Structure: /%postname%/
Show on Front: page
Page on Front: Home (#2973)
Page for Posts: Latest News (#248)
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: www.odysseus-unbound.org
TLS Connection: Connection uses TLS 1.3
TLS Connection: Probably Okay
Server Info: Apache
PHP Version: 7.4.33
PHP Post Max Size: 256 MB
PHP Time Limit: 120
PHP Max Input Vars: 3000
PHP Max Upload Size: 256 MB
cURL Version: 7.85.0, OpenSSL/3.0.8
SUHOSIN Installed: –
MySQL Version: 5.7.39
Default Timezone is UTC: ✔</img>
fsockopen/cURL: ✔</img>
SoapClient: ✔</img>
DOMDocument: ✔</img>
gzip: ✔</img>
GD Graphics Library: ✔</img>
Multibyte String: ✔</img>
Remote Post: ✔</img>
Remote Get: ✔</img>

GiveWP Configuration

GiveWP Version: 2.26.0
GiveWP Cache: Enabled
Database Updates: All DB Updates Completed.
Database Updates: All database migrations completed.
Database Tables: ✔</img> wp_give_donors✔</img> wp_give_donormeta✔</img> wp_give_comments✔</img> wp_give_commentmeta✔</img> wp_give_sessions✔</img> wp_give_formmeta✔</img> wp_give_sequential_ordering✔</img> wp_give_donationmeta✔</img> wp_give_revenue✔</img> wp_give_migrations✔</img> wp_give_log
GiveWP Cache: Enabled
GiveWP Cache: ✔</img>New Donation✔</img>Donation Receipt✔</img>Donation Processing Receipt✔</img>New Offline Donation✔</img>Offline Donation Instructions✔</img>New User Registration✔</img>User Registration Information❌</img>Donation Note❌</img>Email access✔</img>Renewal Receipt Email✔</img>Admin Renewal Receipt Email✔</img>Subscription Cancelled Email✔</img>Admin Subscription Cancelled Email✔</img>Subscription Completed Email✔</img>Subscription Reminder Email❌</img>Subscriptions Email Access✔</img>Subscription Payment Failed Email
Upgraded From: 2.25.2
Test Mode: Disabled
Currency Code: GBP
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: https://www.odysseus-unbound.org/support/donation-confirmation/
Failure Page: https://www.odysseus-unbound.org/support/donation-failed/
Donation History Page: https://www.odysseus-unbound.org/support/my-donations/
GiveWP Forms Slug: /donations/
Enabled Payment Gateways: Stripe - Credit Card, PayPal Donations, GoCardless, Offline Donation, Stripe - Apple Pay, Stripe - Google Pay
Default Payment Gateway: Stripe - Credit Card
PayPal IPN Notifications: IPN received for #6767 ( 8KR92974JP4028343 ) on 12/02/2022 at 11:55. Status VERIFIED
Donor Email Access: Disabled
Stripe Webhook Notifications: 01/04/2023 19:40

Active GiveWP Add-ons

Give - Currency Switcher: ✔</img> Licensed – by GiveWP – 1.5.2
Give - Form Field Manager: ✔</img> Licensed – by GiveWP – 2.0.4
Give - Gift Aid: ✔</img> Licensed – by GiveWP – 1.4.2
Give - GoCardless Gateway: ✔</img> Licensed – by GiveWP – 1.3.8
Give - MailChimp: ✔</img> Licensed – by GiveWP – 1.5.0
Give - Manual Donations: ✔</img> Licensed – by GiveWP – 1.6.2
Give - PDF Receipts: ✔</img> Licensed – by GiveWP – 2.3.13
Give - Per Form Gateways: ✔</img> Licensed – by GiveWP – 1.0.2
Give - Recurring Donations: ✔</img> Licensed – by GiveWP – 2.4.0
Give - Stripe Gateway: ✔</img> Licensed – by GiveWP – 2.5.0
Give - Zapier: ✔</img> Licensed – by GiveWP – 1.4.1

Other Active Plugins

Akismet Anti-Spam: by Automattic – 5.1
Backup Duplicator & Migration - WP STAGING: by WP-STAGING, WPStagingBackup – 2.13.0
Better Search Replace: by WP Engine – 1.4.2
Broken Link Checker: by WPMU DEV – 2.0.0
Code Snippets: by Code Snippets Pro – 3.3.0
Coming Soon Page, Maintenance Mode, Landing Pages & WordPress Website Builder by SeedProd: by SeedProd – 6.15.7
Complianz | GDPR/CCPA Cookie Consent: by Really Simple Plugins – 6.4.3
Easy Forms for Mailchimp: by YIKES, Inc. – 6.8.8
Enable Media Replace: by ShortPixel – 4.1.1
Enhanced Media Library: by wpUXsolutions – 2.8.9
GDPR Compliance for Mailchimp: by YIKES, Inc. – 1.3.7
Health Check & Troubleshooting: by The WordPress.org community – 1.6.0
Insert Pages: by Paul Ryan – 3.7.6
Kadence Blocks - PRO Extension: by Kadence WP – 1.7.28
Kadence Blocks – Gutenberg Blocks for Page Builder Features: by Kadence WP – 3.0.33
Kadence Simple Share: by Kadence WP – 1.2.6
Kadence Slider: by Kadence WP – 2.3.4
Kadence Widget Dock: by Kadence WP – 1.0.6
Loco Translate: by Tim Whitlock – 2.6.4
Login for Google Apps: by WPGlogin Team – 3.4.5
Members: by MemberPress – 3.2.4
Polylang: by WP SYNTEX – 3.3.3
Rank Math SEO: by Rank Math – 1.0.112
SiteGround Optimizer: by SiteGround – 7.3.1
UpdraftPlus - Backup/Restore: by UpdraftPlus.Com, DavidAnderson – 1.23.3
User Menus: by Code Atlantic – 1.3.1
Wordfence Security: by Wordfence – 7.9.2
WP-DraftsForFriends: by Lester 'GaMerZ' Chan – 1.0.2

Inactive Plugins

SiteGround Security: by SiteGround – 1.4.1
Widget Logic: by WPChef – 5.10.4

Active MU Plugins

Health Check Troubleshooting Mode: by – 1.8.1
WP STAGING Optimizer: by René Hermenau – 1.5.1

Theme

Name: Ascend Premium Child Theme
Version: 1.0
Author URL: https://www.odysseus-unbound.org/
Child Theme: Yes
Parent Theme Name: Ascend - Premium
Parent Theme Version: 1.9.25
Parent Theme Author URL: https://www.kadencewp.com/

Hi Matheus No problem with the delay. But, as my original post said, I was asking about legacy forms in the first place, not the new multi-step forms. As I said, I had already worked out that I could manage floating labels on a per form basis but the settings tab for legacy form templates still offers the global option even though it is no longer available. My original point remains: if you enable floating labels on legacy forms (on a per form basis) it stops the New PayPal donations gateway from displaying the PayPal button. Chrome inspector confirms that the html generated when floating labels are enabled cannot be parsed by paypal-commerce.js as it is currently coded. Cheers Julian

• This reply was modified 4 years, 2 months ago by JulianR.
• This reply was modified 4 years, 2 months ago by JulianR.

OK, if interested, an update. I’ve got my head around regex a bit and I’m almost certain it IS the wp_sanitize_redirect() function in WP. Careful inspection of the url I get to when redirected from the Give form reveals the dollar symbols have been stripped out.

The url I tell Give to redirect to:
.../dispatch/dag_id$0_hash$39da10bf0100a8b755b74f3a27aa76d820aaf1f6/Default.aspx

The url I get to after the redirect:
.../dispatch/dag_id0_hash39da10bf0100a8b755b74f3a27aa76d820aaf1f6/Default.aspx

Line 1300 of the code here https://developer.wordpress.org/reference/functions/wp_sanitize_redirect/ is:

$location = preg_replace( '|[^a-z0-9-~+_.?#=&;,/:%!*\[\]()@]|i', '', $location );

which is clearly designed to only allow a limited set of characters in the redirect url.

Though oddly, (and my understanding of regex is VERY limited) this looks like a malformed regex. Should it not be:

$location = preg_replace( '/[^a-z0-9-~+_.?#=&;,\/:%!*\[\]()@]/i', '', $location );

Have I found a bug in the WP code or am I missing something in my ignorance?

J