funnyprinter
Forum Replies Created
-
Yes, playing around with this, however doesn’t work for me with w3cache probably right now. Maybe just a misconfiguration.
Another idea: instead of writing the text into a own span and positing this over the image an option would be to add the source to the caption of the image? Maybe with a trigger in the options pane to decide where the source should be.
The advantage of this would be that no js would be necessary. Google page speed prefers to be able to render without js in the above the fold part of the webpage.
see above
Hi Thomas, it seems to me that there is still a bug in isc. For me its wrapping 2 images into one wrapper. So
isc_attachment_136 has attachment_136 a paragrahp and attachment_137 in it.
See here: http://www.dailycat.de/warum-katzen-kartons-als-spielzeug-lieben-131/I think dynamically creating the script element should load the script asyn and defer it. So:
(function(d) { var e = d.createElement("script"); e.src = "/wp-sript-url/.../front-js.js"; d.body.appendChild(e); }) (document);should be finde
I think the problem was that I expected the plugin to appear on the post image.
Does your module supply a method to get the source of an image? or better the html markup of the source of the post image?
I found the part in the theme there it builds the post image html tag
$buffy .= '<img width="' . $td_temp_image_url[1] . '" height="' . $td_temp_image_url[2] . '" itemprop="image" class="entry-thumb" src="' . $td_temp_image_url[0] . '" ' . $attachment_alt . $attachment_title . '/>';so my thought was to manually hook in here and add the isc html markup to show the source. Is there any simple way to do this?
Hi Thomas,
sorry for making 3 posts. Here I zipped 3 screenshots of one example were you see the problems with the html structure: http://www.manuelfink.de/upload/up/manu_20140602095656_JuSMqpBa_image_source_control_problems.zip
The problem is that closing div tags get lost. I had to remove the content since I need to take the site online to do the research of my master thesis.
the third screenshot was taken after I reduced the html markup to only img tags.Hope this helps fixing the bugs.
Kind regards.
Manuel
Also it’s not showing sources within the jetpack mosaic galerie.
Hi Thomas,
I tested it now on different servers with different themes. However it is somehow random than the source is shown or not and I cannot really find a pattern than it makes problems. Some findings:
- sometimes only the first pictures gets a source
- Random times other pics show a source too (not very often)
- If the image has a caption ([caption]) or link the html structure is somehow sometimes destroyed (theme is working without plugin perfectly).
- Sometimes it just helps to change something on a post and resave it?!
On my private blog its pretty random, showing up once in a while. I cannot reproduce when the source is shown and than not?! http://www.manuelfink.de/blog/2014/test-image-src-control/ Also images with captions start growing to left out of the page.
It seems that title images of themes (e.g. banners over the text) are not supported at all or?
Nor I think images within page builder are supported?Do I need to resave old posts that the sources are added?
Hi Ewout, probably this idea is not right in this thread, but have you thought of moving the plugin code from svn to git to allow pull and push requests? This would allow other programmers to contribute to the code easily.
Hey Ewout,
Just awesome, thx!
Just tested your dev version. Not sure if I understand right but it seems to me that you either show the order or invoice number/date. It looks for me that the functions returns one or the other. But haven’t time to seriously test or look into the code … pretty bussy right now sorry 🙁
I probably would recommend to have 4 functions so everyone can choose in the template which to show:
<?php $wpo_wcpdf->invoice_number(); ?> <?php $wpo_wcpdf->invoice_date(); ?> <?php $wpo_wcpdf->order_number(); ?> <?php $wpo_wcpdf->order_date(); ?>in my opinion for customers it’s best to show all 4, that they know which order the invoice belongs to.
Your checkbox may than only refer to the default template to turn the visibility of the invoice number and invoice date on and off.
More feature ideas
– I would add a prefix, suffix and a offset field to the template screen.
– Than I would add {year} as a replacement code.
– Ajax function to set/reset the current invoice counter.Forum: Plugins
In reply to: [Contact Form 7] [Plugin: Contact Form 7] Add Dynamic Fields to FormAs far as I know, WordPress is not able to handle dynamic/generic forms with conditions. I’d really appreciate such a feature too!