Web push enabled by default

Since the latest update (3.2.0) the Web push functionality seems to be enabled by default and the admin bar item is always visible. But there is no setting to disable it in the settings screen.

The doc block for the SIB_Push_Utils::is_push_active says, that it checks whether the “user hasn’t explicitly deactivated push (pushDeactivated in settings is false). But it doesn’t really check for the setting – it just get’s the settings and then does nothing:

$settings = SIB_Push_Settings::getSettings();

			// Check push application
			try {
				$app = self::get_push_application();
				if (!$app) return false;
				return self::application_is_active($app);
			} catch (Exception $e) {
				SIB_Push_Utils::log_error('Could not get application', $e);
				return false;
			}

get_push_application calls getWonderPushCredentials which always returns Credentials as long as a V3 API key is configured.

Request:

I’d like a way to disable the push functionality.

Manual Workaround:

Remove the following hook

add_action( 'admin_bar_menu', array( 'SIB_Push_Admin', 'add_admin_bar_menu_item' ), 100); (Added in SIB_Manager constructor)

• This topic was modified 1 year, 1 month ago by Fabian Todt.