• Resolved SPiNNdevs

    (@spinndevs)


    I really love your plugin and the idea on how to implement the responsive image feature leaning on the extension on native blocks. This way your plugins would also work in synced pattern overrides, which we lean on very heavily for our client work. Two thinks I noticed while testing which feels limiting:

    1. I was able to use the block with synced pattern overrides and replace the images. everything worked in the backend editor preview. But after saving and opening the page in the frontend, I only see the contents of the original synced pattern without the overrides.

    2. Although using the Auto (use editor preview) Mode, I always see other images too on the > desktop breakpoint.

    PS.: I tested the latest version on playground with no other changes

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Support Richard B

    (@richard-b)

    Hi, thank you so much for the kind words about our plugin. Very happy you find it useful and intend to use it for client work.

    1. Will investigate the synced patterns issue.

    2. Thank you for alerting us to this, you should only see the image for the breakpoint you are viewing, will fix and report back.

    Thanks again!



    Plugin Support Richard B

    (@richard-b)

    Hi again, hopefully the below answers your questions.

    1. Unfortunately, WordPress only supports the following core (unchanged) blocks for synced pattern overrides: Image, Heading, Paragraph and Button. As we use a custom container to wrap our image blocks overrides are not possible. The good news is the WordPress team are working on an opt-in mechanism for custom blocks and they are also exploring ways to enable overrides in more blocks.

    2. Please let us know if you are seeing more than one image > desktop breakpoint when using Auto mode, we have tried to replicate in playground but cannot replicate the results.

    Happy to continue here but please do feel free to reach out to us at [email protected] if you prefer to send screenshots etc or have any other functionality requests.

    Thanks
    Richard

    Thread Starter SPiNNdevs

    (@spinndevs)

    Hello, thank you for the very fast feedback! πŸ™‚

    1. yeah, hopefully WordPress make a move here, this is currently very limiting… BUT you plugin already works with synced pattern overrides in the Gutenberg backend editor. It “only” does not work correctly in the frontend. So I was wondering, if there would be a way to fix with the current status of WordPress.

    2. In the frontend everything is fine. But in the backend editor, Mode: Auto (use editor preview) always shows all images. To replicate, just start your playground “Live preview” link and edit your demo page. We are using the newest version of Chrome.

    Plugin Support Richard B

    (@richard-b)

    You are most welcome!

    1. Sadly not as we are very limited editor wise, we could technically allow editing of image source but the rest of the functionality (choosing a breakpoint etc) would not work and would appear to be broken.
    2. Yes I can see what you mean, this is actually intended functionality, so if you are in Auto mode and viewing desktop (most common config) you can see all the images so that they are easily editable + add more etc. If you specifically swap to desktop, tablet or mobile you see just those previews (or their fallbacks). Would be happy to make adjustments here if you feel there is a better way of doing this or that it is misleading in any way. We are always looking to make our plugins more user friendly and helpful.
    • This reply was modified 2 days, 8 hours ago by Richard B.
    Thread Starter SPiNNdevs

    (@spinndevs)

    1. I think allowing to change the image source it totally fine in many use cases. We often have the case that we are providing hero section as synced pattern with overrides and have pre defined breakpoints defined in the synced pattern and only want the user to edit/change the image source itself. So I think your plugin would be really helpful for this workflow and works like this already in the backend.

    2. Ah ok, I missed that this is the intended way it should work, or interpreted it wrong. I think was especially misleading is that there are other options which don’t change the default behaviour like Show All or Desktop. I think Desktop should only display the Desktop image, what it is not doing at the moment. Also “Auto (use editor preview)” sounds for me, like it should only display the desktop image in the editor of no other breakpoint was selected for the preview. Maybe a solution would be:
    – make “Show All” the default Option
    – update “Desktop” Mode to show only the Desktop image all the time
    – update “Auto (use editor preview)” to behave like the frontend “real” code

    Plugin Support Richard B

    (@richard-b)

    Firstly thank you so much for pushing 1. it made us look more deeply into the register_block_bindings_source() function and how it works, also your UX suggestions for the auto and all modes were perfect.
    So with that in mind here are the changes we have made:

    1. Synced pattern overrides now work correctly for image blocks inside the container and push to the <picture> element, this includes src, alt text and caption.

    2. We have made a lot of improvements here, we have simplified the controls so that All is default and an All / Auto toggle is available in the toolbar, we have also added a floating toolbar for those not using the top toolbar. Full controls are still available in the inspector (desktop, mobile etc). Also while cleaning up the UX we have made the Responsive Picture Block more selectable and easier to add extra images.

    Thank you again for your excellent feedback, our custom block is so much better for it!

    Thread Starter SPiNNdevs

    (@spinndevs)

    love it, thank your very much!

Viewing 7 replies - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.