Plugins URL improvement

Hello, MagniGenie Team!

I have a suggestion for an update for your plugins enqueue scripts.

Currently for your asset paths being set in wprmclass.php, plugins_url() is being concatenated as a prefix to the file pathsas such:
`plugins_url().’/wp-responsive-menu/css/wpr-hamburger.css’

For a client’s site, I have added this plugin to the mu-plugins directory in order to ensure that the site will always have the mobile navigation set properly, however this broke the plugin because the asset paths were not being set properly. I changed the paths be set as follows:
plugins_url('css/wpr-hamburger.css', dirname(__FILE__))

This enables the plugin to use the proper asset path whether it is set in either the plugins or mu-plugins directory.

From http://developer.wordpress.org/reference/functions/plugins_url/:

—
The plugins_url() function is commonly used in a plugin file. Passing the __FILE__ PHP magic constant in the place of the $plugin parameter makes the $path relative to the parent directory of that file:

1
echo '<img src="' . esc_url( plugins_url( 'images/wordpress.png', __FILE__ ) ) . '" /> ';

The above might output this HTML markup: <img src=”http://www.example.com/wp-content/plugins/my-plugin/images/wordpress.png&#8221; />.

If you are using the plugins_url() function in a file that is nested inside a subdirectory of your plugin directory, you should use PHP’s dirname() function:

echo '<img src="' . esc_url( plugins_url( 'images/wordpress.png', dirname(__FILE__) ) ) . '" /> ';

The above might output this HTML markup: <img src="http://www.example.com/wp-content/plugins/images/wordpress.png" />.
—

Thank you for your consideration on this!

• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.
• This topic was modified 6 years, 4 months ago by vermillionone.