Please remove space before menu-item span | WordPress.org

Resolved Bart De Vuyst
(@bartdevuyst)

12 years ago
Hi,

I love your plugin. Great idea. Easy to use!

I think you should remove a ‘space’ from your plugin though. I understand that this space allows for a nice space between the icon and the text, but I’m a designer and I’d like to control this space with css instead of space characters…

It’s on line 83, character 115:
```
$newtext = '<i class="'.implode( ' ', $fontawesome_classes ).'"></i><span class="fontawesome-text"> '.$text.'</span>';
```
http://wordpress.org/plugins/font-awesome-4-menus/

Viewing 3 replies - 1 through 3 (of 3 total)

Plugin Author Joe Ponzio
(@new-nine)

12 years ago

Understandable, but then we need a solution so that the text doesn’t smash up to the icon for users who aren’t taking fine grain control of their CSS. We could add another span just with a space in it (which could then be hidden with CSS), but now we have another tag and conceivably some bloat.

Any suggestions?
tiguan
(@tiguan)

11 years, 9 months ago
How about:
```
.fontawesome-text {
    padding-left: 10px;
}
```
Plugin Author Joe Ponzio
(@new-nine)

11 years, 7 months ago

We just pushed an update to Font Awesome 4 Menus adding an administrative screen that allows you to remove the space for finer control over your menus. Thanks for the suggestion!

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Please remove space before menu-item span’ is closed to new replies.

3 replies
3 participants
Last reply from: Joe Ponzio
Last activity: 11 years, 7 months ago
Status: resolved