Please Fix Deprecated Functions in Yotpo Plugin

restalfep
(@restalfep)

6 years, 11 months ago

The following are easy to fix by Yotpo and will prevent people’s logs from getting packed with error messages:

Line 438 of wc_yotpo should be: return $order->get_currency();

Not get_order_currency as that is deprecated.

Also:

Deprecated: Non-static method WooCommerce::plugin_path() should not be called statically in \plugins\yotpo-social-reviews-for-woocommerce\wc_yotpo.php on line 141

Deprecated: Non-static method WooCommerce::plugin_path() should not be called statically in \plugins\yotpo-social-reviews-for-woocommerce\wc_yotpo.php on line 145

Viewing 6 replies - 1 through 6 (of 6 total)

taylorsuk
(@taylorsuk)

6 years, 11 months ago

I second this – I’m sorting this out in the plugin files – however it could to with being sorted in core.

Deprecated: Non-static method WooCommerce::plugin_path() should not be called statically in /app/public/wp-content/plugins/yotpo-social-reviews-for-woocommerce/wc_yotpo.php on line 141 Deprecated: Non-static method WooCommerce::plugin_path() should not be called statically in /app/public/wp-content/plugins/yotpo-social-reviews-for-woocommerce/wc_yotpo.php on line 145

Thread Starter restalfep
(@restalfep)

6 years, 11 months ago

Taylorsuk, how did you fix it in the plugin files directly? I wasn’t sure what to change those 2 lines to. Thanks

Obviously, this isn’t ideal and Yotpo should fix it in the core plugin files so updates don’t overwrite it but I’m not sure if they are really monitoring this support forum. I also emailed them but receive no response.

hxii
(@hxii)

6 years, 10 months ago

Hey, I’ve submitted the fix but it may take a little while until it’s integrated.
You can see the changes that are necessary here: https://github.com/hxii/woocommerce-plugin/commit/9edaea96c7a9137c19f1446d98917a93d328bf99#diff-6f948e0570ea5f7f094e09f99755d830

Thread Starter restalfep
(@restalfep)

6 years, 10 months ago

Thanks! That $string= that you deleted doesn’t have to be replaced with anything else?

hxii
(@hxii)

6 years, 10 months ago

@restalfep Nope, doesn’t look like it’s used anywhere in the scope.

Thread Starter restalfep
(@restalfep)

6 years, 10 months ago

Thanks for the help!

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Please Fix Deprecated Functions in Yotpo Plugin’ is closed to new replies.