Hi @zaherg,
Thanks for your comment. These files are indeed not included in the release of the plugin, since they’re only needed during development for build processes and tooling; and not actually required for the ‘live’ plugin to work as intended.
While this might change in the future, we currently don’t distribute those files in the release. The released version contains all the compiled assets that are necessary for the plugin to function properly in production.
Kind regards, Jarno
Hey @jarnovos
The code is released under GPL-2.0-or-later license which means that even those small files should be included in the code, in the same way that the composer.json file has been included.
if you distribute copies of such a program, whether gratis or for a fee, you must give the recipients all the rights that you have. You must make sure that they, too, receive or can get the source code. And you must show them these terms so they know their rights.
GPL2.0 or later introduction
complete source code means all the source code for all modules it contains, plus any associated interface definition files, plus the scripts used to control compilation and installation of the executable.
GPL2.0 Terms and Conditions for Copying Distribution and Modification
Those missing file control the compilation of the source code, and should be included as part of the code, otherwise the plugin does not follow the license rules correctly.
Hey @zaherg,
That is a very valid point indeed. To expand on my earlier reasoning as to why this is currently the case: our aim is to make the package on WordPress.org as small as possible.
While I can’t provide an exact answer on when/how this will be addressed yet; we will definitely discuss & review our build process to make sure we’re properly including each of the necessary files, to ensure full GPL-2.0-or-later compliance.
Hope this helps to address your concern for the time being.
Thanks again for your careful attention and feedback here. It is much appreciated!
Kind regards, Jarno
Hey @jarnovos
Our aim is to make the package on WordPress.org as small as possible.
Those small files does not make the size of the package huge.
While I can’t provide an exact answer on when/how this will be addressed yet; we will definitely discuss & review our build process to make sure we’re properly including each of the necessary files, to ensure full GPL-2.0-or-later compliance.
I know its not my part, but publishing the full source code (and making it publicly available) to github/gitlab can help with that. As it will even helps removing the source code from the package pushed to wordpress while following the rules of GPL-2.0-or-later
Thanks
Hi @zaherg,
Thanks again for flagging this issue.
We actually already have a GitHub repository for the plugin, a mirror of our actual repository, but we haven’t set it to public yet. The reason for it to be private is the simple fact we have a couple of automation files in the repository that we do not like to make publicly available. We are researching a way to keep the repo in sync without showing these files, when we’ve finished this up we will set the repo to public.
In the meantime, if you’d like to have the package.json, we’re happy to share it with you. Just let us know.
Kind regards, Wim
Hey @wimbraam
Thank you so much, and I hope to see the mirrored repo public soon.
If you don’t mind sharing the whole code without the automation that would be nice.
Again, thanks again for you and @jarnovos
Amazing, thanks @wimbraam
