Maximum function nesting level when attempt Manage Images

G’day,

When set to “Show Ad preview before payment” and try to “Manage Images”, I’m getting a loop between AWPCP_Place_Ad_Page->preview_step() and AWPCP_Place_Ad_Page->upload_images_step().

It seems that it’s the comparison in AWPCP_Place_Ad_Page->should_show_upload_files_step() bringing it unstuck; if I change this:

if ( $limits['allowed_file_count'] > $limits['uploaded_file_count'] ) {
	return true;
}

to this:

if ( $limits['allowed_file_count'] >= $limits['uploaded_file_count'] ) {
	return true;
}

all is well, and I can enter the “Upload files” step again. The limits are still good, e.g. with limit of 1 image, I still can’t add another image without removing the existing image.

cheers,
Ross

https://wordpress.org/plugins/another-wordpress-classifieds-plugin/