Adding a simple float: left to the .widget class solved it (margin collapse).
Hi Karl,
It would help me if you could post a URL to a demo page where you have that problem. The plugin checks server side if the “block logic” has to be applied and then does or does not render the block.
It uses the PHP render_block filter: https://developer.wordpress.org/reference/hooks/render_block/
And just returns nothing if the block should be hidden.
if ($show_block) {
return $block_content;
} else {
return '';
}
`
Maybe the theme or any other plugin you use add any additional wrapper with the same filter out of my control?
But thanks for that info. I quite likely should increase the priority of the render_block filter, so it hopefully does run later than any other calls to that filter. Will do that with the next update, likely for the release of 5.8.
And sorry for the late reply, I was on holiday the past week and only saw this today.
Thanks for the reply and explanation. So maybe it’s another wrapper then, I’m using Genesis from Studiopress.
The hidden block shows up in the HTML code like this:
<section id="block-9" class="widget widget_block"><div class="widget-wrap"></div></section>
I’ll see if I can provide a live example, the current dev site is too messy to share here, especially since we can’t edit posts. But problem solved for now. I appreciate your willingness to help!
Hmm, I just tested it on simple core paragraph block in a widget area on a simple theme. There is none of that markup above, but just straight forward block markup from WordPress.
Ok, I downloaded Genesis and it does add some markup to widgets.
See:
function genesis_register_widget_area( $args ) {
$defaults = [
'before_widget' => genesis_markup(
[
'open' => '<section id="%%1$s" class="widget %%2$s"><div class="widget-wrap">',
'context' => 'widget-wrap',
'echo' => false,
]
),
'after_widget' => genesis_markup(
[
'close' => '</div></section>' . "\n",
'context' => 'widget-wrap',
'echo' => false,
]
),
'before_title' => '<h4 class="widget-title widgettitle">',
'after_title' => "</h4>\n",
];
/**
* A filter on the default parameters used by <code>genesis_register_widget_area()</code>. For backward compatibility.
*
* @since 1.0.1
*/
$defaults = apply_filters( 'genesis_register_sidebar_defaults', $defaults, $args );
/**
* A filter on the default parameters used by <code>genesis_register_widget_area()</code>.
*
* @since 2.1.0
*/
$defaults = apply_filters( 'genesis_register_widget_area_defaults', $defaults, $args );
$args = wp_parse_args( $args, $defaults );
return register_sidebar( $args );
}
So unfortunately this is really out of my control.
Can I close this as resolved?
Obviously you can use their filters to change that markup, but that might break other things/styling.
Aha, interesting that Genesis adds that. Yes, mark as resolved. Thanks for looking into it!
Ok, will do.
Leave a plugin review if you like!
I was already writing it. 😉
