Getting extra space over button text

  • kidznc

    (@wsp-kk)


    8 years, 4 months ago

    Hello!

    Recently – and I think this was after an EDD update – I’ve been getting an extra paragraph in each button, right above the text. Apparently, an extra <br> tag is being between the link itself and the text, as follows:

    <a href="(URL)" class="edd_free_link button blue edd-submit"><br>
	<span class="edd-add-to-cart-label">Open</span><br>
</a>

    If I remove that <br> tag in my code inspector, the buttons show correctly.

    Let me know if this is affecting any other users. Been using this plugin without issue for about a year on another page, but have updated neither EDD or this plugin since then.

    • This topic was modified 8 years, 4 months ago by kidznc.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author webaware

    (@webaware)

    8 years, 4 months ago

    G’day wsp-kk,

    I just checked in a couple of different themes, and I don’t get that problem. Can you try changing the theme temporarily to see if it’s something your theme is doing? Perhaps also try disabling plugins that change the page content.

    Also, if you deactivate this plugin, does the normal Add to Cart button have the same problem?

    cheers,
    Ross

    Thread Starter kidznc

    (@wsp-kk)

    8 years, 4 months ago

    Dear Ross:

    Sorry for the delay; been busy and haven’t been able to get to the site.

    Found out the problem, but – for the record – this is what I did (I typed it; might as well share it!):

    I turned off the custom child theme, and turned on the unmodified theme (Photolite). Problem remained. Same result with the defaults (Twenty Fourteen through Sixteen). This was with all plugins running.

    Then I reactivated the custom child theme, deactivated EDD Free Link to run EDD as normal. The extra <br> disappeared and the button was displayed normally.

    One thing I completely failed to mention though is that this happens only when populating the downloads on a list by shortcode, e.g., [downloads], the <br> problem is not present on the actual download page. That’s when I realized that Site Origin PageBuilder might have been causing it, so I unchecked “Automatically Add Paragraphs.”

    Bingo. Problem solved. No extra <br>.

    Sorry for giving you unnecessary heartburn over this!

    Best,

    -Kurt

    Plugin Author webaware

    (@webaware)

    8 years, 4 months ago

    G’day Kurt,

    Thanks for the followup. Curious that it happens for the Free downloads but not with the standard Download buttons; something for me to look at.

    Glad that you resolved the problem on your site though!

    cheers,
    Ross

    Thread Starter kidznc

    (@wsp-kk)

    8 years, 4 months ago

    Dear Ross:

    My thoughts exactly – it’s not as if the .PHP code from Free Link warrants PageBuilder adding a paragraph where there wasn’t one with the standard version of EDD.

    In fact, I ran across the problem again on another (unrelated) site over the weekend, which uses a completely unrelated theme. Same issue: PageBuilder automatic paragraphs were affecting EDD Free Link only, not EDD w/o the link.

    I’d say it’s safe to mark this as resolved, though I’d really like to hear if you find the culprit – if only out of .PHP coding curiosity. (I’m not particularly good at .PHP, but I’m always eager to learn more about it).

    -Kurt

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Getting extra space over button text’ is closed to new replies.