Hi Cesare,
that is great to hear. I have corrected most of the errors in the original plugin. The offset “errors” are just warnings, however merging the changes on the current version should not be trivial. You should clone the github project in your github account and locally, checkout tag 14.6 and create a new branch from it where you apply your patches. You can then commit your changes and push the new branch to your github clone. Finally you can pull request me via github. I can do the merging part.
If you are not familiar with git and do not want to learn it, you can also upload your version somewhere and post the link here.
I can try to learn git.
But one thing: i have done most of the work on the 14.8, since I saw it was out.
Most are to eliminate the “notices”, which, when you are developing themes and plugins, are really annoying.
There is also a correction to the Listbox field, which otherwise does not work.
I can make a list.
If I have used 14.8 I should checkout 14.8, right ?
If you have done most of the work on 14.8, you can just checkout the git HEAD in master branch. That is always the last version. In this case you can commit and push on the same branch (master) and do not need to create a new branch.
ok, I’ve cloned it on my pc and am finishing to clean out the notice messages…
When I’m finished will let you know
I have finished to modify the cote in order to eliminate all the warnings (& also errors).
I have been testing sometime in both a test and a production environment and I have no more messages while in debug mode.
However, I work without ajax, and right now have no time to set up a test with ajax.
If you like, I can upload the sources in github, or send them to you somehow. Let me know what you prefer…
Cesare
Great! I prefer the GitHub way, because you can then see with little effort who contributed to the project. Just pull request me when you have pushed your changes.
Ok, i’m in Florence for the week end with a veeeery slow internet line, so I will push it sunday night or monday.
Hi,
I saw that you had moved forward to 14.8.1 so i aligned cforms.php and lib_nonajax.php, then i commited them and tried to push.
However when i give the password, I get the error
————-
Password for ‘https://[email protected]’:
remote: Permission to bgermann/cforms2.git denied to cbacchini.
fatal: unable to access ‘https://[email protected]/bgermann/cforms2/’: The requested URL returned error: 403
————
I don’t have time to look after this now, but maybe you know what has to be done. (NB: i’m using a windows 8 portable)
You are trying to push to my repository, but you do not have the right to do that. As I mentioned before, you first have to clone my repository to your GitHub account, so that you can use the URL https://github.com/cbacchini/cforms2. You can then either add that as a remote to your existing local clone and push your changes to that remote or clone from that URL, copy the changed files, commit and push.
Ok, I had misunderstood and skipped the creation of my own copy on the github. I now understand and this makes much more sense, of course.
So i created the clone, redid the checkuot on my PC and checked again the corrections. Did the pull request, and added a comment trying to be as clear as possible…
Let me know !
Thank you! I will have a look on it and integrate it asap.
