We already run Authorizer in production with php7 (on Ubuntu 16.04.1 servers). Haven’t tested it on Windows servers yet, but I doubt mixed line endings would cause any problems.
If you’d like to clean up line endings, pull requests are appreciated!
https://github.com/uhm-coe/authorizer
Hi Paul – I’ll happily send in a pull request. One question first – the plugin has an “inc” folder on my production site, but it’s not included in the Git repo you linked to. Some of the reported problems are in that “inc” folder. Should I just send in a pull request for the files I can access, or is there a way to update those too so that all of the warnings can be removed?
Thanks!
“inc” folder was renamed to “vendor” in version 2.6.4, released Jan 6:
https://github.com/uhm-coe/authorizer/commit/2345d0d04c9851fd0e04fb8d9bb9587710c01905
Latest commit in master is functional (there’s a few fixes in there that will make it into the upcoming version 2.6.6), so please base the pull request off that if possible.
It makes sense that the inc/vendor folder has the mixed line endings, since those are external libraries from others (with different development environments). I have no problem standardizing them though!
Aha, that makes sense. We were running 2.6.5 but our server permissions must have prevented /inc/ from being renamed with the update. I sent over a pull request – I’m a little new to Git but hopefully I set everything up correctly. With updated line breaks, all the code passes. Thanks again for an awesome plugin and your willingness to update the line breaks to prevent those warnings.
