Awesome, thank you @cvscvstechcom. I’m glancing over Sweetalert2 and looking forward to your update.
Hey @tincabin and @sbernado! Here’s a very early version, please feel free to download and evaluate. No real customization yet, but I’d like to know if you both feel that this addresses the accessibility issues.
https://cvstech.com/beta-test/
Go to the Display tab in exit notifier settings and choose SweetAlert2.
Thank you, Curtis! I will give this a go as soon as I can. I’ll post back my findings. Thank you!
Thank you! We’ll try to give this a quick test and let you know.
Hi Curtis! This worked perfectly for me. It selects the “OK” button by default and then toggles between cancel and ok buttons when pressing the tab key. The Popup style looks more modern and clean – love it. And the popup closes with the escape key. I also ran the AXE chrome plugin on the page and no errors were found. Nice work!!! Thanks a million, Curtis!
-
This reply was modified 5 years, 6 months ago by
sbernado.
-
This reply was modified 5 years, 6 months ago by sbernado.
Excellent! Thanks so much for the testing! I’ll work on adding more configuration and get 1.8.0 released officially in the next few days.
Awesome! Thank you so much š
Hey @sbernado and @tincabin!
Well, some exciting news, jAlert has been updated to address accessibility! I’m working now on updating it. I may hold off on implementing SweetAlert2 any more than i have if it works to everyone’s satisfaction. Please uninstall Exit Notifier and re-download the beta here: https://cvstech.com/beta-test/
Let me know how it goes!
Okay all, 1.8.1 is live. Please let me know if there are any issues, and specifically anything not addressed for accessibility.
Thanks!
Awesome! I will let you know as soon as I am able to test it out. Thank you for the heads up and all your hard work porting this over. Much appreciated!
Hi @cvscvstechcom,
Unfortunately it’s not working on my end for some reason. I’ll have to dig deeper to figure out what’s going on, but with the new update it highlights the continue button on open, and you can tab forward to the cancel button. It does the same with shift-tab, shifting focus from continue to cancel. However, once it gets to cancel, you can’t tab off of it at all, so there’s no way to get back to continue. The close button (“closejAlert ja_close ja_close_round”, not actually a button or a link, just a clickable div) is not navigable by keyboard at all and is still only clickable by mouse. That was something specifically pointed out by our auditing agency.
Sorry, wish I had better news.
Are you using a caching plugin? Or one that minifies javascript? Those can keep the old version of the library around until they are cleared. That’s the only thing I can think of right out of the gate.
Can you test against https://cvstech.com/exitnotifier/ and see if you see the same problems?
Hi Curtis – I have the same issues as TinCabinStudios noted. On your test page, if I hit tab multiple times, the focus gets lost and I cannot exit the popup. I think in the beta you let us try a couple of weeks ago, the focus would toggle back and forth between the OK and Cancel buttons infinitely, with each press of the tab key, and the escape key would properly exit the popup.
To reproduce my results, go to: https://cvstech.com/exitnotifier/ >> Click external link >> Hit tab key 2 or more times >> hit escape key (popup does not close) >> Or press enter and nothing happens
HTH š
-
This reply was modified 5 years, 6 months ago by sbernado.
Wow. First of all, to both of you, thanks for the excellent feedback! So helpful!
However, what I see seems to be different, even on my own site. When I click the link on https://cvstech.com/exitnotifier/, the window pops up with the Go button selected. Hit tab, then Cancel is selected. Tab again and the address bar has focus. Tab again and the close button in the upper right corner of the Exit Notifier has focus. Once more and focus is back on the Go button. It will continually cycle that loop until I hit escape and the box closes as long as focus is not on the address bar. I can run that loop ten times and hit escape with the focus on anything but the address bar and the box will close. If I hit enter when the Go button has focus it will activate the link.
There’s no caching involved on either of your sites? I have disabled caching on mine for now.
Can either of you grab your copy of wp-content/plugins/exit-notifier/assets/js/jAlert.min.js and see if you can find this string in it: alertWrap.hide(),toggleFocusTrap()
If you can, then you’re working from the correct version. If not, then you still have the old version of jAlert without the fixes. Let me know what you find!
Thanks @sbernado and @tincabin
