Gate #![reexport_test_harness_main] properly rust-lang/rust#152210
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.
r? @fee1-dead
rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
- People who recently interacted with files modified in this PR:
compiler compilerexpanded to 20 candidates- Random selection from 12 candidates
@bors try
View on GitHub
@craterbot check
👌 Experiment pr-152210 created and queued.
🤖 Automatically detected try build 79452e8
🔍 You can check out the queue and this experiment's details.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
(for reference, this was discussed in #t-compiler > MCP needed for gating an accidentally stable attribute?)
🚧 Experiment pr-152210 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🎉 Experiment pr-152210 is completed!
📊 6 regressed and 8 fixed (818761 total)
📊 2503 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Footnotes
-
re-run the experiment with
crates=https://crater-reports.s3.amazonaws.com/pr-152210/retry-regressed-list.txt↩
All changes in the crater run are spurious.
@rust-lang/lang are you ok with this change?
r=me if you are
View on GitHub
☔ The latest upstream changes (presumably #153026) made this pull request unmergeable. Please resolve the merge conflicts.
We talked about this in the meeting today. Let's propose to do this. Some people may do some further investigation; if we find things, we'll file concerns.
@rfcbot fcp merge lang
View on GitHub
Error encounted:
Provided team `` is invalid
View on GitHub
@rfcbot fcp merge lang
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.
@rfcbot reviewed
🔔 This is now entering its final comment period, as per the review above. 🔔
If anyone wonders the history, I tracked the git blame: the original marker as explicitly “ungated” came in https://github.com/rust-lang/rust/pull/28077/changes#diff-67980357baa8318a775fe4bc05336ea3feba90a64b58d0f8259e2665b2a719dbR237; the fixme comment was introduced in https://github.com/rust-lang/rust/pull/63824/changes#diff-2a0098fbcad74c47eafa44fd374d9f5740476a3af0134d9ec1bdc33e736a8063R188
the original marker as explicitly “ungated” came in
That just made the default explicit, didn't it? Adding it ungated happened in #22364.
This seems like an obvious case of "this probably wasn't a vetted stabilization", and given that it seems like this attribute shouldn't be used without test_runner, adding a feature gate seems obviously appropriate.
Rebased
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
@bors r+ rollup
View all comments
Address the FIXME
Removed from
issue-43106-gating-of-builtin-attrs.rssince that is for stable attributes only.This would be a breaking change, search of github shows it is mostly but not always used with
#![test_runner]which is already gated correctly.Details:
#50297
Feel free to close this issue if you think it is not worth addressing the FIXME...