Project

General

Profile

Actions

QA Run #70197

closed

wip-pdonnell-testing-20250227.172146-debug

Added by Patrick Donnelly 12 months ago. Updated 12 months ago.


Description

  • PR #62008 -- qa: disable multimds pjd suite testing
  • PR #61991 -- qa: remove unreacheable/redundant code from test_data_scan.py
  • PR #61682 -- mds: include cleanup
  • PR #60746 -- client,mds: case-insensitive directory trees
Actions #1

Updated by Patrick Donnelly 12 months ago

  • Subject changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
  • Shaman Build changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
  • QA Runs changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
  • Git Branch changed from ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.022829-debug to ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.023256-debug
Actions #2

Updated by Patrick Donnelly 12 months ago

  • Subject changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
  • Shaman Build changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
  • QA Runs changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
  • Git Branch changed from ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.023256-debug to ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.172146-debug
Actions #3

Updated by Patrick Donnelly 12 months ago ยท Edited

Original run:

https://pulpito.ceph.com/?branch=wip-pdonnell-testing-20250227.023256-debug

Retesting with fix for

https://pulpito.ceph.com/pdonnell-2025-02-27_04:35:11-fs:libcephfs-wip-pdonnell-testing-20250227.023256-debug-distro-default-smithi/8156855/

 src/test/libcephfs/test.cc | 11 ++++++++---                                                                                                                                
 1 file changed, 8 insertions(+), 3 deletions(-)                                                                                                                            

diff --git a/src/test/libcephfs/test.cc b/src/test/libcephfs/test.cc                                                                                                        
index 43fed1ad122f..887b12046e64 100644                                                                                                                                     
--- a/src/test/libcephfs/test.cc                                                                                                                                            
+++ b/src/test/libcephfs/test.cc                                                                                                                                            
@@ -2060,11 +2060,15 @@ TEST(LibCephFS, SetSize) {                                                                                                                          

 TEST(LibCephFS, OperationsOnRoot)                                                                                                                                          
 {                                                                                                                                                                          
+  UserPerm *rootcred = ceph_userperm_new(0, 0, 0, NULL);                                                                                                                   
+  ASSERT_TRUE(rootcred);                                                                                                                                                   
   struct ceph_mount_info *cmount;                                                                                                                                          
-  ASSERT_EQ(ceph_create(&cmount, NULL), 0);                                                                                                                                
-  ASSERT_EQ(ceph_conf_read_file(cmount, NULL), 0);                                                                                                                         
+  ASSERT_EQ(0, ceph_create(&cmount, NULL));                                                                                                                                
+  ASSERT_EQ(0, ceph_conf_read_file(cmount, NULL));                                                                                                                         
   ASSERT_EQ(0, ceph_conf_parse_env(cmount, NULL));                                                                                                                         
-  ASSERT_EQ(ceph_mount(cmount, "/"), 0);                                                                                                                                   
+  ASSERT_EQ(0, ceph_init(cmount));                                                                                                                                         
+  ASSERT_EQ(0, ceph_mount_perms_set(cmount, rootcred));                                                                                                                    
+  ASSERT_EQ(0, ceph_mount(cmount, "/"));                                                                                                                                   

   char dirname[32];                                                                                                                                                        
   sprintf(dirname, "/somedir%x", getpid());                                                                                                                                
@@ -2094,6 +2098,7 @@ TEST(LibCephFS, OperationsOnRoot)                                                                                                                     
   ASSERT_EQ(ceph_symlink(cmount, "nonExistingDir", "/"), -EEXIST);                                                                                                         

   ceph_shutdown(cmount);                                                                                                                                                   
+  ceph_userperm_destroy(rootcred);                                                                                                                                         
 }                                                                                                                                                                          

 // no rlimits on Windows                                                                                                                                                   
Actions #4

Updated by Patrick Donnelly 12 months ago

And this QA patch:

diff --git a/qa/tasks/cephfs/mount.py b/qa/tasks/cephfs/mount.py
index 4f08ab8d1df..ddf6c2657a0 100644
--- a/qa/tasks/cephfs/mount.py
+++ b/qa/tasks/cephfs/mount.py
@@ -1600,16 +1600,19 @@ class CephFSMountBase(object):
         if kwargs.pop('sudo', False):
             kwargs['args'].insert(0, 'sudo')
             kwargs['omit_sudo'] = False
-        kwargs['wait'] = False
+        wait = kwargs.setdefault('wait', True)
+        if wait:
+            kwargs['wait'] = False
         p = self.run_shell(**kwargs)
         try:
-            p.wait()
+            if wait:
+                p.wait()
         except CommandFailedError as e:
             if helpfulexception:
                 return self._convert_attr_error(p, e)
             else:
                 raise
-        return str(p.stdout.getvalue())
+        return p

     def setfattr(self, path, key, val, helpfulexception=False, **kwargs):
         """ 
@@ -1624,16 +1627,19 @@ class CephFSMountBase(object):
         if kwargs.pop('sudo', False):
             kwargs['args'].insert(0, 'sudo')
             kwargs['omit_sudo'] = False
-        kwargs['wait'] = False
+        wait = kwargs.setdefault('wait', True)
+        if wait:
+            kwargs['wait'] = False
         p = self.run_shell(**kwargs)
         try:
-            p.wait()
+            if wait:
+                p.wait()
         except CommandFailedError as e:
             if helpfulexception:
                 return self._convert_attr_error(p, e)
             else:
                 raise
-        return str(p.stdout.getvalue())
+        return p

     def getfattr(self, path, attr, helpfulexception=False, **kwargs):
@@ -1647,10 +1653,15 @@ class CephFSMountBase(object):
         if kwargs.pop('sudo', False):
             kwargs['args'].insert(0, 'sudo')
             kwargs['omit_sudo'] = False
-        kwargs['wait'] = False
+        wait = kwargs.setdefault('wait', True)
+        if wait:
+            kwargs['wait'] = False
         p = self.run_shell(**kwargs)
         try:
-            p.wait()
+            if wait:
+                p.wait()
+            else:
+                return p
         except CommandFailedError as e:
             if helpfulexception:
                 return self._convert_attr_error(p, e)
Actions #7

Updated by Patrick Donnelly 12 months ago

  • Status changed from QA Approved to QA Closed
Actions

Also available in: Atom PDF