Actions
QA Run #70197
closedwip-pdonnell-testing-20250227.172146-debug
Shaman Build:
QA Release:
main
Tags (freeform):
Updated by Patrick Donnelly 12 months ago
- Subject changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
- Shaman Build changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
- QA Runs changed from wip-pdonnell-testing-20250227.022829-debug to wip-pdonnell-testing-20250227.023256-debug
- Git Branch changed from ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.022829-debug to ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.023256-debug
Updated by Patrick Donnelly 12 months ago
- Subject changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
- Shaman Build changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
- QA Runs changed from wip-pdonnell-testing-20250227.023256-debug to wip-pdonnell-testing-20250227.172146-debug
- Git Branch changed from ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.023256-debug to ceph/ceph-ci/commits/testing/wip-pdonnell-testing-20250227.172146-debug
Updated by Patrick Donnelly 12 months ago ยท Edited
Original run:
Retesting with fix for
src/test/libcephfs/test.cc | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/test/libcephfs/test.cc b/src/test/libcephfs/test.cc
index 43fed1ad122f..887b12046e64 100644
--- a/src/test/libcephfs/test.cc
+++ b/src/test/libcephfs/test.cc
@@ -2060,11 +2060,15 @@ TEST(LibCephFS, SetSize) {
TEST(LibCephFS, OperationsOnRoot)
{
+ UserPerm *rootcred = ceph_userperm_new(0, 0, 0, NULL);
+ ASSERT_TRUE(rootcred);
struct ceph_mount_info *cmount;
- ASSERT_EQ(ceph_create(&cmount, NULL), 0);
- ASSERT_EQ(ceph_conf_read_file(cmount, NULL), 0);
+ ASSERT_EQ(0, ceph_create(&cmount, NULL));
+ ASSERT_EQ(0, ceph_conf_read_file(cmount, NULL));
ASSERT_EQ(0, ceph_conf_parse_env(cmount, NULL));
- ASSERT_EQ(ceph_mount(cmount, "/"), 0);
+ ASSERT_EQ(0, ceph_init(cmount));
+ ASSERT_EQ(0, ceph_mount_perms_set(cmount, rootcred));
+ ASSERT_EQ(0, ceph_mount(cmount, "/"));
char dirname[32];
sprintf(dirname, "/somedir%x", getpid());
@@ -2094,6 +2098,7 @@ TEST(LibCephFS, OperationsOnRoot)
ASSERT_EQ(ceph_symlink(cmount, "nonExistingDir", "/"), -EEXIST);
ceph_shutdown(cmount);
+ ceph_userperm_destroy(rootcred);
}
// no rlimits on Windows
Updated by Patrick Donnelly 12 months ago
And this QA patch:
diff --git a/qa/tasks/cephfs/mount.py b/qa/tasks/cephfs/mount.py
index 4f08ab8d1df..ddf6c2657a0 100644
--- a/qa/tasks/cephfs/mount.py
+++ b/qa/tasks/cephfs/mount.py
@@ -1600,16 +1600,19 @@ class CephFSMountBase(object):
if kwargs.pop('sudo', False):
kwargs['args'].insert(0, 'sudo')
kwargs['omit_sudo'] = False
- kwargs['wait'] = False
+ wait = kwargs.setdefault('wait', True)
+ if wait:
+ kwargs['wait'] = False
p = self.run_shell(**kwargs)
try:
- p.wait()
+ if wait:
+ p.wait()
except CommandFailedError as e:
if helpfulexception:
return self._convert_attr_error(p, e)
else:
raise
- return str(p.stdout.getvalue())
+ return p
def setfattr(self, path, key, val, helpfulexception=False, **kwargs):
"""
@@ -1624,16 +1627,19 @@ class CephFSMountBase(object):
if kwargs.pop('sudo', False):
kwargs['args'].insert(0, 'sudo')
kwargs['omit_sudo'] = False
- kwargs['wait'] = False
+ wait = kwargs.setdefault('wait', True)
+ if wait:
+ kwargs['wait'] = False
p = self.run_shell(**kwargs)
try:
- p.wait()
+ if wait:
+ p.wait()
except CommandFailedError as e:
if helpfulexception:
return self._convert_attr_error(p, e)
else:
raise
- return str(p.stdout.getvalue())
+ return p
def getfattr(self, path, attr, helpfulexception=False, **kwargs):
@@ -1647,10 +1653,15 @@ class CephFSMountBase(object):
if kwargs.pop('sudo', False):
kwargs['args'].insert(0, 'sudo')
kwargs['omit_sudo'] = False
- kwargs['wait'] = False
+ wait = kwargs.setdefault('wait', True)
+ if wait:
+ kwargs['wait'] = False
p = self.run_shell(**kwargs)
try:
- p.wait()
+ if wait:
+ p.wait()
+ else:
+ return p
except CommandFailedError as e:
if helpfulexception:
return self._convert_attr_error(p, e)
Updated by Patrick Donnelly 12 months ago
- Status changed from QA Testing to QA Approved
Updated by Patrick Donnelly 12 months ago
- Status changed from QA Approved to QA Closed
Actions