Project

General

Profile

Actions
Copy link

Bug #69362

closed

the scrub reserver does not follow changes to osd_max_scrubs

Added by Ronen Friedman about 1 year ago. Updated 4 months ago.

Status:
Resolved
Priority:
High
Assignee:
Ronen Friedman
Category:
-
Target version:
-
% Done:

0%

Source:
Backport:
squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
OSD
Pull request ID:
61289
Tags (freeform):
backport_processed
Merge Commit:
091c7c5400f49e0ca16e8462ede8754b81f17b96
Fixed In:
v19.3.0-6889-g091c7c5400
Released In:
v20.2.0~1350
Upkeep Timestamp:
2025-11-01T01:29:41+00:00

Description

The original role of osd_max_scrubs did not require us to register for changes
of its value (the up-to-date value in the configuration DB was queried on
each use).

But as since https://github.com/ceph/ceph/pull/55340 - this configuration is
also used to limit the size of the scrub async reserver, we now must
actively react to changes in this item.

Related issues 1 (0 open — 1 closed)

Copied to RADOS - Backport #69374: squid: the scrub reserver does not follow changes to osd_max_scrubsResolvedRonen FriedmanActions
Actions
Copy link
 #1

Updated by Ronen Friedman about 1 year ago

  • Pull request ID set to 61184
Actions
Copy link
 #2

Updated by Ronen Friedman about 1 year ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #3

Updated by Ronen Friedman about 1 year ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Upkeep Bot about 1 year ago

  • Copied to Backport #69374: squid: the scrub reserver does not follow changes to osd_max_scrubs added
Actions
Copy link
 #5

Updated by Upkeep Bot about 1 year ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #6

Updated by Ronen Friedman about 1 year ago

  • Status changed from Pending Backport to In Progress
  • Pull request ID deleted (61184)

Turns out 61184 is not a fix. The problem should be fixed by https://github.com/ceph/ceph/pull/61289,
which is under review.

Actions
Copy link
 #7

Updated by Laura Flores about 1 year ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 61289
Actions
Copy link
 #8

Updated by Radoslaw Zarzynski about 1 year ago

  • Status changed from Fix Under Review to Pending Backport

The backports (squid, reef) are already sent and approved. Wait ing for QA.

Actions
Copy link
 #9

Updated by Ronen Friedman 10 months ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #10

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 091c7c5400f49e0ca16e8462ede8754b81f17b96
  • Fixed In set to v19.3.0-6889-g091c7c5400f
  • Upkeep Timestamp set to 2025-07-10T04:44:52+00:00
Actions
Copy link
 #11

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-6889-g091c7c5400f to v19.3.0-6889-g091c7c5400
  • Upkeep Timestamp changed from 2025-07-10T04:44:52+00:00 to 2025-07-14T19:37:53+00:00
Actions
Copy link
 #12

Updated by Upkeep Bot 4 months ago

  • Released In set to v20.2.0~1350
  • Upkeep Timestamp changed from 2025-07-14T19:37:53+00:00 to 2025-11-01T01:29:41+00:00
Actions
Copy link

Also available in: Atom PDF