THEME: Biancaa – 1.0.7

[themejunkie]

Biancaa - 1.0.7

BiancaA is a minimal, mobile ready, beautiful and easy-to-use Photoblogging WordPress theme. Demo: ​http://demo.theme-junkie.com/biancaa

Theme URL - ​http://www.theme-junkie.com/themes/biancaa/
Author URL - ​http://www.theme-junkie.com/

Trac Browser - https://themes.trac.wordpress.org/browser/biancaa/1.0.7
WordPress.org - ​https://wordpress.org/themes/biancaa/

SVN - ​https://themes.svn.wordpress.org/biancaa/1.0.7
ZIP - ​https://wordpress.org/themes/download/biancaa.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=biancaa/1.0.6&new_path=biancaa/1.0.7

History:

Ticket	Summary	Status	Resolution	Owner
#20699	THEME: Biancaa - 1.0.0	closed	not-approved	pratikshrestha
#22456	THEME: Biancaa - 1.0.4	closed	live	chemiker
#27071	THEME: Biancaa – 1.0.5	closed	live	karmatosed
#40680	THEME: Biancaa – 1.0.6	closed	live	themetracbot
#83550	THEME: Biancaa – 1.0.7	closed	not-approved	acosmin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

[acosmin]

@themejunkie

1. No PHP issues:

   Notice: Undefined index: title in wp-content\themes\biancaa\inc\classes\widget-about.php on line 46
   Notice: Undefined index: gravatar in wp-content\themes\biancaa\inc\classes\widget-about.php on line 52
   Notice: Undefined index: bio in wp-content\themes\biancaa\inc\classes\widget-about.php on line 56
   Notice: Undefined index: twitter in wp-content\themes\biancaa\inc\classes\widget-about.php on line 61
   Notice: Undefined index: facebook in wp-content\themes\biancaa\inc\classes\widget-about.php on line 65
   Notice: Undefined index: gplus in wp-content\themes\biancaa\inc\classes\widget-about.php on line 69
   Notice: Undefined index: linkedin in wp-content\themes\biancaa\inc\classes\widget-about.php on line 73
   Notice: Undefined index: title in wp-content\themes\biancaa\inc\classes\widget-slides.php on line 46
   Notice: Undefined index: count in wp-content\themes\biancaa\inc\classes\widget-slides.php on line 51
   

2. template-tags.php
   • L95, prefix the transient
   • L187, esc_html
   • L343, escape the href

3. plugins.php
   • prefix is wrong

4. extras.php
   • L94 Please add: if ( is_admin() ) return $length;
   • L83 Please add: if ( is_admin() ) return $more;
   • L134, plugin territory

5. customizer.php
   • L68,69, sanitize_email
   • L95-112, add theme support for custom logo instead.
   • L211,237 that's not a sanitization function for select. ​custom sanitization functions (don't forget to change/add a prefix) & ​a few included in WP Core
   • L347,348, those need to be prefixed.

6. theme-layouts.php
   • those need to be prefixed

7. widget-about.php
   • L93 sanitize_email, is_email returns false on fail

8. mailoptin.php
   • You have untranslatable lines.
   • L22
     • Save options in a single array
       • that's a separate option, use a theme mod for example.

9. No minification of scripts or files unless you provide original files
   • js/css folders
   • imagesloaded.pkgd.min.js this is also a Core script, enqueue or add as a dependency instead.

10. style.css is missing the Tested up to & Requires PHP header fields ​req

11. header.php
    • wp_body_open isn't used.
      • Fallback for wp_body_open()

        	if( ! function_exists( 'wp_body_open' ) {
        		function wp_body_open() {
        			do_action( 'wp_body_open' );
        		}
        	}
        

    • L7 make sure that the pingback_url is conditional since pings can be turned off.
      • is_singular() && pings_open( get_queried_object() ) and escape it.

12. please remove documentation.html

13. readme.txt
    • check your theme with the ​Readme Validator. Warnings are required to be fixed, except for the Stable tag warning. Notes are not required to be fixed.
    • no license information provided for any of the assets used in this theme: js/css/fonts/icons/images/image used in screenshot.png
    • Please use this format to declare license information for images:

      	Image for theme screenshot, Copyright Jason Blackeye
      	License: CC0 1.0 Universal (CC0 1.0)
      	Source: https://stocksnap.io/photo/4B83RD7BV9
      

    • Please use this format to declare license information for 3rd party assets/libraries:

      	SomeLibrary
      	Copyright (c) 2019-2021 Author Name
      	License: MIT License, https://opensource.org/licenses/MIT
      	Source: https://somelibrary.com
      

14. Please read the ​screenshot requirements carefully.

---

1. ​Skip link - not ok
   • non existent

2. ​Keyboard navigation - not ok
   • Some resources to help you:
     • ​Information on the requirement
     • Video help for: ​Modals, ​Links, ​Forms, ​Menus
     • Check TwentyTwenty using tab and shift+tab as an example
   • Issues with your theme:
     • Some elements have no style on focus, the green style button.
     • Mobile
       • burger button overlaps with the wp admin bar
         • it can't be focused or the visual order is wrong
         • once you open it focus should go on the close button and tabbing would focus the menu elements.
           • focus should be trapped inside the modal. Once you tab past the last menu item, the focus should go on the close button or close the menu. Once you shift+tab on the first element focus should go on the close button (and if you shift tab on this, it should focus the last element in the menu).

[acosmin]

No response, closing