THEME: Chocolate Passion – 1.0.1

[peterste]

Chocolate Passion - 1.0.0

A decluttered theme focused on readability and images.

Theme URL - ​http://github.com/peterhsteele/chocolate-passion
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/chocolate-passion/1.0.0
WordPress.org - ​https://wordpress.org/themes/chocolate-passion/

SVN - ​https://themes.svn.wordpress.org/chocolate-passion/1.0.0
ZIP - ​https://wordpress.org/themes/download/chocolate-passion.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#81552	THEME: Chocolate Passion – 1.0.1	closed	not-approved	acosmin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: Author URI: is missing from your style.css header.

[poena]

Hi Peter.. what went wrong with the screenshot? Please only submit complete themes.

[peterste]

new screenshot

[peterste]

Hi and thanks for the feedback. When I ran theme check plugin, it indicated the screenshot was the correct size even though it looked small to me. I have attached a larger one. I hope that will meet the requirement.

[poena]

Why is the screenshot distorted?
It is not a screenshot of the entire page. The screenshot has to look like the theme.

You have to include it in the zip file. We do not have access to making any changes for you.
Update the zip file and use the upload form again.

[themetracbot]

Chocolate Passion - 1.0.1

A decluttered theme focused on readability and images.

Theme URL - ​http://github.com/peterhsteele/chocolate-passion
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/chocolate-passion/1.0.1
WordPress.org - ​https://wordpress.org/themes/chocolate-passion/

SVN - ​https://themes.svn.wordpress.org/chocolate-passion/1.0.1
ZIP - ​https://wordpress.org/themes/download/chocolate-passion.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=chocolate-passion/1.0.0&new_path=chocolate-passion/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#81552	THEME: Chocolate Passion – 1.0.1	closed	not-approved	acosmin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

[peterste]

Thanks again for the guidance. Re-uploaded with the new screenshot.

[acosmin]

Hi @peterste
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme,
but we need you to read the requirements more carefully.
If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it looses it's position in the review queue.
When the update is submitted, a new ticket is created at the end of the queue.

​https://make.wordpress.org/themes/handbook/review/required/

​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

​https://github.com/WPTRT/theme-sniffer/

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

---

1. All ​Theme Sniffer reported Errors need to be fixed.

2. No PHP&JS issues:

   	Notice: Undefined index: chocolate_passion in X:\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php on line 2129
   
   Warning: get_class() expects parameter 1 to be object, null given in X:\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php on line 2129
   
   Warning: call_user_func() expects parameter 1 to be a valid callback, first array member is not a valid class name or object inX:\\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php on line 2129
   
   Fatal error: Uncaught Error: Call to a member function admin_init() on null inX:\\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php:2168 Stack trace: #0X:\\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php(2992): TGMPA_List_Table->_gather_plugin_data() #1X:\\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php(668): TGMPA_List_Table->prepare_items() #2X:\\wp-includes\class-wp-hook.php(287): TGM_Plugin_Activation->install_plugins_page('') #3 E:\Cosmin\xampp2\htdocs\review\wp-includes\class-wp-hook.php(311): WP_Hook->apply_filters('', Array) #4X:\\wp-includes\plugin.php(478): WP_Hook->do_action(Array) #5X:\\wp-admin\admin.php(254): do_action('appearance_page...') #6X:\\wp-admin\themes.php(10): require_once(') #7 {main} thrown inX:\\wp-content\themes\chocolate-passion\inc\class-tgm-plugin-activation.php on line 2168
   

Notice: Undefined index: menu-2 in \wp-content\themes\chocolate-passion\inc\template-tags.php on line 197
Notice: Undefined index: menu-3 in \wp-content\themes\chocolate-passion\inc\template-tags.php on line 197
Notice: Undefined index: menu-4 in \wp-content\themes\chocolate-passion\inc\template-tags.php on line 197
Notice: Undefined index: menu-5 in \wp-content\themes\chocolate-passion\inc\template-tags.php on line 197

3. Customizer
   • Adding a custom logo and removing it will make the text logo (and description) disappear aswell
   • Show Panels on Blog Page doesn't seem to do anything.

4. functions.php
   • L255, handle needs to be prefixed.

5. woocommerce.php
   • L35-84, missing escaping functions

6. template-functions.php
   • L26-30, plugin territory

7. customizer.php
   • L233, that's missing something, <?php ... ?>

8. remove
   • phpcs.xml.dist
   • LICENSE

9. header.php & header-banner-header.php
   • wp_body_open isn't used.
     • Fallback for wp_body_open()

           if( ! function_exists( 'wp_body_open' ) {
               function wp_body_open() {
                   do_action( 'wp_body_open' );
               }
           }
       

10. searchform.php
    • L15, placeholder needs to be translatable and escaped.

11. readme.txt
    • Missing license information for:
      • TGMPA
    • based on this ​https://www.freeimages.com/license , the license isn't GPL compatbile. ​Please change all your images.
      • Please use this format to declare license information for images:

        	Image for theme screenshot, Copyright Jason Blackeye
        	License: CC0 1.0 Universal (CC0 1.0)
        	Source: https://stocksnap.io/photo/4B83RD7BV9
        

---

1. Skip link - ok

2. Keyboard navigation - ok

[jrf]

The errors coming from TGMPA are caused by unauthorized and incorrect edits by the Theme author to the TGMPA file.

Downloading a fresh copy of TGMPA using the ​Custom TGMPA Generator should fix that.

[peterste]

Hello,
Thanks to both of you for your time. Sorry for the errors. I will re-submit. I have a couple of clarifying questions if you have time to answer, if not I understand.

Points 1 & 2 (PHP errors)

I can't seem to replicate the undefined index errors or any other php errors using theme-sniffer 1.1.3 (latest version) and php 7.1 - 7.3 on Mac OSX. Theme sniffer passes with no red items or warnings. Not expecting you to be able to diagnose, but do you have any offhand ideas about what could cause me to miss these notices?

Thanks for the tip about the TGMPA generator.

Point #6 - Theme vs Plugin Territory

Do you mind elaborating on your reasoning for this being plugin territory? The function you referenced ( inc/template-functions.php L26-30 ) creates a meta box which allows users to style a post differently, but doesn't affect content or functionality. The requirements say themes musn't add plugin functionalities and there is a rule against 'non-design related meta boxes', but that also seems to imply some meta boxes are ok.

thank you again!