WordPress.org
Get WordPress

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#79210 closed theme (not-approved)

THEME: HB Donation – 1.0.2

Reported by: hummingbirdthemes's profile hummingbirdthemes Owned by: ravisakya's profile ravisakya
Priority: new theme Keywords: theme-hb-donation child-theme parent-hb-charity
Cc: support@…

Description

HB Donation - 1.0.0

HB Donation is a charity WordPress theme which is meant for donation, NGO, Churches, fundraising and non profit websites. It can also be used for portfolio as well as personal and blogging websites. It is compatible with Contact form 7 and is translation ready. It is simple, adaptable, flexible and responsive theme.

Theme URL - ​http://hummingbirdthemes.com/themes/hb-donation/
Author URL - ​http://hummmingbirdthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hb-donation/1.0.0
WordPress.org - ​https://wordpress.org/themes/hb-donation/

SVN - ​https://themes.svn.wordpress.org/hb-donation/1.0.0
ZIP - ​https://wordpress.org/themes/download/hb-donation.1.0.0.zip?nostats=1
Parent Theme: ​https://wordpress.org/themes/hb-charity

History:

Ticket Summary Status Resolution Owner
#79210 THEME: HB Donation – 1.0.2 closed not-approved ravisakya

(this ticket)
#83018 THEME: HB Donation – 1.0.3 closed not-approved acosmin


https://themes.svn.wordpress.org/hb-donation/1.0.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: ​wp_footer 
     <?php wp_footer(); ?>
  • REQUIRED: Could not find wp_head. See: ​wp_head 
     <?php wp_head(); ?>
  • REQUIRED: Could not find language_attributes. See: ​language_attributes 
    <html <?php language_attributes(); ?>
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: ​add_theme_support 
     <?php add_theme_support( $feature ); ?>
  • REQUIRED: Could not find comments_template. See: ​comments_template 
     <?php comments_template( $file, $separate_comments ); ?>
  • REQUIRED: Could not find wp_list_comments. See: ​wp_list_comments 
     <?php wp_list_comments( $args ); ?>
  • REQUIRED: Could not find comment_form. See: ​comment_form 
     <?php comment_form(); ?>
  • REQUIRED: Could not find body_class call in body tag. See: ​body_class 
     <?php body_class( $class ); ?>
  • REQUIRED: Could not find wp_link_pages. See: ​wp_link_pages 
     <?php wp_link_pages( $args ); ?>
  • REQUIRED: Could not find post_class. See: ​post_class 
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example: 
    if ( ! isset( $content_width ) ) $content_width = 900;
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • REQUIRED: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: ​the Codex for an example implementation.
  • WARNING: The tag light has been deprecated, please remove it from your style.css header.
  • WARNING: The tag dark has been deprecated, please remove it from your style.css header.
  • WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hp-charity-child, hb-charity, hb-donation
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

Change History (9)

#1 @ravisakya
6 years ago

  • Keywords changed from theme-hb-donation, child-theme, parent-hb-charity, accessibility-ready to theme-hb-donation child-theme parent-hb-charity accessibility-ready
  • Owner set to ravisakya
  • Status changed from new to reviewing

#2 @ravisakya
6 years ago

@hummingbirdthemes

You have accessibility-ready tag. It will require another accessibility review. Which may take time. judging from the theme you haven't added skip links and keyboard navigation. I suggest you to remove that tag. Your parent theme doesn't have accessibility-ready tag also.

Issues

  1. Skip link not working ​https://make.wordpress.org/accessibility/handbook/markup/skip-links/
  1. Keyboard Navigation not working ​https://make.wordpress.org/themes/2019/08/03/planning-for-keyboard-navigation/
  1. Install the theme check plugin and fix all the issues. ​https://wordpress.org/plugins/theme-check/
  1. Install the theme sniffer plugin and fix all the errors. ​https://wordpress.org/plugins/theme-sniffer/
  1. get_theme_mod should be escaped. see your functions.php file and other files.

#3 @hummingbirdthemes
6 years ago

Hi @ravisakya

Thanks for the feedback. I will upload an updated theme in the next day or two.

-HBT

#4 @themetracbot
6 years ago

  • Keywords accessibility-ready removed
  • Summary changed from THEME: HB Donation – 1.0.0 to THEME: HB Donation – 1.0.1

HB Donation - 1.0.1

HB Donation is a charity WordPress theme which is meant for donation, NGO, Churches, fundraising and non profit websites. It can also be used for portfolio as well as personal and blogging websites. It is compatible with Contact form 7 and is translation ready. It is simple, adaptable, flexible and responsive theme.

Theme URL - ​http://hummingbirdthemes.com/themes/hb-donation/
Author URL - ​http://hummmingbirdthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hb-donation/1.0.1
WordPress.org - ​https://wordpress.org/themes/hb-donation/

SVN - ​https://themes.svn.wordpress.org/hb-donation/1.0.1
ZIP - ​https://wordpress.org/themes/download/hb-donation.1.0.1.zip?nostats=1
Parent Theme: ​https://wordpress.org/themes/hb-charity

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hb-donation/1.0.0&new_path=hb-donation/1.0.1

History:

Ticket Summary Status Resolution Owner
#79210 THEME: HB Donation – 1.0.2 closed not-approved ravisakya

(this ticket)
#83018 THEME: HB Donation – 1.0.3 closed not-approved acosmin


https://themes.svn.wordpress.org/hb-donation/1.0.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: ​wp_footer 
     <?php wp_footer(); ?>
  • REQUIRED: Could not find wp_head. See: ​wp_head 
     <?php wp_head(); ?>
  • REQUIRED: Could not find language_attributes. See: ​language_attributes 
    <html <?php language_attributes(); ?>
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: ​add_theme_support 
     <?php add_theme_support( $feature ); ?>
  • REQUIRED: Could not find comments_template. See: ​comments_template 
     <?php comments_template( $file, $separate_comments ); ?>
  • REQUIRED: Could not find wp_list_comments. See: ​wp_list_comments 
     <?php wp_list_comments( $args ); ?>
  • REQUIRED: Could not find comment_form. See: ​comment_form 
     <?php comment_form(); ?>
  • REQUIRED: Could not find wp_link_pages. See: ​wp_link_pages 
     <?php wp_link_pages( $args ); ?>
  • REQUIRED: Could not find post_class. See: ​post_class 
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example: 
    if ( ! isset( $content_width ) ) $content_width = 900;
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • REQUIRED: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: Non-printable characters were found in the acivation.php file. You may want to check this file for errors. 
    Line 9: 'name'               => __('GiveWP – Donation Plugin and Fundraising Platform','hb-donation' ),
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: ​the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • WARNING: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hb-donation, hb-charity
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

#5 @poena
6 years ago

Hi

Images of recognizable children are not allowed in the themes. Please note that this is for their protection, because the theme can be used for commercial use.
Normally, photos of people require a model release, ​https://en.wikipedia.org/wiki/Model_release
that is another reason you need to be extra careful with images of children, even if the image is public domain or similar.

With "recognizable" we mean children that are facing the camera; you can use photos where you cannot identify the children, for example, children facing way, or playing far in the background.

#6 @themetracbot
6 years ago

  • Summary changed from THEME: HB Donation – 1.0.1 to THEME: HB Donation – 1.0.2

HB Donation - 1.0.2

HB Donation is a charity WordPress theme which is meant for donation, NGO, Churches, fundraising and non profit websites. It can also be used for portfolio as well as personal and blogging websites. It is compatible with Contact form 7 and is translation ready. It is simple, adaptable, flexible and responsive theme.

Theme URL - ​http://hummingbirdthemes.com/themes/hb-donation/
Author URL - ​http://hummmingbirdthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hb-donation/1.0.2
WordPress.org - ​https://wordpress.org/themes/hb-donation/

SVN - ​https://themes.svn.wordpress.org/hb-donation/1.0.2
ZIP - ​https://wordpress.org/themes/download/hb-donation.1.0.2.zip?nostats=1
Parent Theme: ​https://wordpress.org/themes/hb-charity

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hb-donation/1.0.1&new_path=hb-donation/1.0.2

History:

Ticket Summary Status Resolution Owner
#79210 THEME: HB Donation – 1.0.2 closed not-approved ravisakya

(this ticket)
#83018 THEME: HB Donation – 1.0.3 closed not-approved acosmin


https://themes.svn.wordpress.org/hb-donation/1.0.2/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: ​wp_footer 
     <?php wp_footer(); ?>
  • REQUIRED: Could not find wp_head. See: ​wp_head 
     <?php wp_head(); ?>
  • REQUIRED: Could not find language_attributes. See: ​language_attributes 
    <html <?php language_attributes(); ?>
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: ​add_theme_support 
     <?php add_theme_support( $feature ); ?>
  • REQUIRED: Could not find comments_template. See: ​comments_template 
     <?php comments_template( $file, $separate_comments ); ?>
  • REQUIRED: Could not find wp_list_comments. See: ​wp_list_comments 
     <?php wp_list_comments( $args ); ?>
  • REQUIRED: Could not find comment_form. See: ​comment_form 
     <?php comment_form(); ?>
  • REQUIRED: Could not find wp_link_pages. See: ​wp_link_pages 
     <?php wp_link_pages( $args ); ?>
  • REQUIRED: Could not find post_class. See: ​post_class 
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example: 
    if ( ! isset( $content_width ) ) $content_width = 900;
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • REQUIRED: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: Non-printable characters were found in the acivation.php file. You may want to check this file for errors. 
    Line 9: 'name'               => __('GiveWP – Donation Plugin and Fundraising Platform','hb-donation' ),
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: ​the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • WARNING: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hb-donation, hb-charity
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See ​Widgets API

#7 @hummingbirdthemes
6 years ago

Hi @poena

I have updated the child theme to remove an images of children now.

#8 @ravisakya
6 years ago

@hummingbirdthemes

Issues

  1. Your Author URL is not opening.
  1. Install theme sniffer and fix all the errors. eg 327 ERROR Mismatched text domain. Expected 'hb-donation' but got 'hb-charity'.
  1. $wp_customize should be called inside a customize_register hook. Check your header.php eg. https://themes.trac.wordpress.org/browser/hb-donation/1.0.2/functions.php#L433
  1. Add this code after <body> tag. 
if ( function_exists( 'wp_body_open' ) ) {
	wp_body_open();
} else {
    do_action( 'wp_body_open' );
}

See here ​https://make.wordpress.org/themes/2019/03/29/addition-of-new-wp_body_open-hook/

  1. https://themes.trac.wordpress.org/browser/hb-donation/1.0.2/header.php#L41 use esc_attr()
  1. https://themes.trac.wordpress.org/browser/hb-donation/1.0.2/header.php#L57 Escaping Missing
  1. Version is different on style.css and readme.txt file.
  1. Remove this @import url('https://fonts.googleapis.com/css?family=Montserrat&display=swap'); from style.css and enqueue that in functions.php. eg . ​https://www.wpbeginner.com/wp-themes/how-add-google-web-fonts-wordpress-themes/
  1. Skip link not working ​https://make.wordpress.org/accessibility/handbook/markup/skip-links/
  1. Keyboard Navigation not working ​https://make.wordpress.org/themes/2019/08/03/planning-for-keyboard-navigation/

#9 @ravisakya
6 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Reviewers are allowed to close the ticket if no reply is made within 7 days.

Note: See TracTickets for help on using tickets.