THEME: Samaan – 1.1.3

[bohuan]

Samaan - 1.1.3

My WordPress blog theme.

Theme URL - ​https://wordpress.org/themes/samaan/
Author URL - ​https://profiles.wordpress.org/bohuan

Trac Browser - https://themes.trac.wordpress.org/browser/samaan/1.1.3
WordPress.org - ​https://wordpress.org/themes/samaan/

SVN - ​https://themes.svn.wordpress.org/samaan/1.1.3
ZIP - ​https://wordpress.org/themes/download/samaan.1.1.3.zip?nostats=1
Parent Theme: ​https://wordpress.org/themes/twentynineteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=samaan/1.1.2&new_path=samaan/1.1.3

History:

Ticket	Summary	Status	Resolution	Owner
#76153	THEME: Samaan – 1.1.2	closed	not-approved	bothera
#78127	THEME: Samaan – 1.1.3	closed	not-approved	ravisakya
(this ticket)

[ravisakya]

@bohuan

Themes that have 3 or more distinct issues may be closed as not-approved. However, theme authors may resubmit the theme once they’ve corrected the issues.

Issues

1. Accessibility

Keyboard Navigation:- In mobile the design is all over the place. I cannot test the keyboard navigation.

2. Code

There should not be any php or js errors.

All untrusted data should be escaped before output.
https://themes.trac.wordpress.org/browser/samaan/1.1.3/comments.php#L40 get_the_title needs escaping

Install Theme Sniffer plugin and fix all the issues ​https://wordpress.org/plugins/theme-sniffer/

3. Selling, credits, and links

REQUIRED: Using a WordPress.org Theme URI is reserved for official themes.

Theme URI is optional
If used, it must be about the theme we’re hosting on WordPress.org

See here ​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

4. Screenshot

The screenshot should be no bigger than 1200 x 900px
The ratio of width to height should be 4:3

ERROR The size of your screenshot should not exceed 1200x900, but screenshot.png is currently 1583x1992.

5. Licensing

Please add licensing in your readme.txt for all third party code (Bootstrap, Prettyphoto etc.)