THEME: Salvin – 0.0.2

[tryshameem]

Salvin - 0.0.1

An Elegants WordPress Blog Theme.

Theme URL - ​http://demo.melotheme.com/salvin
Author URL - ​http://shameem.me

Trac Browser - https://themes.trac.wordpress.org/browser/salvin/0.0.1

SVN - ​https://themes.svn.wordpress.org/salvin/0.0.1
ZIP - ​https://wordpress.org/themes/download/salvin.0.0.1.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#68048	THEME: Salvin – 0.0.2	closed	not-approved	timph
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are Salvin, salvin

[themetracbot]

Salvin - 0.0.2

An Elegants WordPress Blog Theme.

Theme URL - ​http://demo.melotheme.com/salvin
Author URL - ​http://shameem.me

Trac Browser - https://themes.trac.wordpress.org/browser/salvin/0.0.2

SVN - ​https://themes.svn.wordpress.org/salvin/0.0.2
ZIP - ​https://wordpress.org/themes/download/salvin.0.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=salvin/0.0.1&new_path=salvin/0.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#68048	THEME: Salvin – 0.0.2	closed	not-approved	timph
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[poena]

Hi
This is not a complete review.
I did some testing of readme files today.
Your result shows that you need to update the readme:

salvin
Trac Ticket Link: https://themes.trac.wordpress.org/ticket/68048
Readme: ​https://themes.svn.wordpress.org/salvin/0.0.2/readme.txt
The Requires PHP field is missing.

Images from Unsplash are not GPL compatible and must be removed.

[tryshameem]

Hi @poena Thanks for the basic review. Would you mind to elaborate which PHP field is missing.

Since I didn't used any images from unspalsh, so from credit I will remove unspalsh and re upload my theme file. but fore re uploading, I will be happy to know which php field is missing.

Thanks

[poena]

Hi

The PHP informations needs to be added to the header of the readme file.
Validate your file using this tool:
​https://wordpress.org/plugins/developers/readme-validator/

It is not enough to remove the incorrect license.
You have to add the license information for ALL assets.

[timph]

Hi @tryshameem thanks for your theme submission!

Here are some things I noticed without installing and activating your theme:

1. As @poena said, make sure you update your readme.txt to be correctly formatted and include the right information. You can use the ​Sample Readme for reference as to what is expected.

2. You must supply ​non-minified version of files if you supply minified version.

3. You should ​not make any external calls to services like instagram, twitter etc.

Found in: https://themes.trac.wordpress.org/browser/salvin/0.0.2/js/app.min.js#L2

4. You shouldn't include dev deps. Examples:

https://themes.trac.wordpress.org/browser/salvin/0.0.2/package-lock.json
https://themes.trac.wordpress.org/browser/salvin/0.0.2/package.json
https://themes.trac.wordpress.org/browser/salvin/0.0.2/gulpfile.js

5. Theme missing call to wp_body_open by ​hook or function.

6. All resources need to include their license information, and that includes the images used within your screenshot, js/scss/css libs used, and any other asset you did not create from scratch yourself (you don't have to include devdeps like gulp, sass, dart-sass etc - only production).

7. Theme URI should be to a page or site about your theme, not a demo URL.

As there are more than 3 distinct issues that require your intervention, I will be closing this ticket. Don't let that discourage you though - we don't hard-reject themes, so you will be able to make the changes required, and resubmit your theme for a new review. Please make sure you read over all submission ​requirements before you do.

It also highly suggested to run ​Theme Sniffer and ​Theme Check to make sure you address coding issues detected. Errors should be fixed, and warnings mean they need to be manually inspected to fix/ensure acceptability with the coding standards for themes.

We look forward to seeing your next submission @tryshameem !