Make WordPress Themes

Opened 8 years ago

Closed 8 years ago

#50530 closed theme (live)

THEME: simplll – 1.0.2

Reported by: wpmagg's profile wpmagg Owned by: acosmin's profile acosmin
Priority: new theme Keywords: theme-simplll
Cc: wpmagg@…

Description

simplll - 1.0.0

a simple WordPress theme by wpmagg

Theme URL - http://themes.wpmagg.com/simplll/
Author URL - http://wpmagg.com/

Trac Browser - https://themes.trac.wordpress.org/browser/simplll/1.0.0

SVN - https://themes.svn.wordpress.org/simplll/1.0.0
ZIP - https://wordpress.org/themes/download/simplll.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/simplll/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Attachments (1)

simplll.zip (81.5 KB) - added by wpmagg 8 years ago.
v1.0.1 with the requested fixes

Download all attachments as: .zip

Change History (11)

#1 @acosmin
8 years ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#2 @acosmin
8 years ago

  1. style.css:L105 - makes the wp admin toolbar's top margin 1.5ems.
  1. Theme URI can't be a demo, unless it presents info about the theme.
  1. Redo languages\simplll.pot - it's the default _s pot file.
  1. inc\customizer.php
    • all the labels need to be translatable, ex: L49
    • simplll_sanitize() is not a sanitization function, it doesn't do anything, just returns. In your case I would recommend absint().
    • L180-190, those variables need to be escaped before output.
      • also, why don't you use theme_mods instead of options
  1. Remove phpcs.xml.dist
  1. Fix the errors outputed by Theme Sniffer

#3 @acosmin
8 years ago

@wpmagg are you there? you have 2 more days... out of 7.

#4 @wpmagg
8 years ago

Hi @acosmin,

yes we are here working on the changes and will submit new files in a few hours.

Thanks.

Last edited 8 years ago by wpmagg (previous) (diff)

@wpmagg
8 years ago

v1.0.1 with the requested fixes

#6 @themetracbot
8 years ago

  • Summary changed from THEME: simplll – 1.0.0 to THEME: simplll – 1.0.1

simplll - 1.0.1

a simple WordPress theme by wpmagg

Theme URL - http://wpmagg.com/portfolio/simplll/
Author URL - http://wpmagg.com/

Trac Browser - https://themes.trac.wordpress.org/browser/simplll/1.0.1

SVN - https://themes.svn.wordpress.org/simplll/1.0.1
ZIP - https://wordpress.org/themes/download/simplll.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=simplll/1.0.0&new_path=simplll/1.0.1

History:


https://themes.svn.wordpress.org/simplll/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @themetracbot
8 years ago

  • Summary changed from THEME: simplll – 1.0.1 to THEME: simplll – 1.0.2

simplll - 1.0.2

a simple WordPress theme by wpmagg

Theme URL - http://wpmagg.com/portfolio/simplll/
Author URL - http://wpmagg.com/

Trac Browser - https://themes.trac.wordpress.org/browser/simplll/1.0.2

SVN - https://themes.svn.wordpress.org/simplll/1.0.2
ZIP - https://wordpress.org/themes/download/simplll.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=simplll/1.0.1&new_path=simplll/1.0.2

History:


https://themes.svn.wordpress.org/simplll/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#8 @wpmagg
8 years ago

just submitted with the reported fixes, thanks!

#9 @acosmin
8 years ago

Congrats @wpmagg ! Your theme should be live shortly...

#10 @acosmin
8 years ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.