Make WordPress Themes

Change History (3)

#1 @karmatosed
15 years ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#2 @karmatosed
15 years ago

Thank you for your theme submission, here are my findings on running the theme review.


Theme review results:

Below are the theme review results. Anything marked REQUIRED needs a resolution. Anything marked RECOMMENDED is suggested a fix but not a grounds for failing. Anything marked INFORMATION is there as a suggestion.


REQUIRED

Errors:

Notice: Undefined index: default in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 301

Notice: Undefined index: default in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 301

Notice: Undefined variable: style in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 302

Errors on 'Basic Press Settings' page:

Notice: Undefined index: th_class in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 250
Notice: Undefined index: th_class in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 250
Notice: Undefined index: th_class in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 250
Notice: Undefined index: th_class in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 250
Notice: Undefined index: th_class in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 259
Notice: Undefined index: default in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 217

Notice: Undefined index: action in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 142
Notice: Undefined index: action in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 158

Notice: Undefined index: default in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 217

Notice: Undefined index: saved in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 174
Notice: Undefined index: reset in /Applications/MAMP/htdocs/themetestwp/wp-content/themes/basic-press/functions.php on line 175

RECOMMENDED

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
RECOMMENDED: get_bloginfo(template_url) was found in the file functions.php. Use get_template_directory_uri() instead.
RECOMMENDED: bloginfo(template_directory) was found in the file footer.php. Use get_template_directory_uri() instead.
RECOMMENDED: bloginfo( template_directory ) was found in the file header.php. Use get_template_directory_uri() instead.


INFORMATION
The theme check was halted due to so many errors please check using DEBUG on and also using WordPress 3.2 and the test data to recreate.


RESULT: FAIL


This is a not complete review please fix the errors and resubmit.

If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.

Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Theme Check Plugin:http://wordpress.org/extend/plugins/theme-check/
Theme Unit Test:http://codex.wordpress.org/Theme_Unit_Test
Log Deprecated Notices: http://wordpress.org/extend/plugins/log-deprecated-notices/
Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php

You can also view the Theme Review page.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net

#3 @karmatosed
15 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.