THEME: Elif lite – 1.0.3

[asmi1]

Elif lite - 1.0.3

Elif lite is a Fashion WordPress blog theme based on the Bootstrap framework making it fully responsive and mobile friendly, Elif lite arrives ready for business right out of the box with 2 main blog layouts, custom sidebar positions, unlimited color styles and custom background support.

Theme URL - ​http://themient.com/themes/elif-lite
Author URL - ​http://themient.com

Trac Browser - https://themes.trac.wordpress.org/browser/elif-lite/1.0.3

SVN - ​https://themes.svn.wordpress.org/elif-lite/1.0.3
ZIP - ​https://wordpress.org/themes/download/elif-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=elif-lite/1.0.2&new_path=elif-lite/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#37132	THEME: Elif lite – 1.0.2	closed	not-approved	arvindsinghu
#40244	THEME: Elif lite – 1.0.3	closed	not-approved	poena
(this ticket)
#40275	THEME: Elif lite – 1.0.8	closed	live	wenthemes

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

[poena]

Hi
OK so that took slightly longer than 30 minutes... As you can see there are still more than 5 errors.
Please take your time to update and test the theme carefully. Ping me once you have fixed everything and uploaded the new version.

Please select one license. In style.css you are saying that your theme is GPLv2 or later but are linking to GPL 3.
License: GNU General Public License v2 or later
License URI: ​http://www.gnu.org/licenses/gpl-3.0.html

The theme needs to be 100% GPL compatible. I was unable to find license, copyright and source of the images,
including patterns and images used in the screenshot.

I could not find a copyright statement for the theme itself, this is required to use GPL.
See ​https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Themes are required to use WordPress functionality if available:
Instead of using your own custom code to include a logo, see ​https://make.wordpress.org/core/2016/03/10/custom-logo/
(Default logos are not allowed, -the user would want to use their own log, not yours.)
You need to use the standard WordPress background functionality. All you you would need to do is declare theme support and then
register your images. There are already settings for positioning.
You must also remove your custom css section and any related code, it is overwriting the new custom css section that was added in WordPress 4.7.

The mobile menu is overlapping the WordPress admin bar when I am logged in, this is not allowed.

All untrusted data should be escaped before output
All instances of home_url needs to be escaped as esc_url( home_url( '/' ) ), because it is not escaped by WordPress, see
​https://developer.wordpress.org/reference/functions/home_url/
​https://developer.wordpress.org/reference/functions/get_home_url/

Image sources also needs to be escaped with esc_url().
Example:
src="<?php echo elif_get_thumbnail

Theme options needs to be escaped before output, not only echoed.
This includes color and position options in the dynamic css.

Examples:
$footer_fb = get_theme_mod( 'footer_fb', ELIF_FOOTER_FB );
<a href="<?php echo $footer_fb; ?>" title="Facebook"
In the example above, the title text is also missing the translation function.

$article_link_text = get_theme_mod( 'article_link_text', ELIF_ARTICLE_TEXT );
echo $article_link_text;

$footer_text = get_theme_mod( 'footer_text', ELIF_FOOTER_TEXT );
echo $footer_text

Themes should only be backwards compatible for 3 versions, add_theme_support was added in 2.9.0.
functions.php: Remove if ( function_exists( 'add_theme_support' ) ) { and place all your add_theme_supports inside elif_setup().

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
functions.php: The imagesize names used in add_image_size needs to be prefixed.
customizer-output.php: The style and script handles in elif_animations_css() and elif_customizer_assets() needs to be prefixed.
I was unable to find the license and source of the menu walker: if this is not a third party script,
the class Mobile_Menu_Walker needs to be prefixed.

In customizer-sanitize.php,
elif_sanitize_text(), strip_tags is not enough to sanitize this type of content.

commons.php
This does not seem to be used in the theme: function elif_get_readmore_text()?
Instead you are hard coding it in content.php without escaping it:
$article_link_text = get_theme_mod( 'article_link_text', ELIF_ARTICLE_TEXT );
echo $article_link_text;

No minification of scripts or files unless you provide original files.
I was unable to find the non minified version of slidebars.min.css, bootstrap.min.css, slidebars.min.js, bootstrap.min.js.

Required to use core-bundled scripts rather than including their own version of that script.
Masonry and imagesLoaded are incuded in WordPress, use the correct version and remove the scripts from the theme folder.

---

The readme file refers to redwaves.zip?
Why have you added support for the html5 search form, only to overwrite it with another search form in searchform.php?