THEME: riseWP – 1.1.3

[modernthemesnet]

riseWP - 1.1.1

Rise is a multipurpose WordPress theme which can be used as a template for any type of website. The theme uses the WordPress core post format feature to generate portfolio and testimonial posts, so creating content has never been easier or more reliable. The clean and minimal design is the perfect way to build a creative business layout or maintain a beautiful blog. Visit ​https://modernthemes.net/theme-demos/?theme=Rise to see the demo of Rise up close.

Theme URL - ​https://modernthemes.net/wordpress-themes/rise
Author URL - ​https://modernthemes.net

SVN - ​https://themes.svn.wordpress.org/risewp/1.1.1
ZIP - ​https://wordpress.org/themes/download/risewp.1.1.1.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#36797	THEME: riseWP – 1.1.3	closed	live	acosmin
(this ticket)
#37098	THEME: riseWP – 1.1.4	closed	live	themetracbot
#37222	THEME: riseWP – 1.1.5	closed	live	themetracbot
#39334	THEME: riseWP – 1.1.6	closed	live	themetracbot
#42529	THEME: riseWP – 1.1.7	closed	live	themetracbot
#47410	THEME: riseWP – 1.1.8	closed	live	themetracbot
#72989	THEME: riseWP – 1.1.9	closed	live	themetracbot

[acosmin]

Required

• $blog_id = 0 is still present in the_custom_header(), header.php, line 38. This will cause issues with multisite.

Recommended

• New/blank lines are still present between <!-- risewp customizer CSS --><style> </style>. You can try it this way and it will solve the issue:

  $output = '.site-header .main-navigation a { color:' . get_theme_mod( 'risewp_nav_link_color', '#ffffff' ) . ' }';
  $output .= '.site-header .main-navigation a:hover { color:' . get_theme_mod( 'risewp_nav_link_hover_color', '#C4C5C5' ) . ' }';
  

  • and so on with the rest of them. You have a ​good example here. Unless @djrmom says its ok, I am ok with it too.
• A correct callback function for the "Home..." sections would be

  function risewp_home_tmpl_callback() { 
          if( is_page_template( 'template-page-home.php' ) 
          { return true; } else { return false; } 
  }
  

[themetracbot]

riseWP - 1.1.2

Rise is a multipurpose WordPress theme which can be used as a template for any type of website. The theme uses the WordPress core post format feature to generate portfolio and testimonial posts, so creating content has never been easier or more reliable. The clean and minimal design is the perfect way to build a creative business layout or maintain a beautiful blog. Visit ​https://modernthemes.net/theme-demos/?theme=Rise to see the demo of Rise up close.

Theme URL - ​https://modernthemes.net/wordpress-themes/rise
Author URL - ​https://modernthemes.net

SVN - ​https://themes.svn.wordpress.org/risewp/1.1.2
ZIP - ​https://wordpress.org/themes/download/risewp.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=risewp/1.1.1&new_path=risewp/1.1.2

History:

Ticket	Summary	Status	Resolution	Owner
#36797	THEME: riseWP – 1.1.3	closed	live	acosmin
(this ticket)
#37098	THEME: riseWP – 1.1.4	closed	live	themetracbot
#37222	THEME: riseWP – 1.1.5	closed	live	themetracbot
#39334	THEME: riseWP – 1.1.6	closed	live	themetracbot
#42529	THEME: riseWP – 1.1.7	closed	live	themetracbot
#47410	THEME: riseWP – 1.1.8	closed	live	themetracbot
#72989	THEME: riseWP – 1.1.9	closed	live	themetracbot

[modernthemesnet]

Hi @acosmin

-corrected the custom_logo and removed the $blog_id
-I removed all of the "if" conditional statements from the inline styles and now it all shows in the source. I put the if statements in there so that they don't show up if the setting is not used.
-installed a callback function for the home page sections

Let me know of anything else. Thanks!

Replying to acosmin:

Required

• $blog_id = 0 is still present in the_custom_header(), header.php, line 38. This will cause issues with multisite.

Recommended

• New/blank lines are still present between <!-- risewp customizer CSS --><style> </style>. You can try it this way and it will solve the issue:

  $output = '.site-header .main-navigation a { color:' . get_theme_mod( 'risewp_nav_link_color', '#ffffff' ) . ' }';
  $output .= '.site-header .main-navigation a:hover { color:' . get_theme_mod( 'risewp_nav_link_hover_color', '#C4C5C5' ) . ' }';
  

  • and so on with the rest of them. You have a ​good example here. Unless @djrmom says its ok, I am ok with it too.
• A correct callback function for the "Home..." sections would be

  function risewp_home_tmpl_callback() { 
          if( is_page_template( 'template-page-home.php' ) 
          { return true; } else { return false; } 
  }
  

[acosmin]

Sorry about this, one last thing an we're done. In \inc\risewp-styles.php:

• line 14, $risewp_customizer_styles isn't used anywhere else, it may cause issues if not set. You need to remove it.
• If you are going the wp_head root, you don't need wp_add_inline_style( 'risewp-customizer-styles', $risewp_customizer_styles ); anymore. Also, $risewp_customizer_styles is empty. Please remove this line.

Thank you!

[themetracbot]

riseWP - 1.1.3

Rise is a multipurpose WordPress theme which can be used as a template for any type of website. The theme uses the WordPress core post format feature to generate portfolio and testimonial posts, so creating content has never been easier or more reliable. The clean and minimal design is the perfect way to build a creative business layout or maintain a beautiful blog. Visit ​https://modernthemes.net/theme-demos/?theme=Rise to see the demo of Rise up close.

Theme URL - ​https://modernthemes.net/wordpress-themes/rise
Author URL - ​https://modernthemes.net

SVN - ​https://themes.svn.wordpress.org/risewp/1.1.3
ZIP - ​https://wordpress.org/themes/download/risewp.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=risewp/1.1.2&new_path=risewp/1.1.3

History:

Ticket	Summary	Status	Resolution	Owner
#36797	THEME: riseWP – 1.1.3	closed	live	acosmin
(this ticket)
#37098	THEME: riseWP – 1.1.4	closed	live	themetracbot
#37222	THEME: riseWP – 1.1.5	closed	live	themetracbot
#39334	THEME: riseWP – 1.1.6	closed	live	themetracbot
#42529	THEME: riseWP – 1.1.7	closed	live	themetracbot
#47410	THEME: riseWP – 1.1.8	closed	live	themetracbot
#72989	THEME: riseWP – 1.1.9	closed	live	themetracbot

[modernthemesnet]

Hi @acosmin

Should be good to go now!

Replying to acosmin:

Sorry about this, one last thing an we're done. In \inc\risewp-styles.php:

• line 14, $risewp_customizer_styles isn't used anywhere else, it may cause issues if not set. You need to remove it.
• If you are going the wp_head root, you don't need wp_add_inline_style( 'risewp-customizer-styles', $risewp_customizer_styles ); anymore. Also, $risewp_customizer_styles is empty. Please remove this line.

Thank you!

[acosmin]

It's all yours @djrmom

GL to you @modernthemesnet

[djrmom]

Thanks for the review @acosmin,

Congrats @modernthemesnet, your theme is now live.

Here are a few things to fix on update.

• these enqueue handles should be updated:

  `wp_enqueue_style( 'jPushMenu-css'` -> use lowercase and remove s `wp_enqueue_style( 'jpushmenu'`
  `wp_enqueue_script( 'jPushMenu'` -> use lowercase `wp_enqueue_script( 'jpushmenu'`
  `wp_enqueue_script( 'jPushMenu-script'` -> this should be theme prefixed
  

• there is no need to have risewp.mo or .po, and risewp.pot should be correct if included
• you might want to make the pro link in the customizer clickable

Thanks,
Jenny