Make WordPress Themes

Opened 15 years ago

Closed 15 years ago

#3580 closed theme (not-approved)

THEME: Wiredrive Classic - 1.0.1

Reported by: wiredrive's profile Wiredrive Owned by: curtismchale's profile curtismchale
Priority: Keywords: theme-wiredrive-classic
Cc: rss@…

Change History (3)

#1 @emiluzelac
15 years ago

  • Owner set to curtismchale
  • Status changed from new to assigned

#2 @curtismchale
15 years ago

I'm currently recommending that the theme is not approved. Please address the items below.

Notes

  1. Not all of the functions are prefixed. has_children is a good example. It should be something like wiredrive_has_children.
  1. Functions have generic prefix. I would suggest that you change the prefix on some functions away from 'classic_' to something more specific to the theme to avoid conflicts. In my opinion classic_ is way to generic and not acceptable.
  1. wp_head should be immediately before the closing </head> in your document. Please move it there.
  1. The test post with no title has no permalink to the single post view. Themes are required to provide a way to see the single post view even if not title is provided.
  1. You custom CSS file should not be included using get_template_part. All CSS files should be enqueued on wp_print_styles. Properly done would look something like:

`function wiredrive-classic_custom_css() {

include( get_template_directory() . '/css/custom-css.php' );

}

add_action( 'wp_print_styles', 'wiredrive_classic_custom_css', 11); `

Adjust priority as needed. A great article on proper usage of get_template_part and locate_template can be found here: http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes

  1. Javascript should be enqueued properly in a function not included directly in the head of the document even if you are using enqueue. http://codex.wordpress.org/Using_Javascript The current exception to this is the threaded comment JS. Current discussion does lead me to believe that in the future it will not be an exception and will also need to be enqueued in a function.
  1. Threaded comments do not display at all. Please ensure that threaded comments at least 5 levels deep function properly.
  1. The theme options page has a number of debug warnings on line 783 and 849 of the file theme-options.php. Please ensure that there is no debug output from the theme options page.
  1. I was unable to save a new background colour on the theme. It flashed for a second then returned to the original colour. Tested in Chrome and Firefox 4 OS X. Images worked fine.
  1. Please use post_class() on page.php and single.php

Extra Comments

  1. There really is no need to check for dynamic_sidebar anymore. The functions has been around a long time.
  1. There is a minor CSS error on line 33 of your file. You should have 3 '0' or 6 not 5.

#3 @emiluzelac
15 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.