THEME: LayoutPress Lite – 1.30

[troytempleman]

LayoutPress Lite - 1.30

<a href="​http://layoutpress.net">LayoutPress</a> is a drag and drop starter theme with an intuitive interface for visually creating page layouts with WordPress widgets, helping to rapidly prototype, design and develop WordPress themes.

Theme URL - ​http://layoutpress.net/
Author URL - ​http://troytempleman.com/

SVN - ​https://themes.svn.wordpress.org/layoutpress-lite/1.30
ZIP - ​https://wordpress.org/themes/download/layoutpress-lite.1.30.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=layoutpress-lite/1.22&new_path=layoutpress-lite/1.30

History:

Ticket	Summary	Status	Resolution	Owner
#21448	THEME: LayoutPress Lite - 1.0	closed	not-approved	karmatosed
#22605	THEME: LayoutPress Lite - 1.2	closed	not-approved	tallythemes
#23142	THEME: LayoutPress Lite - 1.22	closed	not-approved	vlad.olaru
#27196	THEME: LayoutPress Lite – 1.30	closed	not-approved	StephenCronin
(this ticket)

[StephenCronin]

Hi @troytempleman ,

I've started reviewing your theme. It will take some time, but I'll try to get back to you with some feedback within the next 5 days.

Thanks for your patience!

Cheers,
Stephen

[troytempleman]

OK, great. Thanks Stephen.

[StephenCronin]

Hi @troytempleman

Thank you for waiting. Here's the result of the review.

There are quite a few things that need to be addressed before the theme can be accepted, including some which will mean major work for you. You may want to consider converting it to a plugin as that would probably be less work (and then it could work with multiple themes).

Anyway, here is the list of issues. Please check each of these and fix them. When you've fixed them, please go to ​https://wordpress.org/themes/upload/ and reupload the theme. It must have the same name and you need to change the Version tag in style.css. The new version will then be attached to this ticket. Also, please include a list of your changes in the ticket.

Required

(things that need to be addressed before the theme can be approved)

• Unfortunately, having a separate theme options page is no longer allowed. All theme options must be set via the Customizer as per this announcement: ​https://make.wordpress.org/themes/2015/04/22/details-on-the-new-theme-settings-customizer-guideline/ This means you will need to move the main LayoutPress functionality into the Customizer, which will be a big job, but unfortunately that's the only way it can be accepted now.
• Themes are not allowed to include SQL or store things directly in the database - ​https://gyazo.com/b034d47c4bec691882d8f4c489937cb6. Instead, you should store information using the Options API (​https://codex.wordpress.org/Options_API).
• It has been decided that the LP Editor and LP Code widget allow the user to add content to the site that would be lost if the user changes themes and are therefore plugin territory. You therefore have to move these to a plugin or remove them from the theme.
• Note: Because the previous 3 points mean a major reworking for you, I got a second (and third and fourth opinion) on these issues. Unfortunately these things are not allowed in a theme. They should be acceptable in a plugin, which is why I suggested that you may want to consider converting it to a plugin.
• On the first page load after activation, undefined index messages are shown (​https://gyazo.com/2389ba01abf7ecbab73b069c8244ecab). Please set default values for the first run.
• The wp_widgets_access_body_class function was added to core in WordPress 4.4, resulting in a fatal error when trying to edit a template because you have a function with the same name - ​https://gyazo.com/eb7652f4eec07f9134604afe1e029a3b
• Please provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. For example: wp_widgets_access_body_class should be layoutpress_lite_widgets_access_body_class, which would have prevented the previous error.
• All options need to be save in a single array rather than as separate options - ​https://gyazo.com/ab070f2598faa411ea8989daa87f73c7
• All theme text strings are to be translatable, but it seems you've removed some - ​https://gyazo.com/25d058efd6b782612c7472ccb05a5173 - can you please re-add these and check that everything is translatable?
• The Premium version needs to be 100% GPL. I can't see anywhere on your website that indicates that it is. Also, to be compatible with the GPL, you can't restrict users to a certain number of sites as seen in this screenshot (​https://gyazo.com/33caf1cb96e7b3c891743314ed685335). You can say "1 Year of Support and Updates for 1 Site", but not "1 Site License", ie it's okay to limit support and updates but not usage.
• Unfortunately you cannot use Glyphicons as they are not compatible with the GPL (​http://glyphicons.com/license/). You can find a list of GPL compatible icon sets here:https://make.wordpress.org/themes/handbook/review/resources/#gpl-compatible-icon-sets
• Screenshots are supposed to be a maximum of 1200 by 900 pixels and the aspect ratio should be 4:3. Can you please make all screenshots this size? ​https://make.wordpress.org/themes/2015/10/06/screenshot-clarification-update/
• Need to clear floats in the following screenshot: ​https://gyazo.com/eb7c7358789b37521919ad23728fd200
• Sticky posts need to be distinctly recognizable in some way in comparison to normal posts - ​https://gyazo.com/9632eb545fae1a72da077bb7731ab7e7
• Long titles should not overflow the content area - ​https://gyazo.com/5c37aca42ccf693d2178f2c27cf9b444
• Notice shown (Notice: Use of undefined constant CURR_TEMPLATE - assumed 'CURR_TEMPLATE) when adding an LP Editor widget - ​https://gyazo.com/ea91a4bf47bac9a6603e67ed78825740 . Please resolve this.
• There are duplicate ids in the source. For example, there are several divs with an id of 'col-1'. Ids should be unique.
• Comments, Pingbacks and Trackbacks are not displayed on posts or pages, eg: ​https://gyazo.com/9d4b3d4955a01fe518fe44b40d432594 - there are 3 comments on this page, as shown in the count, but they are not displayed as required.
• Rather than using require_once (get_template_directory()."/css/lpcustom.css.php");, you should enqueue it as a CSS file and then use wp_localize_script to create the CSS required.
• The Header and Footer scripts options are not allowed as they are plugin territory - ​https://gyazo.com/3b9630272de35a4f69764d20610a05c3 - please remove this.
• It's best practice to escape everything as late as possible. I can see you are escaping some things before outputting them and presume you have worked out which things may be at risk. However, you really need to escape everything that's output.
• 404 pages are blank. They should have a heading and a 'page not found' message for the user - ​https://gyazo.com/f19635ca71a42a6c52cbe28b36f071da
• I believe that code in pink is going to execute, although I believe it is part of the comment (​https://gyazo.com/a233a58c30b4e74741b6ae70fc44516c).

Recommended

(things we recommend you address, but which are not required for approval)

• Using wp_title (​https://gyazo.com/51c82178e3c3d2007efa4554cc3a5b67) is no longer recommend, as this is planned to be deprecated. Please use add_theme_support( "title-tag" ) instead.
• The theme includes a version of jQuery which is never used (layoutpress-lite/js/jquery.js). There is no need to for this, as the instance of jQuery that is included with core should always be used. Please consider removing this.
• Menu has no styling (​https://gyazo.com/298879b4683771626871aec9944e6e5c). This was previously discussed on https://themes.trac.wordpress.org/ticket/22605. Although I understand you are trying to create a theme with minimum style, it should have some basic default styling for the menu, rather than just appearing as a list.
• Post navigation is displayed on pages, even though there is no actual navigation - ​https://gyazo.com/fdee9749cf6e39c4e5b0a6e2a0b90abf
• The term "Post Navigation" is visible, even though it has a class of assistive-text, so should presumably be hidden (see previous screenshot).
• Having the site title displayed again in the footer may be confusing to users (​https://gyazo.com/d2fb348faabef49eaf57d9c0e3faa09f). I understand it can be removed, but may be better for this not to be the default.
• Tables should have some formatting - at the moment they have almost none - ​https://gyazo.com/e6a0451c21a9bd8ece6b0eba79f0c0bb
• There should be some spacing at the bottom of definition list items - ​https://gyazo.com/d568bd85c93d0206ba44ee5a696ed443
• The Search results page doesn't have a heading or anything explaining what the page is (eg Search results for xxxx) - ​https://gyazo.com/aeca5df87c9c28e92d72b70e317e860e
• Category pages should have the category displayed as a heading on the page so the user know which page they are on - ​https://gyazo.com/463dcc76b871996ff0270c56e5ff1d8a
• The same applies to Archive pages.
• Also, I'd like to reiterate the comments made here: https://themes.trac.wordpress.org/ticket/23142#comment:5

Thanks,

Cheers,
Stephen

[troytempleman]

Hi Stephen,

I really appreciate your time and such a thorough review. I first submitted this over a year ago and have waited weeks and months at a time only to receive dribs and drabs of changes. It would have been nice to receive more substantial feedback like this earlier in development. I'm passionate about this project and believe there is a strong need for it in the community but I want it to be done right and within WordPress standards. With that said, it looks like I may have to reconsider some things going forward, which your review will help me do.

Thanks again!

Troy

[StephenCronin]

Hi Troy,

I received one further piece of advice from an admin (after I posted my response) about the fact that the LP Editor widget could execute PHP. Apparently this isn't allowed either - executing PHP needs to be in a plugin. Sorry I missed that.

Also sorry that the result of the review wasn't more positive for you. I hope you find a good way forward with your product!

If your next step takes longer than a week, then this ticket will probably be closed and you'll need to upload it again (the same you did this time). That will create a new ticket, which should have this ticket attached to it.

Anyway best of luck!

Cheers,
Stephen

[troytempleman]

OK. Thanks Stephen. The next version will likely take much longer than a week but with your familiarity with LayoutPress now, I would prefer you be the one to review it whenever it is ready. If you don't mind, is there a way I could request you to review it?

[StephenCronin]

Hey Troy,

Thanks. If this ticket is closed, then when you re-upload the theme, it will create a new ticket. That will automatically be assigned to a reviewer (so probably not me). There doesn't seem to be any way to make it come directly to me. Sorry. :(

Cheers,
Stephen

[StephenCronin]

Oh - unless you keep this ticket open, by leaving a comment every week - although that seems cumbersome! :)

[karmatosed]

I am closing this ticket as you've not responded to the review. In future please respond, even to say you need more time within 7 days.