THEME: Fluid Baseline Grid – 0.93

[dizzysoft]

Fluid Baseline Grid - 0.9

This theme is fundamentally about words. It&#8217;s designed using the <strong>best-practices of typography for easier reading</strong>. This is especially important in a world where mobile is an important part of any blog&#8217;s traffic. Speaking of which, this is designed from a mobile-first perspective. This means it is not only <strong>responsive</strong> but designed to provide maximum readability for mobile users across devices. It even handles images and embedded objects (i.e.: videos) in a mobile-friendly way. It is also built for maximum consistency across different browsers- using Respond.js (to allow older browsers to be responsive) and Normalize.css (so it should display consistently across Google Chrome, Mozilla Firefox 4+, Apple Safari 5+, Opera 12+, and Internet Explorer 8+). All these benefits come thanks to Josh Hopkins&#8217;s Fluid Baseline Grid (​http://fluidbaselinegrid.com/), from which this theme receives its name. In addition, the theme includes a couple <strong>SEO enhancements</strong> to cut-down on duplicated content and more clearly declare the intent of a particular page (including Schema.org markup for Blog posts as Articles). <strong>WordPress features it supports:</strong> menus (including a responsive menu for small screens), widgets, custom background image and colors, and featured images per post. You can also optionally add widgets to a sidebar of a post or page for a two-column look (without widgets, they will be displayed as one-column).

Theme URL - ​http://www.dizzysoft.com/fluid-baseline-grid-wordpress-theme/
Author URL - ​http://www.dizzysoft.com/

SVN - ​https://themes.svn.wordpress.org/fluid-baseline-grid/0.9
ZIP - ​https://wordpress.org/themes/download/fluid-baseline-grid.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=fluid-baseline-grid/0.8&new_path=fluid-baseline-grid/0.9

History:

Ticket	Summary	Status	Resolution	Owner
#19216	THEME: Fluid Baseline Grid - 0.7	closed	not-approved	perryb
#22366	THEME: Fluid Baseline Grid - 0.8	closed	not-approved	nitkr
#26512	THEME: Fluid Baseline Grid – 0.93	closed	live	kafleg
(this ticket)
#29922	THEME: Fluid Baseline Grid – 0.94	closed	live	Otto42
#30453	THEME: Fluid Baseline Grid – 0.95	closed	live	jcastaneda
#33934	THEME: Fluid Baseline Grid – 0.96	closed	live	themetracbot
#41210	THEME: Fluid Baseline Grid – 0.97	closed	live	themetracbot

[kafleg]

Hello dizzysoft,
I am reviewing your theme. Fix the below issue and resubmit your theme again.

[REQUIRED]

Theme Check

• .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.

changelog.txt

• Change log file is missing. Maintain change log properly. You can include change log on readme.txt file. ​https://github.com/Otto42/theme-check/blob/master/readme.txt

code

• Redundant code found on header.php, header-archive.php and header-home.php so please remove redundant code and make correct.
• While enqueue style and scripts, use hyphen instead of underscore on handler and prefix handler by theme text domain.
• Wherever home_url is used, it should be in esc_url( home_url('/')) format. Check on other files too.
• Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. Some Functions name missing prefix. For your reference check on functions.php line 6, 16 etc. Please Check on all files too. ​http://themereview.co/prefix-all-the-things/
• Remove unwanted and commented code. Reference functions.php line 143. Please check on other files too.
• Default background image is not allowed. Please remove it.

Files

• Is fbg theme.cpfs file is required here? If not please remove it.

Language

• All strings are not translatable. Please fix it. For your reference find in loop.php line number 28. Check on other files too. Use this plugin to check. ​https://wordpress.org/plugins/piglatin/

Reference Link: ​https://codex.wordpress.org/I18n_for_WordPress_Developers

RECOMMENDED

• Code indentation is necessary for making readable format. Reference : check on comments.php.
• While enqueue style and scripts, use hyphen instead of underscore on handler.
• Use dependencies on js while enqueue scripts. ​https://codex.wordpress.org/Function_Reference/wp_enqueue_script

Theme Check

• No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• Found a translation function that is missing a text-domain. Function _e, with the arguments ' in '
• Possible hard-coded links were found in the file header-home.php. Line 21: <p><?php _e('This theme uses the <a href='​http://fluidbaselinegrid.com/'>Fluid Baseline Grid</a> and was adapted for
• Could not find the comment-reply script enqueued, however a reference to 'comment-reply' was found. Make sure that the comment-reply script is being enqueued properly on singular pages.
• Possible hard-coded links were found in the file footer.php. Line 18: <li><a href='​http://validator.w3.org/check/referer' title='<?php esc_attr_e('This page v Line 19: <li><a href='​http://gmpg.org/xfn/'>
• At least one hard coded date was found in the file header-archive.php. Consider get_option( 'date_format' ) instead.

NOTE

• REQUIRED points should be resolved to make theme approved on wordpress.org. RECOMMENDED points includes best practices on theme development but theme will not be rejected on the base of RECOMMENDED points.
• Please fix issues and re-upload your theme. Update your theme version and changelog. ​https://wordpress.org/themes/upload/
• Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Best regards,
KafleG :)

[dizzysoft]

Thanks for your help! Each time I submit the theme, I think I've gotten but I'm glad reviewers like you are catching these things.

A couple questions before I resubmit this:

1. Redundant code in "header" files- yes, there's some redundant code in each but only one of these will load at a time, based upon what's necessary. I'm not sure I understand what you are telling me to do, instead.

2. Hyphens not underscores in enqueued script handlers. I'm not seeing an underscore in any of these. Where am I missing it? Could you give me a line number, please?

3. Since when are custom backgrounds not allowed? It's still in the codex: ​https://codex.wordpress.org/Custom_Backgrounds I can't seem to find anywhere that forbids this. Frankly, I'd like to keep it so people can easily turn it off, if they'd like to.

4. I can't find the reference to home_url without esc_url that you mention. Could you give me a file/line number, please?

Thanks again for all your help!

[kafleg]

Hello dizzysoft,
I feel sorry for some mistake required issue listed above. I consulted with theme reviewer expert and found the conclusion about the issue mentioned by you.

1. I just want to mentioned about the redundant code oh header. If each code load at a time, its fine and no need to change it.
2. It just recommended issue, if not there no need to find it.
3. Custom background default image is allowed. So sorry for this issue.
4. It fine on your theme.

Once again sorry. I really feel glad for your kind response and hope you will soon the issues and submit again. And i will review details of your theme again.

Kind Regards,
KafleG :)

[themetracbot]

Fluid Baseline Grid - 0.91

This theme is fundamentally about words. It&#8217;s designed using the <strong>best-practices of typography for easier reading</strong>. This is especially important in a world where mobile is an important part of any blog&#8217;s traffic. Speaking of which, this is designed from a mobile-first perspective. This means it is not only <strong>responsive</strong> but designed to provide maximum readability for mobile users across devices. It even handles images and embedded objects (i.e.: videos) in a mobile-friendly way. It is also built for maximum consistency across different browsers- using Respond.js (to allow older browsers to be responsive) and Normalize.css (so it should display consistently across Google Chrome, Mozilla Firefox 4+, Apple Safari 5+, Opera 12+, and Internet Explorer 8+). All these benefits come thanks to Josh Hopkins&#8217;s Fluid Baseline Grid (​http://fluidbaselinegrid.com/), from which this theme receives its name. In addition, the theme includes a couple <strong>SEO enhancements</strong> to cut-down on duplicated content and more clearly declare the intent of a particular page (including Schema.org markup for Blog posts as Articles). <strong>WordPress features it supports:</strong> menus (including a responsive menu for small screens), widgets, custom background image and colors, and featured images per post. You can also optionally add widgets to a sidebar of a post or page for a two-column look (without widgets, they will be displayed as one-column).

Theme URL - ​http://www.dizzysoft.com/fluid-baseline-grid-wordpress-theme/
Author URL - ​http://www.dizzysoft.com/

SVN - ​https://themes.svn.wordpress.org/fluid-baseline-grid/0.91
ZIP - ​https://wordpress.org/themes/download/fluid-baseline-grid.0.91.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=fluid-baseline-grid/0.9&new_path=fluid-baseline-grid/0.91

History:

Ticket	Summary	Status	Resolution	Owner
#19216	THEME: Fluid Baseline Grid - 0.7	closed	not-approved	perryb
#22366	THEME: Fluid Baseline Grid - 0.8	closed	not-approved	nitkr
#26512	THEME: Fluid Baseline Grid – 0.93	closed	live	kafleg
(this ticket)
#29922	THEME: Fluid Baseline Grid – 0.94	closed	live	Otto42
#30453	THEME: Fluid Baseline Grid – 0.95	closed	live	jcastaneda
#33934	THEME: Fluid Baseline Grid – 0.96	closed	live	themetracbot
#41210	THEME: Fluid Baseline Grid – 0.97	closed	live	themetracbot

[dizzysoft]

No apologies, please. We're all learning here. I appreciate your time.

I've made the changes you required (but please double-check my work). Some of the recommended changes were not taken (it's just not the direction in which I want the theme to go).

[kafleg]

Hello,
I reviewed your theme and found some issue which are mentioned below. Please follow the theme review guidelines and correct on your theme. ​https://make.wordpress.org/themes/handbook/review/required/
Please solve this issue and follow the guideline which may helpful for you. If you have any confusion, feel free to ask.

js/css

• REQUIRED: No minification of scripts or files unless provide original files. Please add original file also. No original file of fbg-html5shiv.min.js, fbg-respond-min.js, and fgb-selectnav.min.js. ​https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Others

• Please maintain code indentation, it is necessary for making readable format. For reference: single.php, comments.php.

Files

• Is fbg theme.cpfs file is required here? If not please remove it. If required mentioned the use of file on theme.

code

• Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. Some Functions name missing prefix. For your reference check on functions.php line 6, 16 etc. Please Check on all files too. ​http://themereview.co/prefix-all-the-things/ Example: function fluid_baseline_grid_excerpt_more { //code goes here }

Screenshot

• Why you put big-screenshot.png on theme directory ? Please remove it. It is not allowed.

Thanks for your kind appreciation. Really we all are learning and laboring for making better.
Your suggestion and help are always welcome.

Best Regards,
KafleG :)

[dizzysoft]

Thanks again. I think I got it all this time- including that pesky, hidden fbg theme.cpfs file!

Going to resubmit it now.

[themetracbot]

Fluid Baseline Grid - 0.92

This theme is fundamentally about words. It&#8217;s designed using the <strong>best-practices of typography for easier reading</strong>. This is especially important in a world where mobile is an important part of any blog&#8217;s traffic. Speaking of which, this is designed from a mobile-first perspective. This means it is not only <strong>responsive</strong> but designed to provide maximum readability for mobile users across devices. It even handles images and embedded objects (i.e.: videos) in a mobile-friendly way. It is also built for maximum consistency across different browsers- using Respond.js (to allow older browsers to be responsive) and Normalize.css (so it should display consistently across Google Chrome, Mozilla Firefox 4+, Apple Safari 5+, Opera 12+, and Internet Explorer 8+). All these benefits come thanks to Josh Hopkins&#8217;s Fluid Baseline Grid (​http://fluidbaselinegrid.com/), from which this theme receives its name. In addition, the theme includes a couple <strong>SEO enhancements</strong> to cut-down on duplicated content and more clearly declare the intent of a particular page (including Schema.org markup for Blog posts as Articles). <strong>WordPress features it supports:</strong> menus (including a responsive menu for small screens), widgets, custom background image and colors, and featured images per post. You can also optionally add widgets to a sidebar of a post or page for a two-column look (without widgets, they will be displayed as one-column).

Theme URL - ​http://www.dizzysoft.com/fluid-baseline-grid-wordpress-theme/
Author URL - ​http://www.dizzysoft.com/

SVN - ​https://themes.svn.wordpress.org/fluid-baseline-grid/0.92
ZIP - ​https://wordpress.org/themes/download/fluid-baseline-grid.0.92.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=fluid-baseline-grid/0.91&new_path=fluid-baseline-grid/0.92

History:

Ticket	Summary	Status	Resolution	Owner
#19216	THEME: Fluid Baseline Grid - 0.7	closed	not-approved	perryb
#22366	THEME: Fluid Baseline Grid - 0.8	closed	not-approved	nitkr
#26512	THEME: Fluid Baseline Grid – 0.93	closed	live	kafleg
(this ticket)
#29922	THEME: Fluid Baseline Grid – 0.94	closed	live	Otto42
#30453	THEME: Fluid Baseline Grid – 0.95	closed	live	jcastaneda
#33934	THEME: Fluid Baseline Grid – 0.96	closed	live	themetracbot
#41210	THEME: Fluid Baseline Grid – 0.97	closed	live	themetracbot

[kafleg]

Hello,

• I already mentioned that no minified file without original file of js are allowed on theme. But still the fbg-respond.min.js, fbg-selectnav.min.js and fbg-html5shiv.min.jshave no original file of JS. Please add unminified files of JS also on theme.

• What about the big-screenshot.PNG on theme? I already mentioned about this issue but still not solved. If that screenshot have any purpose on theme, please clarify it.

• Only credit link allowed on theme, but more then 3 found on theme on footer.php. Please correct it.

• Please remove commented out code from theme. Found on functions.php line 13, 93. Please check on other files too.

• Would you please make me clear about the fbg theme.cpfs file ?

Please submit your theme again with solving all issues.

Regards,
KafleG :)

[dizzysoft]

All these changes have been made:

https://themes.trac.wordpress.org/changeset?old_path=fluid-baseline-grid/0.91&new_path=fluid-baseline-grid/0.92

The only exception is the 3 links. Only one of the external links is a "credit link" (fluidbaselinegrid.com). The other two are validation checks that are typically on other wordpress themes. If it will make you feel better, I'll remove those.

I might be uploading the file wrong. For some reason it doesn't seem to be overriding the old 0.9 version. I tried to upload this as 0.9 but it told me that number was already taken so I upped the number to 0.91 and then 0.92. Should I have not done that.

[kafleg]

Only one credit link is allowed on footer and must match with the Theme URI or Author URI. So please remove footer credit link and put only one. And keep in mind that it must match with the Theme URI or Author URI. :)

Thanks.

[dizzysoft]

Before I submit, with this change, can you confirm that I have been uploading the theme to WP correctly and that you are seeing the changes I'm making. In other words, are you now seeing the other things that you thought I haven't been fixing?

[kafleg]

Yes, you are uploading correctly. I already notify about the uploading link. ​https://wordpress.org/themes/upload/

If you are in doubt about it you can also find the changes on 'Diff with previous version:' link.

Thank you

[themetracbot]

Fluid Baseline Grid - 0.93

This theme is fundamentally about words. It&#8217;s designed using the <strong>best-practices of typography for easier reading</strong>. This is especially important in a world where mobile is an important part of any blog&#8217;s traffic. Speaking of which, this is designed from a mobile-first perspective. This means it is not only <strong>responsive</strong> but designed to provide maximum readability for mobile users across devices. It even handles images and embedded objects (i.e.: videos) in a mobile-friendly way. It is also built for maximum consistency across different browsers- using Respond.js (to allow older browsers to be responsive) and Normalize.css (so it should display consistently across Google Chrome, Mozilla Firefox 4+, Apple Safari 5+, Opera 12+, and Internet Explorer 8+). All these benefits come thanks to Josh Hopkins&#8217;s Fluid Baseline Grid (​http://fluidbaselinegrid.com/), from which this theme receives its name. In addition, the theme includes a couple <strong>SEO enhancements</strong> to cut-down on duplicated content and more clearly declare the intent of a particular page (including Schema.org markup for Blog posts as Articles). <strong>WordPress features it supports:</strong> menus (including a responsive menu for small screens), widgets, custom background image and colors, and featured images per post. You can also optionally add widgets to a sidebar of a post or page for a two-column look (without widgets, they will be displayed as one-column).

Theme URL - ​http://www.dizzysoft.com/fluid-baseline-grid-wordpress-theme/
Author URL - ​http://www.dizzysoft.com/

SVN - ​https://themes.svn.wordpress.org/fluid-baseline-grid/0.93
ZIP - ​https://wordpress.org/themes/download/fluid-baseline-grid.0.93.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=fluid-baseline-grid/0.92&new_path=fluid-baseline-grid/0.93

History:

Ticket	Summary	Status	Resolution	Owner
#19216	THEME: Fluid Baseline Grid - 0.7	closed	not-approved	perryb
#22366	THEME: Fluid Baseline Grid - 0.8	closed	not-approved	nitkr
#26512	THEME: Fluid Baseline Grid – 0.93	closed	live	kafleg
(this ticket)
#29922	THEME: Fluid Baseline Grid – 0.94	closed	live	Otto42
#30453	THEME: Fluid Baseline Grid – 0.95	closed	live	jcastaneda
#33934	THEME: Fluid Baseline Grid – 0.96	closed	live	themetracbot
#41210	THEME: Fluid Baseline Grid – 0.97	closed	live	themetracbot

[kafleg]

I approved your theme. Admin will again review your theme and only theme will go live. Until then you have a wait. Hope your theme will live soon.
Best of luck for coming days on WordPress.

Best Regards,
KafleG :)

[dizzysoft]

Thank you for all your help, @kafleg

[karmatosed]

Congratulations, this theme is now live!