THEME: German Newspaper - 1.3.10

[christian_gnoth]

German Newspaper - 1.3.10

A variable width (800px, 1024 px), three columns theme for Wordpress in a magazin style - ready for a newspaper or news magazin webpage - with a news headline and a Hot Topics column.

Theme URL - ​http://it-gnoth.de/projekte/wordpress/themes/
Author URL - ​http://it-gnoth.de/

SVN - ​http://themes.svn.wordpress.org/german-newspaper/1.3.10
ZIP - ​http://wordpress.org/extend/themes/download/german-newspaper.1.3.10.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/german-newspaper/1.3.9&new_path=/german-newspaper/1.3.10

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-german-newspaper&order=priority

[christian_gnoth]

like with the other releases of this theme:

ATTENTION !!!!!

the wordpress stylesheet definitions are NOT in the style.css BUT IN the style4.php file !!!

please review this theme soon and make it available for the public.

[Fingli]

=> Could not find comment_form <?php comment_form(); ?>
[The theme must include this hook in comments.php, instead of writing own form. For more details and customization read the description in ​http://codex.wordpress.org/Template_Tags/comment_form ]

Example:

<?php 
$args = array(
        'comment_field' => '<p class="comment-form-comment"><textarea id="comment" name="comment" cols="45" rows="8" aria-required="true"></textarea></p>',
        'comment_notes_after' => ''
);
comment_form($args); ?>

=> Elements after floated image are not positioned well

=> Uncommon link rel attribute in header

   <link rel="openid.server" href="http://www.myopenid.com/server" />
   <link rel="openid.delegate" href="http://christian_gnoth.myopenid.com/" />

Notices from debugger

=> ob_end_flush() [ref.outcontrol]: failed to delete and flush buffer. No buffer to delete or flush. in \themes\german-newspaper\footer.php on line 65

=> Undefined index: gn_tab_1 in \themes\german-newspaper\bottom_bars.php on line 32

=> Undefined index: gn_tab_2 in \themes\german-newspaper\bottom_bars.php on line 36

---

This is a tertiary review. Next reviewer might find more so please do everything you can to adhere to the documentation on what is accepted in the theme review.

• Developer needs to thoroughly read the ​Theme Review and find all the must-haves and update their theme(s) accordingly, this theme will continue to not pass until all requirements are met.
• It's useful if the authors check their themes with ​Theme-Check plugin and with set WP_DEBUG to 'true' in wp-config.php

Items marked with => are reasons for not being approved
Items marked with / are just suggestions
Items marked with - are notes

Once the points above have been addressed appropriately using the available information found at the links above; please thoroughly review your theme and re-submit it using the uploader tool: ​http://wordpress.org/extend/themes/upload/ this will generate a new Trac ticket.

---

Responding To This Review

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net (or through ​http://webchat.freenode.net/)

[christian_gnoth]

new version uploaded under:

​http://themes.trac.wordpress.org/ticket/2815

[christian_gnoth]

can you please review the new release soon??? and please make it available for the public. please do not cancel this theme because of small issues you may find.