WordPress.org
Get WordPress

Make WordPress Themes

Opened 11 years ago

Closed 11 years ago

#24884 closed theme (live)

THEME: Mastro – 1.3

Reported by: jayantisolanki's profile jayantisolanki Owned by: alex27's profile alex27
Priority: new theme Keywords: theme-mastro
Cc: jayantiisolanki@…

Description

Mastro - 1.0

Mastro is a simple and clean HTML5 and CSS3 WordPress theme. The theme features custom header, custom background, featured image, icon font (Font Awesome) post formats, custom menu and custom template (Front page, full width and html sitemap).

Theme URL - ​http://www.jayantisolanki.com/projects/mastro/
Author URL - ​http://www.jayantisolanki.com/

SVN - ​https://themes.svn.wordpress.org/mastro/1.0
ZIP - ​https://wordpress.org/themes/download/mastro.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#24884 THEME: Mastro – 1.3 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/mastro/1.0/screenshot.png

Attachments (1)

mastro_overflow.png​ (606.2 KB) - added by alex27 11 years ago.

Download all attachments as: .zip

Change History (15)

#2 @alex27
11 years ago

  • Owner set to alex27
  • Status changed from new to reviewing

#3 @jayantisolanki
11 years ago

How long will it take to review my theme?

#4 @alex27
11 years ago

Sorry for the poor communication! I'll go over it this weekend.

#5 @alex27
11 years ago

Hi there!

Thank you for your patience! Below are the theme review results.
Anything marked REQUIRED needs a resolution. Anything marked RECOMMENDED is suggested a fix but not a grounds for failing.

REQUIRED

CODE

  • All strings are to be translatable. This means wrapping all strings in a ​gettext function and loading text domain via load_theme_textdomain() See Twenty Fifteen for code example. Multiple instances found in:
    • 404.php
    • header.php
    • footer.php
    • comments.php
    • content-none.php (here also wrong text domain is found - ‘twentyfourteen’)
    • the name of sidebar in register_sidebar function should be wrapped in translation function as well
    • ...and many more. Please check all the files.
  • editor-style.css and readme.txt files are empty. Please remove, if it’s not being used.
  • The Protocol(​http://) is not needed when enqueuing google fonts (and hard coding http might cause problems). ​See here for alternative implementation.
  • I found unprefixed script handles in j_style() function. All functions, class names, script handles, public and global variables are properly prefixed with your theme slug.
  • there are 30+ empty lines at the end of functions.php, before closing ?> tag. Please remove the closing ?> tag at the end of file, as well as all empty lines.
  • page-templates/sitemap.php, line 34 - missing text domain
  • Please remove <script src="http://maps.googleapis.com/maps/api/js?sensor=false" type="text/javascript"></script> from footer.php. Is this actually used? If yes, the script must be bundled with the theme, and properly enqueued. If it’s not being used, please remove.
  • If using minified scrips, you need to bundle the non-minified version with the theme as well.
  • register_nav_menu() calls should be included in the setup function

LAYOUT

  • Large images are overflowing main content area. It’s probably an issue with $content_width.

OTHER

  • Please provide coyright and license info for all images and scripts bundled with the theme. This is usually done in readme.txt
  • screenshot.png should represent the theme as it appears after it’s initially activated with default options, mockups are not allowed.
  • Theme URL cannot be a mere demo with dummy content. This should be a page with more information on the theme, and you can include demo link on that page. Please note, that you're not required to include Theme URL.
  • You could take advantage of some core functions added recently to WordPress, for example:
    • add add_theme_support( 'title-tag' ); to setup function, instead of custom j_title() function to display <title> element. This requires removing the <title> from header.php.
    • use the_archive_title() and the_archive_description() functions in archive.php to display the title and description. This way you could get rid of category.php and tag.php files. You’ll find ​example implementation in _s theme.

CONCLUSION

Please fix above issues and ​upload new version of your theme, I'll leave this ticket open for another 7 days. Feel free to ask if you have any questions.

#8 @jayantisolanki
11 years ago

Thanks for the review, @alex27.

I've fixed the all required issues except "Large images are overflowing main content area. It’s probably an issue with $content_width." please explain in detail

Thanks again! Looking forward to your review of this new version.

#9 @alex27
11 years ago

NOT FIXED

  • All strings are to be translatable. This means wrapping all strings in a ​gettext function and loading text domain via load_theme_textdomain() See Twenty Fifteen for code example.
  • register_nav_menu() calls should be included in the setup function (mastro_theme_setup()).
  • add_theme_support( 'title-tag' ); should not be wrapped in separate function, but included in mastro_theme_setup().
  • You need to prefix script handles in mastro_scripts() and mastro_style() .All functions, class names, script handles, public and global variables are properly prefixed with your theme slug.
  • Theme URL cannot be a mere demo with dummy content. This should be a page with more information on the theme, and you can include demo link on that page. Please note, that you're not required to include Theme URL.
  • If using minified scrips, you need to bundle the non-minified version with the theme as well.
  • Still some empty lines at the end of functions.php
  • Please provide coyright and license info for all images and scripts bundled with the theme. This is usually done in readme.txt

OTHER

  • Your readme.txt file says "Twenty fifteen"

I've fixed the all required issues except "Large images are overflowing main content area. It’s probably an issue with $content_width." please explain in detail

I looked into it, and it's not actually a problem with $content_width. You're just missing a max-width:100% for images with caption (see attachment).

@alex27
11 years ago

#10 @themetracbot
11 years ago

  • Summary changed from THEME: Mastro – 1.2 to THEME: Mastro – 1.3

Mastro - 1.3

Mastro is a simple and clean HTML5 and CSS3 WordPress theme. The theme features custom header, custom background, featured image, icon font (Font Awesome) post formats, custom menu and custom template (Front page, full width and html sitemap).

Theme URL -
Author URL - ​http://www.jayantisolanki.com/

SVN - ​https://themes.svn.wordpress.org/mastro/1.3
ZIP - ​https://wordpress.org/themes/download/mastro.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mastro/1.2&new_path=mastro/1.3

History:

Ticket Summary Status Resolution Owner
#24884 THEME: Mastro – 1.3 closed live alex27

(this ticket)


https://themes.svn.wordpress.org/mastro/1.3/screenshot.png

#11 @jayantisolanki
11 years ago

Thanks for the review, @alex27. I've fixed the all above listed issues.

Please let me know if you have any suggestion.

#12 @alex27
11 years ago

  • Status changed from reviewing to approved

Thank you. Everything looks clear, marking theme as APPROVED.

#13 @jayantisolanki
11 years ago

Thanks @alex27

#14 @alex27
11 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations! Your theme is now live.

Note: See TracTickets for help on using tickets.