WordPress.org
Get WordPress

Make WordPress Themes

Opened 15 years ago

Closed 15 years ago

#2351 closed theme (not-approved)

THEME: Black horse - 2.5.0.3

Reported by: skinik's profile skinik Owned by: greenshady's profile greenshady
Priority: Keywords: theme-black-horse,
Cc: info@…

Description

Black horse - 2.5.0.3

Simple, easy and powerfull WordPress theme. Based on Cehla framework. HTML5 and CSS3. Theme supports 6 widget areas(2 in sidebar and 4 in footer). It includes styles for the Visual Editor, special styles for posts in the “Asides” and “Gallery” categories, and has an optional one-column page template that removes the sidebar.

Theme URL - ​http://www.skinik.name/portfolio/black-horse-wp-theme
Author URL - ​http://skinik.name

SVN - ​http://themes.svn.wordpress.org/black-horse/2.5.0.3
ZIP - ​http://wordpress.org/extend/themes/download/black-horse.2.5.0.3.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/black-horse/2.5.0.2&new_path=/black-horse/2.5.0.3

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-black-horse&order=priority

Change History (2)

#1 @greenshady
15 years ago

  • Owner set to greenshady
  • Status changed from new to accepted

#2 @greenshady
15 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

Nav Menus

The "Primary" nav menu doesn't load the user-selected menu. There's an error with the code:

<?php wp_nav_menu( array( 'container_class' => 'menu-header', 'menu theme_location' => 'primary' ) ); ?>

'menu theme_location' should be changed to 'theme_location'.

Custom Body Classes

When adding custom <body> classes as you do in cehla_body_classes(), you need to escape any unknown variables (anything not hardcoded) with either esc_attr() or sanitize_html_class(). Otherwise, you could end up with a lot of broken stuff on the page.

Header Image

The theme doesn't take into account the case of a user *not* using a header image and ouputs an empty image element:

<img class="branding" src="" width="960" height="350" alt="" />

It needs to make sure a header image exists before outputting that code in header.php.

CSS Issues

  • Galleries with more than three columns are broken.
  • Left-/right-aligned images need some right/left margin so that the text doesn't butt up against the side of the image.
  • <address> element could use some bottom margin.

Using the wrong directory path

Users can't create child themes of your theme because you're using get_stylesheet_directory_uri() to load additional styles and scripts. get_stylesheet_directory_uri() is the path to the active theme (child theme). You should instead use get_template_directory_uri() when loading scripts, styles, and images because these are things that are in the template (parent theme) directory.

Scripts and styles

Additional stylesheets should be appropriately loaded using wp_enqueue_style():
​http://codex.wordpress.org/Function_Reference/wp_enqueue_style

Internationalization

You use two different textdomains in the theme: cehla and cehla-tw (see sidebar.php for the issue). The theme should only use a single textdomain.

Review

If you have any questions about the review, please check the Theme Review guidelines or ask in the form below. I'll be happy to help out.
​http://codex.wordpress.org/Theme_Review

Note that this is not a complete review. Other theme reviewers may find other issues. Please follow all the notes in the Theme Review guidelines.

Note: See TracTickets for help on using tickets.