THEME: BaseCraft – 1.0.5

[iflairwebtechnologies]

BaseCraft - 1.0.5

We’ve create pure custom theme. This theme have good structure and neat & clean code format.

Theme URL -
Author URL - ​https://www.iflair.com/

Trac Browser - https://themes.trac.wordpress.org/browser/basecraft/1.0.5
WordPress.org - ​https://wordpress.org/themes/basecraft/

SVN - ​https://themes.svn.wordpress.org/basecraft/1.0.5
ZIP - ​https://downloads.wordpress.org/theme/basecraft.1.0.5.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [277639] https://themes.trac.wordpress.org/changeset?old_path=basecraft/1.0.4&new_path=basecraft/1.0.5

History:

Ticket	Summary	Status	Resolution	Owner
#205713	THEME: BaseCraft – 1.0.0	closed	not-approved	ammarsaif
#208943	THEME: BaseCraft – 1.0.1	closed	not-approved	acosmin
#213066	THEME: BaseCraft – 1.0.2	closed	not-approved	bijayyadav
#214476	THEME: BaseCraft – 1.0.3	closed	not-approved	acosmin
#218251	THEME: BaseCraft – 1.0.4	closed	not-approved	acosmin
#222675	THEME: BaseCraft – 1.0.5	closed	not-approved	kafleg
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
• RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
• RECOMMENDED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
• RECOMMENDED: Could not find the comment-reply script enqueued.
• RECOMMENDED: Could not find comments_template. See: ​comments_template

   <?php comments_template( $file, $separate_comments ); ?>
  

• RECOMMENDED: Could not find wp_list_comments. See: ​wp_list_comments

   <?php wp_list_comments( $args ); ?>
  

• RECOMMENDED: Could not find comment_form. See: ​comment_form

   <?php comment_form(); ?>
  

• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: Theme URI: is missing from your style.css header.
• RECOMMENDED .sticky css class is recommended in your theme css.
• RECOMMENDED .bypostauthor css class is recommended in your theme css.
• RECOMMENDED .alignleft css class is recommended in your theme css.
• RECOMMENDED .alignright css class is recommended in your theme css.
• RECOMMENDED .aligncenter css class is recommended in your theme css.
• RECOMMENDED .wp-caption css class is recommended in your theme css.
• RECOMMENDED .wp-caption-text css class is recommended in your theme css.
• RECOMMENDED .gallery-caption css class is recommended in your theme css.
• RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• RECOMMENDED: No reference to add_theme_support( "custom-logo", $args ) was found in the theme. It is recommended that the theme implement this functionality.
• RECOMMENDED This theme contains no sidebars/widget areas. See ​Widgets API

[kafleg]

Hi!
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
​https://make.wordpress.org/themes/handbook/review/required/
​https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/
​https://wordpress.tv/2017/09/27/ganga-kafle-think-before-you-post-themes-on-wordpress-org-wordpress-org

Use this plugin to check your theme,
​https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

Underline Links

• When links appear within a larger body of block-level content, they must be clearly distinguishable from surrounding content (Post content, comment content, text widgets, custom options with large blocks of texts). ​https://make.wordpress.org/themes/handbook/review/required/#3-accessibility

Please check the content of your posts (the_content()), excerpts (the_excerpt()), comments content, text widgets, custom options with large blocks of texts.

Links within content and comments must be underlined
When links appear within a larger body of block-level content, they must be clearly distinguishable from surrounding content (Post content, comment content, text widgets, custom options with large blocks of texts).

Links in navigation-like contexts (e.g., menus, lists of upcoming posts in widgets, grouped post meta data) do not need to be specifically distinguished from surrounding content.

The underline is the only accepted method of indicating links within the content. Bold, italicized, or color-differentiated text is ambiguous and will not pass.

Skip Link

• Check skip links requirement here. ​https://make.wordpress.org/themes/handbook/review/required/#skip-links
• Recommended reading, ​https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip-links/

Keyboard Navigation

• Theme authors must provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons, and text links.
• Some resources to help you: Information on the ​requirement
• Video help for ​Modals, ​Links, ​Forms, ​Menus
• Check TwentyTwenty using tab and shift+tab as an example

Dummy Post

• You are not allowed to have dummy text in the theme, ​https://themes.svn.wordpress.org/basecraft/1.0.5/basecraft_theme_activation_time.php

Extras

• Menus is not looking fine. Check by adding sub-menus too.

You can always ask in the ​#themes channel on ​WordPress slack if you have any confusion regarding the issues mentioned above. Or you can also ​watch this video and know more about the ​guidelines.

Thank you
KafleG