Make WordPress Themes

Opened 7 months ago

Closed 7 months ago

#220648 closed theme (not-approved)

THEME: Elcar – 1.0.0

Reported by: tanveen's profile tanveen Owned by: fahimmurshed's profile fahimmurshed
Priority: new theme Keywords: theme-elcar
Cc: tanveensorkar07@…

Change History (2)

#1 @fahimmurshed
7 months ago

  • Owner set to fahimmurshed
  • Status changed from new to reviewing

#2 @fahimmurshed
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello there,

I have had a quick look at the theme and at this point, it does not follow the requirements.
The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.
When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

Use this plugin to check your theme,
https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update:
https://wordpress.org/themes/upload/

Underline Links
When links appear within a larger body of block-level content, they must be clearly distinguishable from surrounding content (Post content, comment content, text widgets, custom options with large blocks of texts). https://make.wordpress.org/themes/handbook/review/required/#3-accessibility

Skip Link
Check skip links requirement here. https://make.wordpress.org/themes/handbook/review/required/#skip-links
Recommended reading, https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip-links/

Keyboard Navigation

  • Theme authors must provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons, and text links.
  • Some resources to help you: Information on the requirement
  • Video help for Modals, Links, Forms, Menus
  • Check TwentyTwenty using tab and shift+tab as an example

Please check in both mobile and desktop and mobile view.

License
All the third party resources( JS Library, CSS Library, Images, Google fonts, Icons, etc ) license should be mentioned in theme readme file. And all those resources should be GPL compatible.
If you want to host theme in WordPress.Org and you are selling premium items from your site or marketplace, it must be GPL compatible. Otherwise, you are not allowed to host theme here.

Prefixing
Here’s a list of the most common things that should be prefixed:

  • PHP function names.
  • PHP class names.
  • PHP global variables.
  • Action/Filter hooks.
  • Script handles.
  • Style handles.
  • Image size names.

Read more here: https://themereview.co/prefix-all-the-things/

You can always ask in the #themereview channel on WordPress slack if you have any confusion regarding the issues mentioned above.

Note: See TracTickets for help on using tickets.