#21574 (THEME: adubi - 5.14.1108) – WordPress Themes

#1 @bizover
11 years ago

hi again, another week more for any updates??? thanks

#2 @emiluzelac
11 years ago

Owner set to lunathecat
Status changed from new to reviewing

@bizover, we are volunteers :)

#3 @bizover
11 years ago

thanks for that, but i am volunteer as well?
in previous link, as if inactive but not caused by me then you closed it so it delayed 2 weeks, now 1 week and 5 days without any review. is there any active guys here, i guess no, for my case
as i checked other themes same day, even newer ones within 1 month newer than mine, many are done.

#4 @lunathecat
11 years ago

@bizover, there was some issues with my local environment and I wasn't able to work on it until yesterday. I'll keep you posted once it's done. My apologize for the delayed response.

#5 @karmatosed
11 years ago

Cc gpriday added

This is just a note for the reviewer, you have been assigned a mentor to take you through your first reviews. Congratulations, you get gpriday as your mentor!

#6 @karmatosed
11 years ago

Owner changed from lunathecat to gpriday

Gpriday are you ok to give this review? It could do with getting a solid review as waited a bit now.

#7 @karmatosed
11 years ago

Owner changed from gpriday to danielwrobert

#8 @danielwrobert
11 years ago

Hi @bizover!

I'll be picking up on this theme review. I'm sorry I didn't get to this before my vacation over the holidays but I'm back at it now. I expect to complete a first pass within the next week.

Cheers!

#9 @danielwrobert
11 years ago

Howdy!

Thank you for submitting your theme for review. Below are my notes after my first pass at reviewing Adubi. Keep in mind that this was just a quick review, we can do more once these required items are fixed. Please feel free to ping me with any questions as you work through them!

Required

Copyright should be declared somewhere, either in style.css and/or README.txt. Ideally both. Be sure to include it for the theme overall
Any resources included such as fonts or images should have all license information declared.
Must spell “WordPress” correctly in all public facing text: all one word, with both an uppercase W and P. Incorrect casing in the following locations:
- library/classes/option/ReduxCore/framework.php - 689: * ->get_wordpress_date() - Get Wordpress specific data from the DB and return in a usable array
- library/classes/option/ReduxCore/inc/fields/typography/field_typography.php - 246: // Fallback if file_get_contents won't work for wordpress. MEDIATEMPLE
- library/classes/option/ReduxCore/inc/fields/typography/field_typography.php - 841: // Fallback if file_get_contents won't work for wordpress. MEDIATEMPLE
- library/functions.php - 156: 
- library/library/bones.php - 213: // remove the p from around imgs (http://css-tricks.com/snippets/wordpress/remove-paragraph-tags-from-around-images/)
- footer.php - 21: <?php adubi_footer_menu(); // Adjust using Menus in Wordpress Admin ?>
- header.php - 41: <?php adubi_main_menu(); // Adjust using Menus in Wordpress Admin ?>
- library/classes/option/ReduxCore/extensions/customizer/extension_customizer.php - 236: // Wordpress doesn't support multi-select
- library/classes/option/ReduxCore/framework.php - 689: * ->get_wordpress_date() - Get Wordpress specific data from the DB and return in a usable array
- library/classes/option/ReduxCore/framework.php - 725: Use data from Wordpress to populate options array
- library/classes/option/ReduxCore/framework.php - 1121: * Class Add Sub Menu Function, creates options submenu in Wordpress admin area.
- library/classes/option/ReduxCore/framework.php - 2909: echo '<div class="wrap"><h2></h2></div>'; // Stupid hack for Wordpress alerts and warnings
- library/classes/option/ReduxCore/inc/class.redux_functions.php - 84: * initWpFilesystem - Initialized the Wordpress filesystem, if it already isn't.
- library/classes/option/ReduxCore/inc/class.redux_functions.php - 93: // Initialize the Wordpress filesystem, no more using file_put_contents function
- library/classes/option/ReduxCore/inc/class.redux_functions.php - 114: Both Wordpress and Redux require the enabling of the Apache mod_rewrite module to function properly. Please contact whomever provides support for your server and ask them to enable the mod_rewrite module',
- library/classes/option/ReduxCore/inc/class.redux_functions.php - 237: // feed it back to Wordpress. Why> admin.php cannot
- library/classes/option/ReduxCore/inc/fields/editor/field_editor.php - 74: 'textarea_rows' => 10, //Wordpress default
- library/classes/option/ReduxCore/inc/fields/select_image/field_select_image.php - 6: * @package Wordpress
- library/classes/option/ReduxCore/inc/fields/typography/field_typography.php - 812: // Initialize the Wordpress filesystem, no more using file_put_contents function
- library/classes/theme/wp-bootstrap-navwalker/README.md:151: + Class was completly re-written using the latest Wordpress 3.6 walker class.
- library/library/bones.php - 18: // Cleaning up the Wordpress Head
- library/library/bones.php - 85: // adding sidebars to Wordpress (these are created in functions.php)
Use esc_attr() for text inputs and esc_html() for textareas. See library/functions.php - line 299
Possible duplicate files sidebar.php & sidebar-sidebar2.php. Please remove duplicate/unneeded files from theme.

No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above. For an example, see: https://make.wordpress.org/core/2014/10/29/title-tags-in-4-1/

Additional Notes/Info

At least one hard coded date was found in the following files. Consider get_option( 'date_format' ) instead.
- page-full-width-date-time.php
- archive.php
sidebar.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead:
- Line 18: include_once(BIZTHEME_PATH.'pro/gg.php');
sidebar-sidebar2.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead:
- Line 18: include_once(BIZTHEME_PATH.'pro/gg.php');
library/option.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead:
- Line 88: require_once( ABSPATH .'/wp-admin/includes/file.php' );
- Line 249: require_once(ABSPATH . '/wp-admin/includes/file.php');
- Line 333: if (file_exists(BIZTHEME_PATH.'debug.php') && file_exists(BIZTHEME_PATH.'pro/library/option_p.php')) include_once(BIZTHEME_PATH.'pro/library/option_p.php');
- Line 353: include_once(BIZTHEME_PATH.'pro/gg.php');
library/library/bones.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 16: if ( is_readable($locale_file) ) require_once($locale_file);

library/classes/option/ReduxCore/inc/fields/typography/field_typography.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 86: // include_once(ReduxFramework::$_dir . 'inc/fields/typography/class.google-fo
- Line 814: require_once (ABSPATH . '/wp-admin/includes/file.php');
library/classes/option/ReduxCore/inc/fields/select/field_select.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 56: require_once( $icons_file );
library/classes/option/ReduxCore/inc/fields/raw/field_raw.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 51: include( $this->field['include'] );
library/classes/option/ReduxCore/inc/fields/group/field_group.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 178: require_once( $class_file );
library/classes/option/ReduxCore/inc/class.redux_functions.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 95: require_once (ABSPATH . '/wp-admin/includes/file.php');
library/classes/option/ReduxCore/framework.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 40: include_once(dirname(__FILE__).'/inc/class.redux_instances.php');
- Line 41: include_once(dirname(__FILE__).'/inc/lib.redux_instances.php');
- Line 53: include_once(dirname(__FILE__).'/inc/class.redux_helpers.php');
- Line 56: include_once(dirname(__FILE__).'/inc/class.redux_functions.php');
- Line 370: include_once(self::$_dir . 'inc/debug.php');
- Line 395: require_once(self::$_dir . 'inc/import_export.php');
- Line 501: include_once( dirname( __FILE__ ) . '/inc/tracking.php' );
- Line 1332: require_once( $class_file );
- Line 1619: require_once( $class_file );
- Line 2032: include(ABSPATH . 'wp-includes/pluggable.php');
- Line 2400: require_once( $class_file );
- Line 2705: require_once( $class_file );
- Line 3419: require_once($class_file);
library/classes/option/ReduxCore/extensions/customizer/extension_customizer.php appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
- Line 511: require_once( $class_file );
iframe was found in the file library/hybrid-media-grabber.php iframes are sometimes used to load unwanted adverts and code on your site.
- Line 340: * Grabs media embbeded into the content within <iframe>, <object>, <embed>, and other HTML methods for
- Line 425: $_html = strip_tags( $html, '<object><embed><iframe><video>' );

What should happen next is, you would resolve the required items. From there, we can review your theme again. This ticket will remain open, you can just upload your revised files and the theme will append to this ticket.
I look forward to seeing the updated version!

#10 @bizover
11 years ago

firstly, thanks for reply, after 3 months!!! and 1/2 year from first sent.

i know that some bad guys moved to commercial service for review, i thought of discontinuing this, but strangely this happedn?

secondly, i think y do not have exp much with license and WP. two first points are not correct so pls recheck them.

#11 @bizover
11 years ago

duplicate files sidebar.php & sidebar-sidebar2.php -> i think these are for left and right bars

of recommend and warning, i dont think i will fix them. and pls use standard when i upload this file, meaning 3 months ago, is it ok?

thanks.

#12 @danielwrobert
11 years ago

Hi @bizover,

I understand your frustration and I apologize that it has taken so long for your theme to finally get a pair of eyes on it.

I had received this theme in my queue of themes to review just before the holidays. I can assure you that I will be seeing this through and working with you to get Adubi launched on WordPress.org.

Regarding your comments:

secondly, i think y do not have exp much with license and WP. two first points are not correct so pls recheck them.

With regards to the declaration of the license for included fonts and images, I see that you have that stated in the readme.txt. I apologize, I must have overlooked that during my initial pass.
Regarding the copyright, however, you must declare a copyright in your theme’s style.css (and ideally in your readme.txt file as well). For an example of this, see _s: https://github.com/Automattic/_s/blob/master/style.css#L16

duplicate files sidebar.php & sidebar-sidebar2.php -> i think these are for left and right bars

Sounds good, I see that.

of recommend and warning, i dont think i will fix them.

That’s up to you. I will continue to include the relevant recommendations as I make additional passes through this theme. However, they are simply that - recommendations. Ultimately, unlike the required items, your theme will not be prevented from launching if you decide not to take the recommendations into consideration. I will be simply stating them as potential areas of improvement, as we both have a common goal here in making Adubi the best theme that it can be and launching it on WordPress.org. :)

and pls use standard when i upload this file, meaning 3 months ago, is it ok?

I’m not sure I understand the question here. If you are asking about how to go about uploading your corrections, please re-upload your theme through wordpress.org. Reviewers will not review themes any other way. :)

Thanks for your replies and, again, apologies for the delay with the overall process on this theme. I’m looking forward to working with you and getting Adubi out there!

#13 @bizover
11 years ago

thanks for reply. standards and themecheck i used for this update is from 3-4 months ago, are u using same one?

i got no required error then. license.txt are fine, i listed there. "WordPress" texts are for public templates, not for coding?

if so all required ones are gone...

#14 @danielwrobert
11 years ago

Hi @bizover,

Sorry for my delay, I was out for the past couple weeks.

I am using the latest standards and themecheck plugin in addition to following the guidelines listed in the handbook: https://make.wordpress.org/themes/handbook/review/#the%c2%a0review

"WordPress" texts are for public templates, not for coding?

That is correct, I know I listed all of the instances throughout the theme above but the important ones are any that are public-facing. As long as none of the above are public-facing, you should be good to go there.

I'll make another pass at the latest code to ensure there are no additional unmet requirements.

Thank you!

#15 @danielwrobert
11 years ago

Hi @bizover,

Below are some additional notes from my latest pass and some items left from the initial pass. Please note that I have continued to include Recommendations and Additional Notes/Info sections. It is up to you if you choose not to take them into consideration. I am just adding everything for the sake of making this theme the best possible.

Required

Licensing: Copyright still needs to be declared somewhere, either in style.css and/or README.txt. Ideally both. Be sure to include it for the theme overall - https://make.wordpress.org/themes/handbook/review/required/#licensing
Security and Privacy: Use esc_attr() for text inputs and esc_html() for textareas. See library/functions.php - line 299
Code: What is the /lib directory for? I am asking because I notice a few empty index.php files included. If these are not needed, please consolidate the code into a different directory and remove the empty files.
Code: Removing or modifying presentational hooks is not allowed. Please remove function beginning on line 43 of functions.php - https://themes.trac.wordpress.org/browser/adubi/5.14.1108/functions.php?rev=43925#L43.

Code: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above. For an example, see: https://make.wordpress.org/core/2014/10/29/title-tags-in-4-1/
Code: Is the map-style.css absolutely necessary? It may be a better approach to move those few lines of code into the style.css file and, if needed, target with a body class. This would reduce an additional, and potentially unnecessary, HTTP request to the server.

Additional Notes/Info

Code: At least one hard coded date was found in the following files. Consider get_option( 'date_format' ) instead.
- page-full-width-date-time.php
- archive.php

Please let me know if you have any questions!

#16 @bizover
11 years ago

Hi @danielwrobert,

Thanks for your review again, but i dont think required ones are right. Please remember that i tested with theme check so none of required types should show up.

Of your review, license is gpl3, i stated this right in style.css; you dont check?

lib/ is for extended themes, i use one git for all themes so each theme will have its own lib/ folder, this is intended so pls ignore this.

The other two required errors are not correct as well. As i based this theme on bones so library/functions.php is from that base, i dont use the function that has esc_...so there is no errors here. Again, the line 43 of functions.php is for re-adding "required hooks removed by bones", you see this?

Thanks again for adding more logic when checking theme.

#17 @danielwrobert
11 years ago

Hi @bizover,

Thanks for your reply and clarification. Please note that, while testing your theme against the Theme Check plugin is definitely a great practice and reduces the amount of issues that come up at the review state, the plugin itself will not catch everything. This is part of why there is a Theme Review Team. I certainly recommend continuing to use the plugin but, in addition, review the Theme Review Handbook - https://make.wordpress.org/themes/handbook/review/ and make sure at least those Required items are all met.

That said, I think you are misunderstanding the requirement about the license. I see that you have the GPL license listed in your style.css file, which is great. What I am referring to here is the copyright (the second item in the Licensing section here - https://make.wordpress.org/themes/handbook/review/required/#licensing). I am not seeing a copyright listed anywhere in this theme, unless I am missing it. For an example of what I am referring to, see line 16 in the styles.css of _s - https://github.com/Automattic/_s/blob/master/style.css#L16 - where it states "(C) 2012-2015 Automattic, Inc.". That's what I'm looking for. I know it's a small thing but it's a requirement.

With regards to your other feedback:

lib/ is for extended themes, i use one git for all themes so each theme will have its own lib/ folder, this is intended so pls ignore this.

Ok, thank you. Noted.

The other two required errors are not correct as well. As i based this theme on bones so library/functions.php is from that base, i dont use the function that has esc_...so there is no errors here. Again, the line 43 of functions.php is for re-adding "required hooks removed by bones", you see this?

Ok, I see what you're doing here. Thank you for pointing that out. I just saw that you were removing a bunch of action hooks but I missed that they were just hooks from the Bones framework. That part looks good to me then!

It looks like the only required item from above then is the copyright. Once you update that, I'll make one final pass to make sure nothing was missed.

Thanks again for all of your work on this!

#18 @bizover
11 years ago

Hi @danielwrobert,

I don't think that "(C) 2015..." is a requirement. The must here is license type and I stated it as GPL3, along with url to that content. It will allow anyone to use this theme like that, no -Copyright- here.

I think so, please re-check this with other themes as well...

#19 @danielwrobert
11 years ago

Hi @bizover,

Unfortunately the copyright is a requirement as well. It states in the Theme Review Handbook here - https://make.wordpress.org/themes/handbook/review/required/#licensing - "Declare copyright and license explicitly." It does not say one or the other. I know this handbook was revised not long ago so I believe this may be a newer requirement (I don't recall if it was listed in the previous version of the handbook or not). But it is required, none-the-less.

Please add your copyright to the head of the style.css file as it is done in _s on line 16 - https://github.com/Automattic/_s/blob/master/style.css#L16.

Other than that, everything else (as far as the required items go) looks good.

Thanks!

#20 @bizover
11 years ago

Thanks for info. But I checked some recent themes here, they are also missing (C)... As I noted before, themes here do not have copyright for good reason.

I also stated that this theme is free and anyone can use it for fun... ok?

Beside that, if anyone want to credit me, they can state "(C) 20xx bizover", all these info are already there, no need to re-write again :D

#21 @danielwrobert
11 years ago

Hi @bizover,

The copyright could have been missed on those recent themes. This is a requirement, however, as it is listed in the Handbook (which I have linked above).

Also, the license and the copyright are two different things. The license refers to what you'd mentioned above, "I also stated that this theme is free and anyone can use it for fun... ok?". The copyright, on the other hand, protects your design itself. It is requirement for theme designs to be original, as stated in the final point under the Licensing section, "All code and design should be your own or legally yours. Cloning of designs is not acceptable." - https://make.wordpress.org/themes/handbook/review/required/#licensing ... so it does make sense to require a copyright for each theme design.

Please add your copyright to the head of the style.css file as it is done in _s on line 16 - https://github.com/Automattic/_s/blob/master/style.css#L16 - and I can submit this theme for approval.

Thanks for all of your work on this! :)

#22 @greenshady
11 years ago

The license looks to be declared just fine in this theme. Your copyright is questionable though. It should include your real name or your company's name as well.

The "copyright" statements in the readme.txt are all wrong as well. It's missing copyright information about the scripts/libraries you used and sometimes the correct license. For example, the Hybrid Core files and other items of mine (Justin Tadlock) you used are not licensed under "GPL". They're licensed under the GPL v2 or later", so someone getting this theme cannot use those things under an earlier version of the GPL. They also don't include a statement that they're copyrighted to "Justin Tadlock" with the copyright date.

#23 @bizover
11 years ago

I complied this theme from so many resources, and for long time ago, so maybe GPL was a fast way that I thought suitable for describing almost script GPL-ing at that time. Sorry about that.

I think this is not correct:
"They also don't include a statement that they're copyrighted to "Justin Tadlock" with the copyright date.

Every author that i have referred to would make her own type of declaration, some with name some with website some without date..., but within my work I could refer to them in my own single way that may be enough to not cause any un-copyrighted misunderstanding. I dont think one has to remember and check all type of declaration then paste all in a txt file, nonsense. Moreover, scripts that I included here are full version with copyright statement as their authors already wanted inside.

Thanks,

and sorry for my foreign English.

#24 @greenshady
11 years ago

Your theme won't be approved without the correct copyright and license declarations as defined by the theme review team. I'm one of the admins on the theme review team and am telling you that the license and copyright declarations in your readme.txt do not conform to our standard.

See: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Also, regarding your request to release the theme under "no copyright", you may do so if you license the theme under CC0 or put it in the public domain. The GPL and other open source licenses are meant to protect your copyright while providing certain freedoms to the user.

#25 @bizover
11 years ago

is this ok:

Adubi WordPress Theme, Copyright 2014 Thu Hoai
Adubi is distributed under the terms of the GNU GPL v3

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see http://www.gnu.org/licenses/gpl-3.0.html.

Adubi WordPress Theme bundles the following third-party resources:

. Bootstrap Framework

MIT License http://www.opensource.org/licenses/mit-license.php
http://getbootstrap.com

. FontAwesome

MIT and SIL OFL 1.1 License
http://fontawesome.io

. Get the Image

GPL License v3 http://www.gnu.org/licenses
https://github.com/justintadlock/get-the-image

. WP Page Navi

GPL License
https://wordpress.org/plugins/wp-pagenavi

. Nice search

GPL License
https://wordpress.org/plugins/nice-search

. Hybrid Core

GPL License v3
https://github.com/justintadlock/hybrid-core

. CSS3 media-queries.js

MIT License
https://code.google.com/p/css3-mediaqueries-js

. respond.js

MIT License
https://github.com/scottjehl/Respond

. Bootwatch Sass styles

Apache License 2.0 http://www.apache.org/licenses
https://github.com/log0ymxm/bootswatch-scss

. Option Framework

GPL License
https://github.com/syamilmj/Options-Framework

. Redux Framework

GPL License
http://reduxframework.com

. html5.js Shim

MIT License
https://code.google.com/p/html5shim

. Bootwatch styles

MIT License
https://github.com/thomaspark/bootswatch

. CMBCustom-Metaboxes-and-Fields-for-WordPress

GPL License
https://github.com/WebDevStudios/Custom-Metaboxes-and-Fields-for-WordPress

. TGM Updater

GPL License
https://github.com/thomasgriffin/TGM-Updater

. TGM Activation

GPL License
https://github.com/thomasgriffin/TGM-Plugin-Activation

. hybrid-media-meta

GPL License v3
https://github.com/justintadlock/hybrid-core/

. hybrid-media-grabber

GPL License v3
https://github.com/justintadlock/hybrid-core/

. Google Fonts used by Bootstrap

Apache License 2.0
https://www.google.com/fonts

. Bootstrap Navigation Walker

GPL License
http://twittem.github.io/wp-bootstrap-navwalker

. wp-bootstrap

GNU General Public License v2.0 & Apache License 2.0
http://www.320press.com/wp-bootstrap

. Bones

GPL License
https://github.com/eddiemachado/bones

. Demo Content and Image from WPCandy

GPL License
http://wpcandy.com

. Demo Images for Screenshots if any

Public Domain CC0
http://flickr.com

...
other assets have been created by me for the purpose of this theme with a GPL License v3.

Thanks very much

#26 @danielwrobert
11 years ago

Hi @bizover,

Your copyright looks good. With regards to your included assets, I am still seeing some licensing and copyright information that is not correct - for example, the wp-pagenavi license should also be listed as GPLv2 or later as shown in the README here - https://github.com/lesterchan/wp-pagenavi.

Additionally, as @greenshady was saying above, you're missing the copyright on some of the assets as well. For example, his Hybrid Core plugin should read as follows:

GPLv2 or later
2008 – 2014 © Justin Tadlock.
https://github.com/justintadlock/hybrid-core

Similarly, any other assets you are using that have copyright information should be included, along with the proper version of the license. For the sake of being thorough, please go through all of your assets and make sure you have this information correctly listed in the readme. Once this is complete and the new version is re-uploaded here, you theme should be good to go!

#27 @bizover
11 years ago

Thank @danielwrobert,

Your request to add copyright statement is ok, I see it is a must in guideline

But how about other ones, such as asset copyright? I see it is a should not a must as I checked, so I can freely refer to theme as I want, not in a fixed form of name-date..... Moreover, original copyrights are kept at the header of packed files so a step of copying again is nonsense

#28 @greenshady
11 years ago

The method described for adding copyright + license in the readme or license file is for the benefit of users of your code and the WordPress.org theme review team. This matter should've been taken care of a week ago. It's only a handful of lines of additional text to declare the proper copyright.

Chip took the time out of his day to write up an in-depth guide (https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/) on how we expect to see copyright + license declarations. He done this so that there would be no confusion on the part of the theme author and theme reviewer.

These are things that our team must thoroughly check. Any time a theme author doesn't follow the standard, it makes our jobs a lot harder. Then, when we have a week-long discussion like what we have here over something so trivial as a few lines of text that you could've already added, it only serves to slow down the entire theme review process even more, not just for you, but for everyone.

TRT has decided that this is the best way to organize things. You have two options:

Follow what we've laid out and move forward with the review.
Do not follow and I, as an admin, will close this ticket.

#29 @bizover
11 years ago

I follow the rules that are common here, only "must do" to reduce wasting time, whoever reviewer is. That's why I asekd which are musts and which are shoulds, most in guide above are shoulds.

Delay till now was partly by me, because I am not pro in this business and am finding free time to update within allowed time, but mostly by previous closing without notice and delay/changes of reviewers as well.

Sorry for previous reply, I will send next update for review this week

Last edited 11 years ago by bizover (previous) (diff)

#30 @bizover
11 years ago

I just saw another new requirement for removing redux from theme, is it required for this submission? Thanks

#31 @greenshady
11 years ago

No, you do not have to remove it at this time. However, any updates from Oct. 21 and later will require the use of the customizer for theme options.

#32 @danielwrobert
11 years ago

Once you re-submit the updates for the copyright and licensing info, your theme should be good to go and I'll submit it for approval! :)

#33 @danielwrobert
11 years ago

Howdy,

Any updates on this?

Just checking in, as it's been over four weeks and I don't want to close this ticket without giving you the opportunity to submit your latest round of fixes. Especially since it's so close to approval.

#34 @danielwrobert
11 years ago

@bizover - Please upload the latest version via the upload page http://wordpress.org/themes/upload or the ticket will be closed due to inactivity.

#35 @bizover
11 years ago

Hi, sorry for delay, i will upload tomorrow

#36 @danielwrobert
11 years ago

Resolution set to not-approved
Status changed from reviewing to closed

Closing ticket due to inactivity. Theme author can re-submit theme when ready.

Reported by:	bizover	Owned by:	danielwrobert
Priority:	previously reviewed	Keywords:	theme-adubi
Cc:	bizover@…, gpriday

Ticket	Summary	Status	Resolution	Owner
#20264	THEME: adubi - 5.14.1016	closed	not-approved	ryelle
#21574	THEME: adubi - 5.14.1108	closed	not-approved	danielwrobert
(this ticket)

Make WordPress Themes

Context Navigation

#21574 closed theme (not-approved)

THEME: adubi - 5.14.1108

Description

Change History (36)

#1 @bizover 11 years ago

#2 @emiluzelac 11 years ago

#3 @bizover 11 years ago

#4 @lunathecat 11 years ago

#5 @karmatosed 11 years ago

#6 @karmatosed 11 years ago

#7 @karmatosed 11 years ago

#8 @danielwrobert 11 years ago

#9 @danielwrobert 11 years ago

Required

Recommended

Additional Notes/Info

#10 @bizover 11 years ago

#11 @bizover 11 years ago

#12 @danielwrobert 11 years ago

#13 @bizover 11 years ago

#14 @danielwrobert 11 years ago

#15 @danielwrobert 11 years ago

Required

Recommended

Additional Notes/Info

#16 @bizover 11 years ago

#17 @danielwrobert 11 years ago

#18 @bizover 11 years ago

#19 @danielwrobert 11 years ago

#20 @bizover 11 years ago

#21 @danielwrobert 11 years ago

#22 @greenshady 11 years ago

#23 @bizover 11 years ago

#24 @greenshady 11 years ago

#25 @bizover 11 years ago

#26 @danielwrobert 11 years ago

#27 @bizover 11 years ago

#28 @greenshady 11 years ago

#29 @bizover 11 years ago

#30 @bizover 11 years ago

#31 @greenshady 11 years ago

#32 @danielwrobert 11 years ago

#33 @danielwrobert 11 years ago

#34 @danielwrobert 11 years ago

#35 @bizover 11 years ago

#36 @danielwrobert 11 years ago

Download in other formats:

#1 @bizover
11 years ago

#2 @emiluzelac
11 years ago

#3 @bizover
11 years ago

#4 @lunathecat
11 years ago

#5 @karmatosed
11 years ago

#6 @karmatosed
11 years ago

#7 @karmatosed
11 years ago

#8 @danielwrobert
11 years ago

#9 @danielwrobert
11 years ago

#10 @bizover
11 years ago

#11 @bizover
11 years ago

#12 @danielwrobert
11 years ago

#13 @bizover
11 years ago

#14 @danielwrobert
11 years ago

#15 @danielwrobert
11 years ago

#16 @bizover
11 years ago

#17 @danielwrobert
11 years ago

#18 @bizover
11 years ago

#19 @danielwrobert
11 years ago

#20 @bizover
11 years ago

#21 @danielwrobert
11 years ago

#22 @greenshady
11 years ago

#23 @bizover
11 years ago

#24 @greenshady
11 years ago

#25 @bizover
11 years ago

#26 @danielwrobert
11 years ago

#27 @bizover
11 years ago

#28 @greenshady
11 years ago

#29 @bizover
11 years ago

#30 @bizover
11 years ago

#31 @greenshady
11 years ago

#32 @danielwrobert
11 years ago

#33 @danielwrobert
11 years ago

#34 @danielwrobert
11 years ago

#35 @bizover
11 years ago

#36 @danielwrobert
11 years ago