THEME: Farben Basic - 1.0.3

[tinkerpriest]

Farben Basic - 1.0.0

Create a truly unique design with Farben Basic, a lightweight and fully responsive HTML5 theme. Use the Customizer to add your own header image, page layout, site width and more. Distinguish each post with one of the eight supported post formats, such as: Video, Image, Aside, Status, Audio, Quote, Link and Gallery. Install JetPack to display each of your galleries through a tiled view and jQuery carousel. Compatible with bbPress, BuddyPress & Woocommerce. Built using SASS, Compass and Bootstrap 3. Uses Google Fonts for improved typeface readability. Designed for desktop browsers, tablets and handheld devices.

Theme URL - ​https://themes.bavotasan.com/themes/farben/
Author URL - ​http://bavotasan.com/

SVN - ​https://themes.svn.wordpress.org/farben-basic/1.0.0
ZIP - ​https://wordpress.org/themes/download/farben-basic.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#21384	THEME: Farben Basic - 1.0.3	closed	live	poena
(this ticket)
#24874	THEME: Farben Basic – 1.0.4	closed	live	poena
#31330	THEME: Farben Basic – 1.0.5	closed	live	themetracbot
#53957	THEME: Farben Basic – 1.0.6	closed	live	themetracbot

[jcastaneda]

Hey, kenyasullivan, wanted to see how you were coming along with the review? If you had any questions?

[kenyasullivan]

No questions I should be complete with review tomorrow.

[kenyasullivan]

@tinkerpriest I've completed you review below, I've included the Detailed Review, Review Summary and A Final Recommendation. Our Admin @jcastaneda will valid the my review and give final approval or additional requirements. If you have any questions or concerns please let us know.

Thanks in advance
kenyasullivan

DETAILED REVIEW - REQUIRED
==THEME CHECKS==
Theme Template Files
Theme is required to include, at a minimum:
index.php (PASSED)
comments.php (via comments_template()) (PASSED)
screenshot.png
-Maximum size: 880x660px (PASSED)
-Should be a “reasonable facsimile” of the Theme after it is initially activated with default options (PASSED)
style.css (PASSED)

Theme Features
Theme is required to incorporate the following WordPress core Theme Feature:
Comments:
comments_template() (Passed-comments.php)
wp_list_comments() (Passed - comments.php)
comment_class() – (if using callback for wp_list_comments()) - Does not exist
comment_form()(Passed - comments.php)
wp_enqueue_script( ‘comment-reply’ )(Passed -functions.php)

Theme must not incorporate the following features:
Admin/feature pointers

Function Parameters, Filters, Action Hooks
Themes are required to use function parameters, filters, and action hooks where appropriate in order to modify content, rather than hard-coding:
wp_title(): Themes are required to modify output via filter (wp_title/body_class/post_class) (PASSED -header.php)
<title> includes wp_title() only, and any modifications, if included, are added via wp_title filter. Filtered content uses get_bloginfo() as appropriate if displaying site title, description, etc. (PASSED header.php)
body_class()/post_class() (PASSED -header.php)

Templates
If incorporated into the Theme, custom template files are required to be called using get_template_part() orlocate_template()
If incorporated into the Theme, standard template files are required to be called using the correct template tag.
header.php (via get_header()) (PASSED)
footer.php (via get_footer()) (PASSED)
sidebar.php (via get_sidebar()) (PASSED)
comments.php (via comments_template()) (PASSED)
searchform.php (via get_search_form()) (PASSED content-none.php)

Template Tags
The following template tags and hooks are required to be included where appropriate:
wp_title() (PASSED)
wp_head() – (immediately before </head>) (PASSED)
body_class() – (inside <body> tag) (PASSED)
$content_width (PASSED)
post_class() (PASSED)
wp_link_pages() (PASSED)
paginate_comments_links(), or previous_comments_link()/next_comments_link() (PASSED)
posts_nav_link(), or previous_posts_link()/next_posts_link(), or paginate_links() (PASSED)
wp_footer() – (immediately before </body>) (PASSED footer.php)

Site Information
If incorporated into the Theme, site information is required to be called using the correct template tag:
Template/Stylesheet Path:
Themes are required to use get_template_directory() rather than TEMPLATEPATH to return the template path. (PASSED)
Themes are required to use get_stylesheet_directory() rather than STYLESHEETPATH to return the stylesheet path. (PASSED -Not Used)
Themes are required to use *_url() template tags, rather than bloginfo() equivalents. (PASSED)

WordPress Generated CSS Classes
Themes are required to support the following WordPress-defined CSS classes, or similar elements:
Alignment Classes:
.aligncenter (PASSED - style.css)
.alignleft (PASSED - style.css)
.alignright (PASSED - style.css)
Caption Related Classes:
.wp-caption (PASSED - style.css)
.wp-caption-text (PASSED - style.css)
.gallery-caption (PASSED - style.css)
Post Classes:
.sticky (PASSED - style.css)
Comment Classes:
.bypostauthor (PASSED - style.css)

Theme Settings and Data Security
To add the Theme Settings Page to the Appearance menu add_theme_page()function must be used, rather than using add_menu_page() to add a top-level menu. (PASSED - N/A)
Themes are required to use the edit_theme_options capability for add_theme_page(), rather than rely on a role (e.g. “administrator”), or a different capability (e.g. “edit_themes”, “manage_options”) for the capability to add the settings page. (PASSED)
Themes are required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you, as does using the Settings API. (PASSED)
Themes are required to use sane defaults and must not write default setting values to the database. (PASSED)
For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputtingchecked=”checked” and selected=”selected”, respectively. (PASSED - N/A)
Themes are required to prefix all options, custom functions, custom variables, and custom constants with theme-slug (or appropriate variant). (PASSED)
Themes are required to implement Theme Options and Theme Settings pages deliberately, rather than relying on copy-and-paste scripts from website tutorials. PASSED
Themes are required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files (see: Data Validation) (PASSED)
Themes are required to use esc_attr() for text inputs and esc_html() (or esc_textarea() in WP 3.1) for textareas. (PASSED e.g. search form.php)
Themes are required to provide explicit Settings-page nonce checking, if not using the Settings API (see: WordPress Nonces) Passed -N/A)

Theme Name
Theme Name Guidelines are required for new Themes, and recommended for existing Themes. (PASSED)
WordPress is not allowed to be used in a theme name. For example My WordPress Theme, WordPress AwesomeSauce, and AwesomeSauce for WordPress would not be accepted. After all, this is the WordPress Theme repository. (PASSED)
Themes may use the WP acronym in the Theme name, such as WP AwesomeSauce. (PASSED)
Themes are not to use the term Theme in their name, such as: AwesomeSauce Theme. Same reason as above … it’s a Theme repository. (PASSED)
Themes are not to use version-specific, markup-related terms (e.g. HTML5, CSS3, etc.) in their name. (PASSED)
Themes are not to use related terms (e.g. Blog, Template, Skin, Design,Development, etc.) in their name. (PASSED)
Themes are not to use Theme author/developer credit text in their name. For example AwesomeSauce by John Q. Developer (makes for a much better credit link); or, SEO/SPAM-seeded text, such as: AwesomeSauce by Awesome Free WP Themes (this is just not going to pass). (PASSED)
Themes are not to use related Theme names (e.g. WP Theme Name, Theme Name WP, The Theme Name, etc.) in their name. (PASSED)
Child Theme names must be unique and cannot include the name of the parent (e.g. Theme Name Child) (PASSED N/A)

==Licensing==
Theme License:
Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. The complete theme must be GPL-Compatible. (PASSED)
Themes may optionally include a full-text license, referenced as license.txt, or else link to a reasonably permanent URL that contains the full-text license.
Themes are required to declare their license explicitly, using the License and License URI header slugs to style.css: (PASSED)

Copyright
Themes are required to declare copyright and license information as specified by the applicable license, e.g.: (PASSED)
Derivative Themes are required to retain/declare the copyright information of the original work (PASSED -N/A)
Bundled Resources
Themes are required to state the copyright and license information for any bundled resources (e.g. PHP, CSS, JS, fonts and images) not covered by the Theme’s license statement. (PASSED- Readme.txt)
Themes are required to state the copyright and license information for any bundled resources not covered by the Theme’s license statement. (PASSED- Readme.txt)

Trademark
Themes must not clone the design of past or present web site. Themes that clone non-website designs will be considered on a case-by-case basis. (PASSED)

Theme Documentation
Themes are recommended to include a readme.txt file, using Plugin readme.txt markdown. (PASSED - readme.txt)

Theme and Author URI
Theme URI is optional. If used, it is required to link to a page with information about the Theme. If a demonstration site is being used, the content must be related to the theme itself and not test data. (PASSED)
Author URI is optional. If used it is required to link to an author’s personal website or project/development website.
Avoid using WordPress.org as your Theme or Author URI. (PASSED)
Determination of appropriateness of AuthorURI and ThemeURI is at the sole, and final, discretion of the Theme Review Team. (PASSED)
Links in the description of the theme must be appropriately defined in respect to the AuthorURI requirements or to help and assistance to usage of the theme. (PASSED)

Footer Credit Links
Footer credit links are optional but if used themes are required to include no more than one footer credit link.
Credit link, if used, is required to use either Theme URI or Author URI. (Passed)
Credit link anchor text and title are required to be relevant and appropriate with respect to the linked site. Spam or SEO-seeded anchor text and titles are not allowed. (Passed)
A second “Powered by” link for WordPress is also acceptable, with the link pointing to ​https://wordpress.org.
Credit-link removal options are required to be opt-in (i.e. disabled by default) if used.(N/A)
Since Themes are GPL (or compatible), Theme authors are prohibited from requiring that these links be kept by Theme users. An appropriate way to ask for Theme users to keep a link to the author’s website is as follows: “It is completely optional, but if you like the Theme I would appreciate it if you keep the credit link at the bottom.” (Passed)

REVIEW SUMMARY

• Code Quality: PASSED
• Presentation Vs. Functionality: PASSED
• Theme Features: PASSED
• Template Tags and Hooks: PASSED
• WordPress-Generated CSS Classes:
• Theme Template Files: PASSED
• Security and Privacy: PASSED
• Licensing, Theme Name, Credit Links, Up-Sell Themes: PASSED
• Theme Documentation: PASSED - Theme uses standard WordPress functionality. Readme.txt provides some guidance.
• Theme Obsolescence: N/A - First Submission
• Accessibility: PASSED - N/A
• WordPress Trademark - PASSED

FINAL RECOMMENDATION:
Recommend Approval

[karmatosed]

Technically the theme functions should all be prefixed by the text domain.

"Use a single unique theme slug – as the theme slug appears in style.css. If it uses a framework then no more than 2 unique slugs."

I am going to ask if you are using a framework here?

[tinkerpriest]

I have many themes that use the same functions so I prefix them all with bavotasan_. It makes it easier on my end to maintain them all. I guess it is a sort of self-made framework.

[poena]

@jcastaneda I'm not sure if there was something specific you wanted reviewed,
I only have a few things to add to the previous review:

Required:

Please remove the file Config.rb

Please replace all instances of the "arcade" text domain.

When the user chooses not to have a header image, this code is still being output:

<img class="header-img" src="" height="500" width="1400" alt="" />

Please check if an image is used before output.

images:
royalty free images is not the same as being compatible with the GPL,
usually this license is limited so that you cant redistribute the image.
Please provide a link to the full license.

(I can also confirm that the "Bavotasan" prefix is used across several themes and can be considered a framework.)

[themetracbot]

Farben Basic - 1.0.1

Create a truly unique design with Farben Basic, a lightweight and fully responsive HTML5 theme. Use the Customizer to add your own header image, page layout, site width and more. Distinguish each post with one of the eight supported post formats, such as: Video, Image, Aside, Status, Audio, Quote, Link and Gallery. Install JetPack to display each of your galleries through a tiled view and jQuery carousel. Compatible with bbPress, BuddyPress &amp; Woocommerce. Built using SASS, Compass and Bootstrap 3. Uses Google Fonts for improved typeface readability. Designed for desktop browsers, tablets and handheld devices.

Theme URL - ​https://themes.bavotasan.com/themes/farben/
Author URL - ​http://bavotasan.com/

SVN - ​https://themes.svn.wordpress.org/farben-basic/1.0.1
ZIP - ​https://wordpress.org/themes/download/farben-basic.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/farben-basic/1.0.0&new_path=/farben-basic/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#21384	THEME: Farben Basic - 1.0.3	closed	live	poena
(this ticket)
#24874	THEME: Farben Basic – 1.0.4	closed	live	poena
#31330	THEME: Farben Basic – 1.0.5	closed	live	themetracbot
#53957	THEME: Farben Basic – 1.0.6	closed	live	themetracbot

[tinkerpriest]

Updated the theme to address all the issues above. Thanks. ;)

[poena]

I'm sorry I was not specific enough, the guidelines sais that themes has to
•Be 100% GPL and/or 100% GPL-compatible licensed
This includes the images in the screenshot.

All other required issues have been fixed.

[tinkerpriest]

The images are from Veer and the license states:

Basic license grants you basic royalty-free usage rights:

• One-time payment to use the image over and over again.
• Permitted uses such as advertising and promotional projects, web sites, presentations, videos, commercials, catalogs, and broadcasting.

What do I have to do?

[poena]

In ​http://www.veer.com/help/license.aspx?eula=MPP there is also a list of prohibited use.
You may never:
use Content in any product, merchandise or service that is intended to permit the Content to be accessed, extracted or used apart from the product, merchandise or service in which the Content is incorporated;

But the GPL allows this.

So you need to replace the images.
I don't know of any sites that offer gpl compatible illustrations. (Unless you count clipart, but I think you want something of a higher quality).
To replace them with photos, try ​http://skitterphoto.com/ or ​http://www.gratisography.com/. (Pixabay and unsplash are not as reliable since anyone can upload photos taken by anyone)

[tinkerpriest]

The images in the screenshot are only being used to promote the theme. They are not included whatsoever within the theme and the license from Veer allows me to use the images for unlimited promotional use.

[poena]

The screenshot is included in the .zip and the entire theme needs to be 100% GPL compatible.

[jcastaneda]

Please update the screenshot.

[tinkerpriest]

Working on it right now.

Got a quick question though: what is the policy of having a documentation page for the theme and redirecting to it upon activation? Similar to how the bbPress plugin does it.

Thanks.

[poena]

I did a quick search through the trac for an admin answer and found this answer from Chip:

Regarding redirection: no. Themes may not redirect, on activation or update.

[themetracbot]

Farben Basic - 1.0.2

Create a truly unique design with Farben Basic, a lightweight and fully responsive HTML5 theme. Use the Customizer to add your own header image, page layout, site width and more. Distinguish each post with one of the eight supported post formats, such as: Video, Image, Aside, Status, Audio, Quote, Link and Gallery. Install JetPack to display each of your galleries through a tiled view and jQuery carousel. Compatible with bbPress, BuddyPress &amp; Woocommerce. Built using SASS, Compass and Bootstrap 3. Uses Google Fonts for improved typeface readability. Designed for desktop browsers, tablets and handheld devices.

Theme URL - ​https://themes.bavotasan.com/themes/farben/
Author URL - ​http://bavotasan.com/

SVN - ​https://themes.svn.wordpress.org/farben-basic/1.0.2
ZIP - ​https://wordpress.org/themes/download/farben-basic.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/farben-basic/1.0.1&new_path=/farben-basic/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#21384	THEME: Farben Basic - 1.0.3	closed	live	poena
(this ticket)
#24874	THEME: Farben Basic – 1.0.4	closed	live	poena
#31330	THEME: Farben Basic – 1.0.5	closed	live	themetracbot
#53957	THEME: Farben Basic – 1.0.6	closed	live	themetracbot

[poena]

I'm not sure that having two menu items under Appearance is allowed, I don't find them that intrusive, but @jcastaneda can confirm.
(You could do a tabbed page)

-You need to change the text domain from destin to farben.
-I can't find the license for the images in the screenshot and About page.

[jcastaneda]

Personally I feel like it's overkill. I know there was once was a requirement that you could have two pages but one had to be an options page. I've never liked, never been a fan of it. Reason is the support you provide for your users is far greater than any upsell you show. They see that and turn away because they can feel like they are pushed into it. Keep in mind that is my opinion.

As for the requirement, I would say that falls into the selling, themes and links sections ( more/less ). There should be only one link: ​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

[themetracbot]

Farben Basic - 1.0.3

Create a truly unique design with Farben Basic, a lightweight and fully responsive HTML5 theme. Use the Customizer to add your own header image, page layout, site width and more. Distinguish each post with one of the eight supported post formats, such as: Video, Image, Aside, Status, Audio, Quote, Link and Gallery. Install JetPack to display each of your galleries through a tiled view and jQuery carousel. Compatible with bbPress, BuddyPress &amp; Woocommerce. Built using SASS, Compass and Bootstrap 3. Uses Google Fonts for improved typeface readability. Designed for desktop browsers, tablets and handheld devices.

Theme URL - ​https://themes.bavotasan.com/themes/farben/
Author URL - ​http://bavotasan.com/

SVN - ​https://themes.svn.wordpress.org/farben-basic/1.0.3
ZIP - ​https://wordpress.org/themes/download/farben-basic.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/farben-basic/1.0.2&new_path=/farben-basic/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#21384	THEME: Farben Basic - 1.0.3	closed	live	poena
(this ticket)
#24874	THEME: Farben Basic – 1.0.4	closed	live	poena
#31330	THEME: Farben Basic – 1.0.5	closed	live	themetracbot
#53957	THEME: Farben Basic – 1.0.6	closed	live	themetracbot

[poena]

text-domains -fixed
license -fixed

And the upgrade link is the same as theme URL, -pass