Make WordPress Themes

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#186244 closed theme (not-approved)

THEME: MinimalistFlex – 1.0.1

Reported by: frank419's profile frank419 Owned by: kafleg's profile kafleg
Priority: previously reviewed Keywords: theme-minimalistflex
Cc: hufang2007@…

Description

MinimalistFlex - 1.0.1

MinimalistFlex is an elegant, easy to use theme that aims to provide a smooth user experience. As a classic theme, we try to provide as many options as possible, while not being overwhelming. With full support of flexible header images, custom colors and layout, multiple widget areas, you can still customize your site in a lot of ways. Compatibility is also an important affair: MinimalistFlex is tested on many versions with a minimum of WordPress 4.9 and PHP 5.6, ensuring that almost everyone can enjoy the theme without worrying to upgrade. Mobile users are also considered well: MinimalistFlex is fully responsive on its own, and works well even on very small screen sizes!

Theme URL -
Author URL - https://onmyodev.com/

Trac Browser - https://themes.trac.wordpress.org/browser/minimalistflex/1.0.1
WordPress.org - https://wordpress.org/themes/minimalistflex/

SVN - https://themes.svn.wordpress.org/minimalistflex/1.0.1
ZIP - https://downloads.wordpress.org/theme/minimalistflex.1.0.1.zip?nostats=1
Live preview – https://playground.wordpress.net/#…

Diff with previous version: [239385] https://themes.trac.wordpress.org/changeset?old_path=minimalistflex/1.0.0&new_path=minimalistflex/1.0.1

History:

Ticket Summary Status Resolution Owner
#186073 THEME: MinimalistFlex – 1.0.0 closed not-approved fahimmurshed
#186244 THEME: MinimalistFlex – 1.0.1 closed not-approved kafleg

(this ticket)

#186933 THEME: MinimalistFlex – 1.0.6 closed live kafleg
#203720 THEME: MinimalistFlex – 1.1.1 closed live themetracbot
#211920 THEME: MinimalistFlex – 1.2 closed live themetracbot
#213953 THEME: MinimalistFlex – 1.2.1 closed live themetracbot
#232250 THEME: MinimalistFlex – 1.2.2 closed live themetracbot
#245020 THEME: MinimalistFlex – 1.3 closed live themetracbot
#257182 THEME: MinimalistFlex – 1.4 closed live themetracbot
#257231 THEME: MinimalistFlex – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/minimalistflex/1.0.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED .gallery-caption css class is recommended in your theme css.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.

Change History (4)

#1 @frank419
18 months ago

Hi there,

The new version is uploaded. Please kindly review.

Best regards.

#2 @kafleg
18 months ago

  • Owner set to kafleg
  • Status changed from new to reviewing

#3 follow-up: @kafleg
18 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

Use this plugin to check your theme,
https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update: https://wordpress.org/themes/upload/

Keyboard Navigation

  • Theme authors must provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons, and text links.
  • Some resources to help you: Information on the requirement
  • Video help for Modals, Links, Forms, Menus
  • Check TwentyTwenty using tab and shift+tab as an example
  • Check mobile menu and when keyboard reached the last menu item, the next tab should go to the close menu item. there is no option to close the opened menu dialogue box.

Escaping

  • Use proper escaping function, here esc_url is necessary to escape the URL, <?php echo esc_attr( get_template_directory_uri() . $suggest_image ) ?>. Not esc_attr is valid escaping function. Check your entire code.

License

  • All the third party resources( JS Library, CSS Library, Images, Google fonts, Icons, etc ) license should be mentioned in theme readme file. And all those resources should be GPL compatible.
  • Declare image license as below format,
    Image for theme screenshot, Credit Jason Blackeye
    License: CC0 1.0 Universal (CC0 1.0)
    License URL: https://stocksnap.io/license
    Source: https://stocksnap.io/photo/4B83RD7BV9
    
  • Recommended resources for images, https://make.wordpress.org/themes/handbook/review/resources/#recommended-websites-for-images
  • Mention theme license in readme file,
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    

Plugin Territory

  • Login Logout is plugin territory. Remove it.

Note: This is not complete review.

You can always ask in the #themereview channel on WordPress slack if you have any confusion regarding the issues mentioned above. Or you can also watch this video and know more about the guidelines.

Thank you

#4 in reply to: ↑ 3 @frank419
18 months ago

Hello kafleg,

Thanks for the review. I would push a new version soon --- however, I cannot find any traces of Login / Logout. Could you please provide an example of the login / logout functions in the theme?

Thanks.

---

There's no need now. I've found it. The new version is pushing along.

Last edited 18 months ago by frank419 (previous) (diff)
Note: See TracTickets for help on using tickets.