Make WordPress Themes

Attachments (1)

Bildschirmfoto 2014-05-14 um 21.44.34.png (51.8 KB) - added by elfacht 11 years ago.

Download all attachments as: .zip

Change History (5)

#1 @chipbennett
11 years ago

  • Owner set to miss_jwo
  • Status changed from new to reviewing

#2 @emiluzelac
11 years ago

  • Owner changed from miss_jwo to elfacht

Reassigning to @elfacht due to inactivity.

#3 @elfacht
11 years ago

Here we go:

Policy Requirements

  • comments.php: no link to CodexCoder license available (only a license.txt in root folder, not specified)
  • footer.php: hard coded credits text
  • readme.txt: note to not 100% GPL license

Code quality

  • header.php: unused php code blocks
  • header.php: misspelled keywords meta-tag
  • footer.php: hard coded script-tag for google analytics function in php ("proudly powered by wordpress" not removable in theme settings)
  • functions.php: unused php code (line 20)
  • functions.php: theme options are outsourced to file (lib/theme_functions.php) and not properly chained to a single options array
  • content.php moved to content/content.php (imho not nessessary)

Theme unit test

  • layout is not consistent; looks unready
  • search form is not fluid and overlaps (screenshot)
  • theme settings: logo is hidden when I choose to show it and vice versa
  • theme settings: no preview of uploaded favicon

Hope this helps.

#4 @emiluzelac
11 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.