Make WordPress Themes

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#16258 closed theme (live)

THEME: Leniy Radius - 1.0.2

Reported by: leniy's profile leniy Owned by: cyberchimpscode's profile cyberchimpscode
Priority: new theme Keywords: theme-leniy-radius
Cc: leniytsan@…, chip@…

Attachments (1)

leniyradius.zip (672.5 KB) - added by leniy 11 years ago.
version 1.0.1

Download all attachments as: .zip

Change History (12)

#1 @cyberchimpscode
11 years ago

  • Owner set to cyberchimpscode
  • Status changed from new to reviewing

#2 follow-up: @cyberchimpscode
11 years ago

Required

  • You cannot hard-code your copyright into the front-end footer "CopyRight © 2006-2014 LENIY.ORG". Instead, place copyright information in your stylesheet.
  • When users leave the page/post title blank, something still needs to appear in order for people to reach it. Just add the following to functions.php replacing "yourthemesslughere" in both places (adjust as you like):
add_filter( 'the_title', 'yourthemesslughere_title' );
function yourthemesslughere_title( $title ) {
if ( $title == '' ) {
return 'Untitled';
} else {
return $title;
}
}

Notes

Since there are only a few minor issues I will leave open as reviewing to allow you time to fix and upload a new version. Thanks

@leniy
11 years ago

version 1.0.1

#3 in reply to: ↑ 2 @leniy
11 years ago

Thanks.

The hard-code copyright had been removed.
The 'leniyradius_title()' function had been added into 'inc/extras.php' which will be required by functions.php

I have upload the new version 1.0.1 into attachment leniyradius.zip

Replying to cyberchimpscode:

Required

  • You cannot hard-code your copyright into the front-end footer "CopyRight © 2006-2014 LENIY.ORG". Instead, place copyright information in your stylesheet.
  • When users leave the page/post title blank, something still needs to appear in order for people to reach it. Just add the following to functions.php replacing "yourthemesslughere" in both places (adjust as you like):
add_filter( 'the_title', 'yourthemesslughere_title' );
function yourthemesslughere_title( $title ) {
if ( $title == '' ) {
return 'Untitled';
} else {
return $title;
}
}

Notes

Since there are only a few minor issues I will leave open as reviewing to allow you time to fix and upload a new version. Thanks

#5 @themetracbot
11 years ago

  • Summary changed from THEME: Leniy Radius - 1.0 to THEME: Leniy Radius - 1.0.1

Leniy Radius - 1.0.1

Leniy Radius, a HTML5+CSS3 responsive WordPress blog theme. With custom head, custom background, page template, featured posts, social icons, threaded comments and widget support.

Theme URL - http://blog.leniy.org/wordpress-theme-leniyradius.html
Author URL - http://blog.leniy.org

SVN - http://themes.svn.wordpress.org/leniy-radius/1.0.1
ZIP - http://wordpress.org/themes/download/leniy-radius.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/leniy-radius/1.0&new_path=/leniy-radius/1.0.1

History:

Ticket Summary Status Resolution Owner
#16258 THEME: Leniy Radius - 1.0.2 closed live cyberchimpscode

(this ticket)

#16436 THEME: Leniy Radius - 2.0.1 closed live chipbennett
#16584 THEME: Leniy Radius - 2.0.2 closed live tskk
#16667 THEME: Leniy Radius - 2.0.3 closed live catchthemes
#16693 THEME: Leniy Radius - 2.0.5 closed live tskk
#16963 THEME: Leniy Radius - 2.0.7 closed live robin90
#49153 THEME: Leniy Radius – 2.7.12 closed live themetracbot
#49370 THEME: Leniy Radius – 2.7.13 closed live Otto42


https://themes.svn.wordpress.org/leniy-radius/1.0.1/screenshot.png

#6 @cyberchimpscode
11 years ago

Apologies, one more thing that I overlooked before I can approve your theme.

Go ahead and update the screenshot real quick. It needs to be a simple screenshot of the way the theme looks in a browser without any company logo, marketing materials etc.

Thanks

#7 @themetracbot
11 years ago

  • Summary changed from THEME: Leniy Radius - 1.0.1 to THEME: Leniy Radius - 1.0.2

Leniy Radius - 1.0.2

Leniy Radius, a HTML5+CSS3 responsive WordPress blog theme. With custom head, custom background, page template, featured posts, social icons, threaded comments and widget support.

Theme URL - http://blog.leniy.org/wordpress-theme-leniyradius.html
Author URL - http://blog.leniy.org

SVN - http://themes.svn.wordpress.org/leniy-radius/1.0.2
ZIP - http://wordpress.org/themes/download/leniy-radius.1.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/leniy-radius/1.0.1&new_path=/leniy-radius/1.0.2

History:

Ticket Summary Status Resolution Owner
#16258 THEME: Leniy Radius - 1.0.2 closed live cyberchimpscode

(this ticket)

#16436 THEME: Leniy Radius - 2.0.1 closed live chipbennett
#16584 THEME: Leniy Radius - 2.0.2 closed live tskk
#16667 THEME: Leniy Radius - 2.0.3 closed live catchthemes
#16693 THEME: Leniy Radius - 2.0.5 closed live tskk
#16963 THEME: Leniy Radius - 2.0.7 closed live robin90
#49153 THEME: Leniy Radius – 2.7.12 closed live themetracbot
#49370 THEME: Leniy Radius – 2.7.13 closed live Otto42


https://themes.svn.wordpress.org/leniy-radius/1.0.2/screenshot.png

#8 @cyberchimpscode
11 years ago

  • Status changed from reviewing to approved

Great, I'm going ahead and approving now. Please keep in mind that your theme still needs to pass a final admin check before being made live. Thanks

#9 @cyberchimpscode
11 years ago

  • Cc chip@… added

This ticket may have fallen through the cracks, checking with an admin.

Thanks

#10 follow-up: @chipbennett
11 years ago

  • Resolution set to live
  • Status changed from approved to closed

I'm going to push this one live, but I have two main concerns:

  1. Theme is derived from Underscores, but does not properly attribute copyright/license of original work. Please add appropriate attribution
  2. I'm not a SQL expert, and don't have much experience with the $wpdb class. I will probably ask someone who is to look at some of the direct database queries, to ensure that they're safe. I strongly recommend using WP_Query() rather than direct/raw SQL queries.

#11 in reply to: ↑ 10 @leniy
11 years ago

Replying to chipbennett:

  1. I have add appropriate attribution in version 2.0.1
  2. I need SELECT COUNT(*), GROUP BY and LEFT OUTER JOIN in SQL, but I don't know how to use WP_Query() to do this jobs.
Note: See TracTickets for help on using tickets.