Opened 12 years ago
Closed 12 years ago
#16138 closed theme (closed-newer-version-uploaded)
THEME: Infinite - 1.0.6
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | previously reviewed | Keywords: | theme-infinite |
| Cc: | ravichandrach1@…, chipbennett |
Description
Infinite - 1.0.3
Infinite is a clean, responsive, retina ready and fully responsive wordpress theme for business websites, blogs and portfolio websites to showcase your work.
Theme URL -
Author URL - http://ravichandrach.com
SVN - http://themes.svn.wordpress.org/infinite/1.0.3
ZIP - http://wordpress.org/themes/download/infinite.1.0.3.zip?nostats=1
Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/infinite/1.0.2&new_path=/infinite/1.0.3
History:
Attachments (2)
Change History (18)
#3
@
12 years ago
I need more information before I can proceed with this review.
- readme.txt: You have the below statement - please provide url to the resources and license. Also note that the only Creative Commons license compatible with GPL is the CC By 0.
Flickr pictures from following authors licensed under Creative Commons danielviero clab4design br1dotcom
- In addition in the same file you have the below statement - this leads me to believe that your theme or part of the code is a derivative of the Corpo theme for which you have not declare nor included the original work's license/copyright
This theme relies on Corpo Toolkit plugin for some of the functionality. This plugin is bundled with the theme. After you activate Corpo, you'll see messege on top of your screen, asking you to install Corpo Toolkit plugin. Make sure that you activate too! If you dismiess this notice, but find yourself wanting to install Corpo Toolkit leater, you can start installation from Appereance->Install plugins.
- Furthermore, it is now a requirement to submit all theme enhancement plugins to the WPORG plugin repository to be reviewed and hosted instead of bundling them with the theme.
I can only proceed with the review once the above issues have been resolved. If you have any questions please feel free to ask in the comments.
#4
follow-up:
↓ 5
@
12 years ago
Hi
Thanks for reviewing and providing your comments, below are my comments
readme.txt - i just realized that i am not using any of the CC licensed images in this theme, i will remove this
Corpo - what i got from corpo is only the readme.txt file, i had that theme installed on my local system and i copied the readme.txt file contents for the format. The theme is completly my work. i wil remove the Corpo line
Plugin - since when did it became mandatory to submit a theme enhancement plugin to the WPORG repository ? i still see themes which are in the repository using a bundled plugins for additional functionality. I want to provide users the Portfolio post type functionality and i can't do it in the theme, that's why i wrote the Infinite Toolkit plugin. This integrates the custom posttype and shortcode functionality. if i need to get this plugin updated in WPORG repository i think that needs to be Theme independent and getting all those options working for a different theme is not possible because Infinite provides custom options. I also might have to first get the plugin uploaded and approved before submitting the theme ? Please let me know the best solution here.
#5
in reply to:
↑ 4
@
12 years ago
Replying to ravichandra:
Hi
Thanks for reviewing and providing your comments, below are my comments
Plugin - since when did it became mandatory to submit a theme enhancement plugin to the WPORG repository ? i still see themes which are in the repository using a bundled plugins for additional functionality. I want to provide users the Portfolio post type functionality and i can't do it in the theme, that's why i wrote the Infinite Toolkit plugin. This integrates the custom posttype and shortcode functionality. if i need to get this plugin updated in WPORG repository i think that needs to be Theme independent and getting all those options working for a different theme is not possible because Infinite provides custom options. I also might have to first get the plugin uploaded and approved before submitting the theme ? Please let me know the best solution here.
First on the point of "i still see themes which are in the repository using a bundled plugins for additional functionality"
Those themes were reviewed and approved before it was decided that theme related plugins should be installed from within WPORG repository.
Secondly "I also might have to first get the plugin uploaded and approved before submitting the theme ?"
Affirmative - the plugin will have to be uploaded for approval first and once hosted in the repository it can be installed via the script within the theme.
These issues are usually discussed on the WPTRT mailing list and then they filter through to the guideline pages.
For more details please read the following threads from the mailing list:
http://lists.wordpress.org/pipermail/theme-reviewers/2014-January/017134.html
http://lists.wordpress.org/pipermail/theme-reviewers/2014-January/017134.html
Hope that helps,
Zulf
#6
@
12 years ago
- Summary changed from THEME: Infinite - 1.0.4 to THEME: Infinite - 1.0.5
Infinite - 1.0.5
Infinite is a clean, responsive, retina ready and fully responsive wordpress theme for business websites, blogs and portfolio websites to showcase your work.
Theme URL -
Author URL - http://ravichandrach.com
SVN - http://themes.svn.wordpress.org/infinite/1.0.5
ZIP - http://wordpress.org/themes/download/infinite.1.0.5.zip?nostats=1
Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/infinite/1.0.4&new_path=/infinite/1.0.5
History:
#8
@
12 years ago
General.
Required:
- Default logo provided with the theme must be unbranded - use something like "Logo" or "Your Logo" and not the theme or your business brand.
Code Check.
Required:
- infinite_recentposts_widget.php @line 32 and infinite_recentportfolio_widget @line 30 use get_template_directory_uri() instead of get_stylesheet_directory_uri().
- In the same two files above use wp_reset_postdata() rather than wp_reset_query() to reset the custom query.
- Themes are required to use a unique prefix for all global variables and custom functions - single.php: Prefix $my_query correctly. Check other files too.
- single.php: @line 158 use wp_reset_postdata().
- functions.php: @line 5 use get_template_directory_uri().
- functions.php: Remove define('PRODUCTION_ENV', true); @line 7
- functions.php: Loading the default stylesheet like below will not provide good support for child themes
wp_enqueue_style('infinite-style', get_template_directory_uri().'/style.css');
- Either use get_stylesheet_uri() or add the code below to better support child themes - this code must come after the above code.
// Load style.css from child theme if (is_child_theme()) { wp_enqueue_style('infinite-child', get_stylesheet_uri(), false, null); }
- Themes are required to be self contained i.e. all resources must be bundled with the theme - this is in reference to the code below found in functions.php.
function add_ie_html5_shim () { echo '<!--[if lt IE 9]>'; echo '<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>'; echo '<![endif]-->'; } add_action('wp_head', 'add_ie_html5_shim');
Theme Check.
Please run the theme trough the theme check and address the translation string recommendations.
Theme Unit Test.
Recommended:
- In content tables need styling in order to be distinguished as tables - use the latest theme unit test data to test for this.
- Both WordPress TV and YouTube videos overflow their container - see attachment
- Post with no title must somehow link to the single post view - currently there's no permalink.
This is a complete review and all required issues need addressing before resubmitting for further consideration. You may wish to reference the following resources to check, test and fix the theme in order to be sure it meets all of the current requirements and regulations.
Resources to be used for testing...
Code Quality
Theme Test Unit Data
Theme Review Guidelines
Monster Widget plugin
Debug Bar plugin
Log Deprecated Notices
Theme Check Plugin
Debogger Plugin
Theme Development Guidelines
Next Post Link
Previous Post Link
Next Image Link
Previous Image Link
Leaving ticket to facilitate a speedy follow up review - if you have any questions feel free to ask in the comments.
#9
@
12 years ago
- Summary changed from THEME: Infinite - 1.0.5 to THEME: Infinite - 1.0.6
Infinite - 1.0.6
Infinite is a clean, responsive, retina ready and fully responsive wordpress theme for business websites, blogs and portfolio websites to showcase your work.
Theme URL -
Author URL - http://ravichandrach.com
SVN - http://themes.svn.wordpress.org/infinite/1.0.6
ZIP - http://wordpress.org/themes/download/infinite.1.0.6.zip?nostats=1
Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/infinite/1.0.5&new_path=/infinite/1.0.6
History:
#11
@
12 years ago
- Status changed from reviewing to approved
All raised issues have been resolved.
In future revision please consider adding a changelog for all changes made on per version basis.
#12
@
12 years ago
This theme has a security vulnerability and should not be made live. Details sent to security@… and submitted via http://ravichandrach.com/contact-us/
#13
@
12 years ago
Hi,
Thanks for finding out the security bug, i have fixed it and uploaded the updated version, please review.
It created a new ticket actually - https://themes.trac.wordpress.org/ticket/16401
Infinite - 1.0.4
Infinite is a clean, responsive, retina ready and fully responsive wordpress theme for business websites, blogs and portfolio websites to showcase your work.
Theme URL -
Author URL - http://ravichandrach.com
SVN - http://themes.svn.wordpress.org/infinite/1.0.4
ZIP - http://wordpress.org/themes/download/infinite.1.0.4.zip?nostats=1
Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/infinite/1.0.3&new_path=/infinite/1.0.4
History:
(this ticket)