Make WordPress Themes

Attachments (2)

screenshot.png (45.8 KB) - added by sudeep611 12 years ago.
Sweet-Tech.zip (93.5 KB) - added by sudeep611 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 @ZGani
12 years ago

  • Owner set to ZGani
  • Status changed from new to reviewing

#2 @ZGani
12 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Required:

  • Screenshot is not acceptable - please remove the text and include a clear shot of the theme once activated.
  • Remove the blank index.html from the images folder as it is not part of the theme.
  • Declare the theme's copyright in the following format
    Themename WordPress theme, Copyright (C) 2013 YOUR NAME or YOUR COMPANY NAME
    Themename WordPress theme is licensed under the GPL.
    
  • Themes must also declare license and copyright of any resources used in constructing the theme. i.e. scripts, images and fonts in the following format:
    Resource name here - ​http://resource.url/
    License: Distributed under the terms of the License Name
    Copyright: Author, authorurl.com
    
  • Theme is a derivative of the underscores theme - this fact must also be declared and the original work's copyright included in the theme's documentation.
  • Remove the rss2_url and atom_url links from header.php
  • wp_enqueue_script( 'comment-reply' ) must be enqueued from a function callback hooked to the wp_enaqueue_scripts() in functions.php rather than being hard coded in the document head.
  • Use register_nav_menu to create menu areas that are user configurable.
  • All of the following items must be called from a function callback hooked to the after_setup_theme - please revisit the original theme to see how this is done.
  • load_theme_textdomain and add_theme_support
  • Remove if function exists wrapper from register_sidebar which should called from a function callback hooked to the widgets_init action - again, please see underscores on how its done.
  • Also remove the above wrappers from the sidebar call in sidebar.php
  • sweettech_analytics_code is plugin territory and must be removed from the theme.
  • comments.php: The code below is not required - please remove it
    if (!empty($_SERVER['SCRIPT_FILENAME']) && 'comments.php' == basename($_SERVER['SCRIPT_FILENAME']))
    		die ('Please do not load this page directly. Thanks!');
    


  • Please remove the inline styling in 404.php - these should either be in the style.css or in a function callback hooked to wp_head if they can not go in the style.css
  • Some translation strings are missing in functions.php

Recommended:

  • Please escape the 3 instances of home_url() in header.php and the one in searchform.php plus the one in footer.php - use esc_url(home_url('/') instead.

Please note that this is not a complete review and no theme test has taken place. You are therefore advised to use the following resources to check, test and fix any issues in addition to the one raise above before resubmitting for further consideration.
Resources to be used for testing...
Theme Test Unit Data
Theme Review Guidelines
Monster Widget plugin
Debug Bar plugin
Log Deprecated Notices
Theme Check Plugin
Debogger Plugin

Theme is Not Approved this time round.

Last edited 12 years ago by ZGani (previous) (diff)

#3 @sudeep611
12 years ago

Thank you for your review. Actually i was including timthumb in my theme but due to alot of errors while uploading i removed the script. Is there any way i can use timthumb script in my theme.

@sudeep611
12 years ago

@sudeep611
12 years ago

#4 @sudeep611
12 years ago

The theme is updated according to the above suggestion. Please review the theme.

Thank you.

#5 @ZGani
12 years ago

Hello Sudeep,

Please re-upload the theme via the uploader at http://wordpress.org/themes/upload/ like your did before.

Regarding timthumb - unfortunately no, the use of that script on themes hosted in the repository is not allowed. In fact it is not a good idea to use it in any theme as far as I'm concerned.

Note: See TracTickets for help on using tickets.