Make WordPress Themes

Change History (3)

#1 @themetracbot
4 years ago

The following has been generated by Theme Review Action, this is for informational purposes only.

Theme developers: the Meta team is testing a new tool to help you to discover and fix problems that might otherwise delay approval of your theme. Please give feedback on any errors and omissions in the test results here: https://github.com/WordPress/theme-review-action/issues


"wa.me" found when viewing "/?p=1241" (via: single.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links

"wa.me" found when viewing "/" (via: index.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links

"wa.me" found when viewing "/?cat=1" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links

"wa.me" found when viewing "/?tag=alignment-2" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links

"wa.me" found when viewing "/?post_format=gallery" (via: archive.php) is not an approved link.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-not-have-unexpected-links

#2 @kafleg
4 years ago

  • Owner set to kafleg
  • Status changed from new to reviewing

#3 @kafleg
4 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
I have had a quick look at the theme and at this point, it does not follow the requirements.

The Theme Review Team does not hard reject themes, -we want you to resubmit your theme, but we need you to read the requirements more carefully.

If the requirements are unclear, let us know so that we can continue to improve them.

When a ticket is closed as not approved, it loses its position in the review queue.

When the update is submitted, a new ticket is created at the end of the queue.
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/how-to-do-a-review-draft/

Use this plugin to check your theme,
https://wordpress.org/plugins/theme-check/

Use this upload form to submit your update: https://wordpress.org/themes/upload/

Some Example Issue

Author URI is not working.

Theme URI is optional. If used, it must be about the theme we’re hosting on WordPress.org.
Using WordPress.org in the Theme URI is reserved for the default themes (Twenty X).

Author URI is optional. If used, it must be a page or website about the author, author theme shop, or author project/development website.

Functions, classes name prefixing.
Here’s a list of the most common things that should be prefixed:

  • PHP function names.
  • PHP class names.
  • PHP global variables.
  • Action/Filter hooks.
  • Script handles.
  • Style handles.
  • Image size names.

Read more here: https://themereview.co/prefix-all-the-things/

There are functions names with invalid prefixing used. Check the entire theme code.

Keyboard Navigation

  • Theme authors must provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons, and text links.
  • Some resources to help you: Information on the requirement
  • Video help for Modals, Links, Forms, Menus
  • Check TwentyTwenty using tab and shift+tab as an example

Underline Links

You can always ask in the #themereview channel on WordPress slack if you have any confusion regarding the issues mentioned above.

Note: This is not a complete review.

Thank you

Note: See TracTickets for help on using tickets.