THEME: Twenty Plus Lite - 1.2

[zeaks]

Twenty Plus Lite - 1.2

Child-Theme of Twenty Twelve - Left or right sidebar, light or dark color scheme and excerpts or full posts. Three footer widgets available at the bottom of every page, homepage template displays original widgets.

Theme URL - ​http://zeaks.org/general/twenty-plus-lite-twenty-twelve-child-theme/
Author URL - ​http://zeaks.org

SVN - ​http://themes.svn.wordpress.org/twenty-plus-lite/1.2
ZIP - ​http://wordpress.org/extend/themes/download/twenty-plus-lite.1.2.zip?nostats=1
Parent Theme: ​http://wordpress.org/extend/themes/twentytwelve

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/twenty-plus-lite/1.1&new_path=/twenty-plus-lite/1.2

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-twenty-plus-lite&order=id

[zeaks]

License of upsell theme changed to GPL, GPL license.txt added and version number updated.

[SriniG]

Required

• add_contextual_help found in the file theme-options.php. Deprecated since version 3.3. Use get_current_screen()->add_help_tab() instead.
• Hard-coded link to ​http://wp.me/pIhT9-24G found in theme-options.php. Use ​esc_url, and please use the actual URL, not the shortened URL.
• Please fix these errors that appear when the 'Excerpts' option is selected:

  NOTICE: wp-content/themes/twenty-plus-lite/functions.php:76 - Undefined variable: `post`
  NOTICE: wp-content/themes/twenty-plus-lite/functions.php:76 - Trying to get property of non-object
  

• Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.). Themes are recommended to use theme-slug as this unique slug. Quite a few functions in functions.php of this theme have names not prefixed with the unique slug.
• Load the child theme's textdomain properly using load_child_theme_textdomain() (see ​http://codex.wordpress.org/Child_Themes#Internationalization). Note that "The text domain defined in load_child_theme_textdomain() should be used to translate all strings in the child theme. In the event that a template file from the parent has been included, the textdomain should be changed from the one defined in the parent to the one defined by the child."
• This child theme is not packed with WordPress or Twenty Twelve, so remove the following and the likes from any file that contains them.

   * @package WordPress
   * @subpackage Twenty_Twelve
   * @since Twenty Twelve 1.0
  

• screenshot.png should be a "reasonable facsimile" of the Theme after it is initially activated with default options. The screenshot shows the dark color scheme while the theme by default is activated with the light color scheme. My suggestion is, instead of changing the screenshot, the theme can have the dark color scheme enabled by default, because with the light color scheme the theme looks 99% the same as Twenty Twelve and it sort of devalues the uniqueness of this child theme.
• There footer widgets doesn't seem to align properly (see screenshots attached). Also set a max width for the select element in the widgets.

Recommended

• get_current_theme found in the file theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.

Review Summary

• This is a complete review.
• The theme has to address the required issues noted above before it can be approved.
• Current resolution: not approved