lensfun-users Mailing List for Lensfun

On Thu, 28 Mar 2024 13:19:58 +0000
Graeme Leese <gn...@gm...> wrote:

> Hi,
> 
> > I read diffraction (blur) correction is supported
> 
> 
> As far as I know there is no plan to support diffraction correction in
> lensfun. My information may be out of date. Where did you read it?

I found it on the web, googling, but it just mentioned the RawTherapee
plugin, and couldn't find any reference to lensfun project itself.

> > (besides a mysterious Dist.).
> >
> 
> Dist is for distortion correction.

Thanks for the enlightenment :)

> I checked on Darktable and the option is missing. I understand it is
> > not supported yet. When is it planned for?
> >
> 
> My understanding is that the "Diffuse and Sharpen" module has some presets
> that can be used for deblurring, but I don't think it's planned for lensfun.

Well, sharpening is not diffraction correction, but thanks for the tip...

The importance of the difference lies on diffraction correction being a
purposeful lens correction (where the lens profile is available),
whereas plain sharpening is uninformed...

I very much would love to see this supported, even if it takes time.

Hi,

> I read diffraction (blur) correction is supported


As far as I know there is no plan to support diffraction correction in
lensfun. My information may be out of date. Where did you read it?

> (besides a mysterious Dist.).
>

Dist is for distortion correction.

I checked on Darktable and the option is missing. I understand it is
> not supported yet. When is it planned for?
>

My understanding is that the "Diffuse and Sharpen" module has some presets
that can be used for deblurring, but I don't think it's planned for lensfun.

Thanks,
Graeme

On Thu, 7 Mar 2024 09:28:36 +0100
José Luis González <bug...@gm...> wrote:

> Hi,
> 
> I read diffraction (blur) correction is supported but on the Supported
> lenses list only TCA and Vign. are featured (besides a mysterious Dist.).
> 
> What's the current status of this feature and why isn't it displayed in
> Supported lenses?
> 
> Thanks a lot in advance.

I checked on Darktable and the option is missing. I understand it is
not supported yet. When is it planned for?

Hi,

I read diffraction (blur) correction is supported but on the Supported
lenses list only TCA and Vign. are featured (besides a mysterious Dist.).

What's the current status of this feature and why isn't it displayed in
Supported lenses?

Thanks a lot in advance.

It should be possible to calculate the ptlens profile that best
approximates the Adobe information. I might be able to do that, but no
guarantees as to when.

I'm not sure why acm would not be supported if you've compiled the software
from git, unless someone added it to the docs but never implemented it.
I'll check this out and find out why it looks like should work but doesn't.

Thanks,
Graeme


On Tue, 23 Nov 2021, 20:54 Gunar Kachel, <gun...@gm...> wrote:

> Many thanks for your feedback!
>
> I was hoping for a straight forward implementation in lensfun using the
> distortion model "acm".
> However, the compiled lensfun version 0.3.95 (from git) doesn't seem to be
> working with darktable ("Bad attribute value `model=acm' for element
> <distortion>!").
>
> Unfortunatelly I'm a noob when it come to tranformation calculation (to
> distortion models which are supported in lensfun 0.3.2).
> I've the feeling to be at a dead end for now...
>
> Gunar
>
>
> Am So., 21. Nov. 2021 um 23:46 Uhr schrieb Graeme Leese <gn...@gm...
> >:
>
>> Not sure if it helps, but the parameters for the 3 planes are so similar
>>> so that I simply would take the mean values of each parameter and go with
>>> it.
>>>
>>
>> I agree that this is definitely the place to start.
>>
>> The vendor of the lens also had to fit the model to the lens - the
>>> deviations in each of the 3 planes are compatible with typical small
>>> fitting errors. Parameters are equal to the 3rd or 4th significant digit
>>> which is very precise.
>>>
>>
>> You may well be right, but remember that the full width of the image is
>> 1.0, while a chromatic aberration is typically on the order of 1-2px, so I
>> would expect to find very similar values here. For example, the first
>> random lens that I've looked up in the lensfun db has tca parameters around
>> 10^-4.
>>
>> Thanks,
>> Graeme
>>
>>
>>
>>> On 21 Nov 2021, at 19:18, Graeme Leese <gn...@gm...> wrote:
>>>
>>> 
>>> Hi,
>>>
>>> I know basically nothing about DNG, but Googling suggests that yes, the
>>> planes are probably referring the different color channels. There's a tag
>>> CFAPlaneColor that sets which order the colors map to the planes or else
>>> they're RGB.
>>>
>>> Chromatic aberration is essentially when the different colours are
>>> distorted differently, so my first guess is that you should calculate the
>>> distortion from the average of the planes. Then the difference between the
>>> planes should be encoded in the TCA parameters. Alternatively, since the
>>> TCA parameters are given for R and B, perhaps it would work better to take
>>> the distortion only from the G plane, I'm not sure.
>>>
>>> I haven't tried to work out how the TCA parameters would be derived. If
>>> the method looks like it's working then I can probably have a look and see
>>> if the calculation is simple enough, or else it should be simple enough to
>>> write a script to find the values that match the warp from the dng file.
>>>
>>> I don't think lensfun encodes the optical centre from the warp (so it
>>> would have to be set to 0.5, 0.5). I'm not sure how much that would affect
>>> the accuracy of the data. It's also worth noting that the DNG file uses
>>> different coordinates for pixels (0,0 in the corner) than lensfun (0,0 in
>>> the centre).
>>>
>>> Hope that helps. I'm interested to know how you get on with converting
>>> the information.
>>>
>>> Thanks,
>>> Graeme
>>>
>>>
>>>
>>> On Wed, 17 Nov 2021, 13:05 Gunar Kachel, <gun...@gm...> wrote:
>>>
>>>> Hi, my lens is not yet supported by lensfun. I therefore searched for a
>>>> method to to get the right distortion and chromatic aberration profile to
>>>> be used in daktable. (And I was not very successful applying the "manual"
>>>> method using Hugin.)
>>>>
>>>> However, as this is a modern lens the profiles are already integrated
>>>> in the RAW file and I therefore followed this procedure:
>>>>
>>>>    1. convert the RAW file (NEF) to DNG using Adobe DNG Converter
>>>>    2. extract OpCoodeList3 parameters from DNG file using
>>>>    dng-validate.exe (at the bottom)
>>>>
>>>>
>>>> I assume I can implement these values using the lensfun distortion
>>>> profile model "acm".
>>>> However I'm puzzled that values are provided in several "planes".
>>>> Are the planes referring to different color channels?
>>>> How to implement the planes in lensfun?
>>>> How can I cover chromatic aberration using these information?
>>>>
>>>> Thanks in advance for the insight!
>>>>
>>>> Sample output from dng-validate.exe -v:
>>>> >>>>>>>>>>>>>>>>
>>>> Opcode: WarpRectilinear, minVersion = 1.3.0.0, flags = 0
>>>> Planes: 3
>>>> Optical center:
>>>> h = 0.501405
>>>> v = 0.504913
>>>> Plane 0:
>>>> Radial params: 1.025498, -0.124349, 0.058447, -0.003755
>>>> Tangential params: 0.000000, 0.000000
>>>> Plane 1:
>>>> Radial params: 1.025181, -0.124368, 0.058438, -0.003759
>>>> Tangential params: 0.000000, 0.000000
>>>> Plane 2:
>>>> Radial params: 1.025277, -0.124355, 0.058413, -0.003751
>>>> Tangential params: 0.000000, 0.000000
>>>> <<<<<<<<<<<<<<<<<
>>>> _______________________________________________
>>>> Lensfun-users mailing list
>>>> Len...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>>>
>>> _______________________________________________
>>> Lensfun-users mailing list
>>> Len...@li...
>>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>>
>>>

Many thanks for your feedback!

I was hoping for a straight forward implementation in lensfun using the
distortion model "acm".
However, the compiled lensfun version 0.3.95 (from git) doesn't seem to be
working with darktable ("Bad attribute value `model=acm' for element
<distortion>!").

Unfortunatelly I'm a noob when it come to tranformation calculation (to
distortion models which are supported in lensfun 0.3.2).
I've the feeling to be at a dead end for now...

Gunar


Am So., 21. Nov. 2021 um 23:46 Uhr schrieb Graeme Leese <gn...@gm...>:

> Not sure if it helps, but the parameters for the 3 planes are so similar
>> so that I simply would take the mean values of each parameter and go with
>> it.
>>
>
> I agree that this is definitely the place to start.
>
> The vendor of the lens also had to fit the model to the lens - the
>> deviations in each of the 3 planes are compatible with typical small
>> fitting errors. Parameters are equal to the 3rd or 4th significant digit
>> which is very precise.
>>
>
> You may well be right, but remember that the full width of the image is
> 1.0, while a chromatic aberration is typically on the order of 1-2px, so I
> would expect to find very similar values here. For example, the first
> random lens that I've looked up in the lensfun db has tca parameters around
> 10^-4.
>
> Thanks,
> Graeme
>
>
>
>> On 21 Nov 2021, at 19:18, Graeme Leese <gn...@gm...> wrote:
>>
>> 
>> Hi,
>>
>> I know basically nothing about DNG, but Googling suggests that yes, the
>> planes are probably referring the different color channels. There's a tag
>> CFAPlaneColor that sets which order the colors map to the planes or else
>> they're RGB.
>>
>> Chromatic aberration is essentially when the different colours are
>> distorted differently, so my first guess is that you should calculate the
>> distortion from the average of the planes. Then the difference between the
>> planes should be encoded in the TCA parameters. Alternatively, since the
>> TCA parameters are given for R and B, perhaps it would work better to take
>> the distortion only from the G plane, I'm not sure.
>>
>> I haven't tried to work out how the TCA parameters would be derived. If
>> the method looks like it's working then I can probably have a look and see
>> if the calculation is simple enough, or else it should be simple enough to
>> write a script to find the values that match the warp from the dng file.
>>
>> I don't think lensfun encodes the optical centre from the warp (so it
>> would have to be set to 0.5, 0.5). I'm not sure how much that would affect
>> the accuracy of the data. It's also worth noting that the DNG file uses
>> different coordinates for pixels (0,0 in the corner) than lensfun (0,0 in
>> the centre).
>>
>> Hope that helps. I'm interested to know how you get on with converting
>> the information.
>>
>> Thanks,
>> Graeme
>>
>>
>>
>> On Wed, 17 Nov 2021, 13:05 Gunar Kachel, <gun...@gm...> wrote:
>>
>>> Hi, my lens is not yet supported by lensfun. I therefore searched for a
>>> method to to get the right distortion and chromatic aberration profile to
>>> be used in daktable. (And I was not very successful applying the "manual"
>>> method using Hugin.)
>>>
>>> However, as this is a modern lens the profiles are already integrated in
>>> the RAW file and I therefore followed this procedure:
>>>
>>>    1. convert the RAW file (NEF) to DNG using Adobe DNG Converter
>>>    2. extract OpCoodeList3 parameters from DNG file using
>>>    dng-validate.exe (at the bottom)
>>>
>>>
>>> I assume I can implement these values using the lensfun distortion
>>> profile model "acm".
>>> However I'm puzzled that values are provided in several "planes".
>>> Are the planes referring to different color channels?
>>> How to implement the planes in lensfun?
>>> How can I cover chromatic aberration using these information?
>>>
>>> Thanks in advance for the insight!
>>>
>>> Sample output from dng-validate.exe -v:
>>> >>>>>>>>>>>>>>>>
>>> Opcode: WarpRectilinear, minVersion = 1.3.0.0, flags = 0
>>> Planes: 3
>>> Optical center:
>>> h = 0.501405
>>> v = 0.504913
>>> Plane 0:
>>> Radial params: 1.025498, -0.124349, 0.058447, -0.003755
>>> Tangential params: 0.000000, 0.000000
>>> Plane 1:
>>> Radial params: 1.025181, -0.124368, 0.058438, -0.003759
>>> Tangential params: 0.000000, 0.000000
>>> Plane 2:
>>> Radial params: 1.025277, -0.124355, 0.058413, -0.003751
>>> Tangential params: 0.000000, 0.000000
>>> <<<<<<<<<<<<<<<<<
>>> _______________________________________________
>>> Lensfun-users mailing list
>>> Len...@li...
>>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>>
>> _______________________________________________
>> Lensfun-users mailing list
>> Len...@li...
>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>
>>

> Not sure if it helps, but the parameters for the 3 planes are so similar
> so that I simply would take the mean values of each parameter and go with
> it.
>

I agree that this is definitely the place to start.

The vendor of the lens also had to fit the model to the lens - the
> deviations in each of the 3 planes are compatible with typical small
> fitting errors. Parameters are equal to the 3rd or 4th significant digit
> which is very precise.
>

You may well be right, but remember that the full width of the image is
1.0, while a chromatic aberration is typically on the order of 1-2px, so I
would expect to find very similar values here. For example, the first
random lens that I've looked up in the lensfun db has tca parameters around
10^-4.

Thanks,
Graeme



> On 21 Nov 2021, at 19:18, Graeme Leese <gn...@gm...> wrote:
>
> 
> Hi,
>
> I know basically nothing about DNG, but Googling suggests that yes, the
> planes are probably referring the different color channels. There's a tag
> CFAPlaneColor that sets which order the colors map to the planes or else
> they're RGB.
>
> Chromatic aberration is essentially when the different colours are
> distorted differently, so my first guess is that you should calculate the
> distortion from the average of the planes. Then the difference between the
> planes should be encoded in the TCA parameters. Alternatively, since the
> TCA parameters are given for R and B, perhaps it would work better to take
> the distortion only from the G plane, I'm not sure.
>
> I haven't tried to work out how the TCA parameters would be derived. If
> the method looks like it's working then I can probably have a look and see
> if the calculation is simple enough, or else it should be simple enough to
> write a script to find the values that match the warp from the dng file.
>
> I don't think lensfun encodes the optical centre from the warp (so it
> would have to be set to 0.5, 0.5). I'm not sure how much that would affect
> the accuracy of the data. It's also worth noting that the DNG file uses
> different coordinates for pixels (0,0 in the corner) than lensfun (0,0 in
> the centre).
>
> Hope that helps. I'm interested to know how you get on with converting the
> information.
>
> Thanks,
> Graeme
>
>
>
> On Wed, 17 Nov 2021, 13:05 Gunar Kachel, <gun...@gm...> wrote:
>
>> Hi, my lens is not yet supported by lensfun. I therefore searched for a
>> method to to get the right distortion and chromatic aberration profile to
>> be used in daktable. (And I was not very successful applying the "manual"
>> method using Hugin.)
>>
>> However, as this is a modern lens the profiles are already integrated in
>> the RAW file and I therefore followed this procedure:
>>
>>    1. convert the RAW file (NEF) to DNG using Adobe DNG Converter
>>    2. extract OpCoodeList3 parameters from DNG file using
>>    dng-validate.exe (at the bottom)
>>
>>
>> I assume I can implement these values using the lensfun distortion
>> profile model "acm".
>> However I'm puzzled that values are provided in several "planes".
>> Are the planes referring to different color channels?
>> How to implement the planes in lensfun?
>> How can I cover chromatic aberration using these information?
>>
>> Thanks in advance for the insight!
>>
>> Sample output from dng-validate.exe -v:
>> >>>>>>>>>>>>>>>>
>> Opcode: WarpRectilinear, minVersion = 1.3.0.0, flags = 0
>> Planes: 3
>> Optical center:
>> h = 0.501405
>> v = 0.504913
>> Plane 0:
>> Radial params: 1.025498, -0.124349, 0.058447, -0.003755
>> Tangential params: 0.000000, 0.000000
>> Plane 1:
>> Radial params: 1.025181, -0.124368, 0.058438, -0.003759
>> Tangential params: 0.000000, 0.000000
>> Plane 2:
>> Radial params: 1.025277, -0.124355, 0.058413, -0.003751
>> Tangential params: 0.000000, 0.000000
>> <<<<<<<<<<<<<<<<<
>> _______________________________________________
>> Lensfun-users mailing list
>> Len...@li...
>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>
> _______________________________________________
> Lensfun-users mailing list
> Len...@li...
> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>
>

Hi,

I know basically nothing about DNG, but Googling suggests that yes, the
planes are probably referring the different color channels. There's a tag
CFAPlaneColor that sets which order the colors map to the planes or else
they're RGB.

Chromatic aberration is essentially when the different colours are
distorted differently, so my first guess is that you should calculate the
distortion from the average of the planes. Then the difference between the
planes should be encoded in the TCA parameters. Alternatively, since the
TCA parameters are given for R and B, perhaps it would work better to take
the distortion only from the G plane, I'm not sure.

I haven't tried to work out how the TCA parameters would be derived. If the
method looks like it's working then I can probably have a look and see if
the calculation is simple enough, or else it should be simple enough to
write a script to find the values that match the warp from the dng file.

I don't think lensfun encodes the optical centre from the warp (so it would
have to be set to 0.5, 0.5). I'm not sure how much that would affect the
accuracy of the data. It's also worth noting that the DNG file uses
different coordinates for pixels (0,0 in the corner) than lensfun (0,0 in
the centre).

Hope that helps. I'm interested to know how you get on with converting the
information.

Thanks,
Graeme



On Wed, 17 Nov 2021, 13:05 Gunar Kachel, <gun...@gm...> wrote:

> Hi, my lens is not yet supported by lensfun. I therefore searched for a
> method to to get the right distortion and chromatic aberration profile to
> be used in daktable. (And I was not very successful applying the "manual"
> method using Hugin.)
>
> However, as this is a modern lens the profiles are already integrated in
> the RAW file and I therefore followed this procedure:
>
>    1. convert the RAW file (NEF) to DNG using Adobe DNG Converter
>    2. extract OpCoodeList3 parameters from DNG file using
>    dng-validate.exe (at the bottom)
>
>
> I assume I can implement these values using the lensfun distortion profile
> model "acm".
> However I'm puzzled that values are provided in several "planes".
> Are the planes referring to different color channels?
> How to implement the planes in lensfun?
> How can I cover chromatic aberration using these information?
>
> Thanks in advance for the insight!
>
> Sample output from dng-validate.exe -v:
> >>>>>>>>>>>>>>>>
> Opcode: WarpRectilinear, minVersion = 1.3.0.0, flags = 0
> Planes: 3
> Optical center:
> h = 0.501405
> v = 0.504913
> Plane 0:
> Radial params: 1.025498, -0.124349, 0.058447, -0.003755
> Tangential params: 0.000000, 0.000000
> Plane 1:
> Radial params: 1.025181, -0.124368, 0.058438, -0.003759
> Tangential params: 0.000000, 0.000000
> Plane 2:
> Radial params: 1.025277, -0.124355, 0.058413, -0.003751
> Tangential params: 0.000000, 0.000000
> <<<<<<<<<<<<<<<<<
> _______________________________________________
> Lensfun-users mailing list
> Len...@li...
> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>

Hi, my lens is not yet supported by lensfun. I therefore searched for a
method to to get the right distortion and chromatic aberration profile to
be used in daktable. (And I was not very successful applying the "manual"
method using Hugin.)

However, as this is a modern lens the profiles are already integrated in
the RAW file and I therefore followed this procedure:

   1. convert the RAW file (NEF) to DNG using Adobe DNG Converter
   2. extract OpCoodeList3 parameters from DNG file using dng-validate.exe
   (at the bottom)


I assume I can implement these values using the lensfun distortion profile
model "acm".
However I'm puzzled that values are provided in several "planes".
Are the planes referring to different color channels?
How to implement the planes in lensfun?
How can I cover chromatic aberration using these information?

Thanks in advance for the insight!

Sample output from dng-validate.exe -v:
>>>>>>>>>>>>>>>>
Opcode: WarpRectilinear, minVersion = 1.3.0.0, flags = 0
Planes: 3
Optical center:
h = 0.501405
v = 0.504913
Plane 0:
Radial params: 1.025498, -0.124349, 0.058447, -0.003755
Tangential params: 0.000000, 0.000000
Plane 1:
Radial params: 1.025181, -0.124368, 0.058438, -0.003759
Tangential params: 0.000000, 0.000000
Plane 2:
Radial params: 1.025277, -0.124355, 0.058413, -0.003751
Tangential params: 0.000000, 0.000000
<<<<<<<<<<<<<<<<<

[ Just realised that I sent my response just to Martin, but to the list.
Sorry about that. ]

Hi Martin,

Sorry for the lack of activity on this. Github is the right place to put
these (if you've already done the calibration then ideally make a PR, but
an issue is also fine). I'll take a look at your data and try to get it
merged shortly. (I've been away from the project for a bit with family and
work commitments but I'm having a look at the backlog now). I have IT
issues, but I hope that everything will be restored from backups by the
weekend so I'll be looking into things next week.

Torsten normally reviews data before it gets merged and I don't know what
checks he would run. I'll make a PR and ask him to review.

If anyone else is in a similar situation waiting, then firstly thanks for
sending us the data. If it's in a PR on github then I'll get to it soon. If
it's in an issue then I'll get to it, but if you convert it into a PR or
send me the issue number then I'll get to it sooner. If you've sent things
to the mailing list then please either put them on Github or respond them
to the list so that they don't get lost in the archive.

Thanks,
Graeme

On Sat, 27 Mar 2021, 20:09 Martin Kunz, <mar...@gm...> wrote:

> Dear lensfun developers,
>
> Three months ago I provided profiles for said Tamron lenses in this
> Github issue <https://github.com/lensfun/lensfun/issues/1332>. As far as
> I can see, they are not included in the latest version of lensfun. Assuming
> that putting them in a Github issue was the wrong strategy then, I am
> attaching the profiles to this message with the request to add them to the
> database.
>
> Cheers,
> Martin
> _______________________________________________
> Lensfun-users mailing list
> Len...@li...
> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>

Hi Graeme,

I did a test with the names that you proposed and it seems that at least Darktable is able to do the match between the EXIF names and these ones. Thus it can auto detect the lens also with these names.
What I used for testing is this as you suggested:
<model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6G VR 168</model>
<model>Tamron SP 70-300mm f/4-5.6 Di VC USD (A005)</model>

Regarding the Tamron lens I think that there was an older model of this lens and a newer one that then got the A005 editition. My lens is the A005 edition but it seems that this number is not included in the EXIF data. But if the auto detection works it makes sense to include it in the XML.

Thank you for your investigations,
Johann


Am Samstag, 27. März 2021, 13:34:03 CEST schrieb Graeme Leese:
> OK, I've had a look now that I've got the source in front of me and it
> looks like I may have been wrong. The Tamron lens originally didn't have
> the "(A005)" part but Torsten added it with the commit message "Fixed one
> Tamron lens name" and I don't understand that change at the moment. If you
> have the chance, could you check whether your lens is autodetected if you
> change the "4.0" to "4" in the name string but leave the "(A005)" part
> there? It looks like that would be consistent with how other lenses have
> their aperture values written in the database.
> 
> The 168 at the end of the Nikon lens is the lens ID, but it's present in
> quite a few of the names in that file. Comparing the "model" tag with the
> "en" names suggests that the "G" that you see in your exif data should be
> in the "model" tag. So, I guess the same question again, if you include the
> "G" in the model tag but don't remove the "168" does it still solve your
> problem?
> 
> Hopefully someone (Torsten?) can say what the correct format for these
> names is. Failing that, does anyone else have one of these lenses and could
> confirm that making changes to the names won't break the autodetection?
> 
> Thanks,
> Graeme
> 
> On Fri, 26 Mar 2021 at 13:10, Graeme Leese <gn...@gm...> wrote:
> 
> > Hi,
> >
> > Thanks for the report. It looks to me as though the extra bit at the end
> > of the names in the database is wrong and should be removed to match what
> > you're seeing. I'll have a look and see if I can understand why it's like
> > it is, but I guess that changing the XML will be the right fix.
> >
> > Thanks,
> > Graeme
> >
> >
> > On Sun, 21 Mar 2021, 12:55 Johann Maierhofer, <
> > joh...@fr...> wrote:
> >
> >> Hello,
> >>
> >> I have tree lenses for my Nikon D5500 and use Darktable to edit my RAW
> >> file.
> >> Only one of these lenses is detected automatically by Darktable. The
> >> others I
> >> need to select manually from the list.
> >>
> >> After comparing the data in the XML files with the data reported in the
> >> EXIF
> >> data I found that the names do not match. After correcting the names
> >> Darktable
> >> automatically detected the lenses.
> >>
> >> In slr-nikon.xml it was
> >> existing entry:
> >> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6 VR 168</model>
> >> name according to my EXIF data:
> >> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6G VR</model>
> >>
> >> In slr-tamron.xml it was
> >> existing entry:
> >> <model>Tamron SP 70-300mm f/4.0-5.6 Di VC USD (A005)</model>
> >> name according to EXIF data:
> >> <model>Tamron SP 70-300mm f/4-5.6 Di VC USD</model>
> >>
> >> I do not know whether the issue is with my camera to produce wrong EXIF
> >> data
> >> or whether the xml entries should be generally changed.
> >>
> >> Thanks
> >> Johann
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> Lensfun-users mailing list
> >> Len...@li...
> >> https://lists.sourceforge.net/lists/listinfo/lensfun-users
> >>
> >
> 

Dear lensfun developers,

Three months ago I provided profiles for said Tamron lenses in this
Github issue <https://github.com/lensfun/lensfun/issues/1332>. As far as
I can see, they are not included in the latest version of lensfun.
Assuming that putting them in a Github issue was the wrong strategy
then, I am attaching the profiles to this message with the request to
add them to the database.

Cheers,
Martin

Good morning,
I've re-run all the shots.
1st series with a gate as subject
2nd series a window sash
3rd series a white ceiling to assess vignetting

Some notes:
In the first series you can clearly see the AC phenomenon against the sun.
In the third series no development has been done except for the one applied
by default by DarkTable, if you want I can develop also these images or
remove also the generic development done by the software.
The shots of the third series are all out of focus.
For your convenience at this address I insert the folders containing the
jpeg files and 3 .rar files, one for each series of shots.

Link image:
https://drive.google.com/drive/folders/1jhPJJmv08gg8jzsyGnvgzwXiymAHiOMh?usp=sharing

Thanks
Lorenzo Fontanella

Il giorno ven 26 mar 2021 alle ore 15:29 Lorenzo Fontanella <
fon...@gm...> ha scritto:

> Over the weekend I will be taking more shots of a different subject. Since
> it's a gate, I have the straight line near the top edge of the frame, but I
> don't guarantee I'll have the line at 1/3. Unfortunately, I do NOT have
> such large glass walls available. After you have uploaded the second set of
> shots as well, you will evaluate which you prefer. Thanks
> Lorenzo Fontanella
>
> Il ven 26 mar 2021, 14:33 Graeme Leese <gn...@gm...> ha scritto:
>
>> Hi,
>>
>> To be honest I don't know how well calibration will work on those photos.
>> The brick lines wont quite be straight but the distortion is on a much
>> larger scale than the brick variation, so it might produce a good answer
>> anyway. I can do the calibration for you, but I don't have a lot of time
>> and it might be a week or more before I can do it. You mentioned glass
>> walls in your mail and they tend to have much larger and more regular
>> panels than brick, so if you do run the shots again, that might be better.
>>
>> Have you had a look at https://wilson.bronger.org/calibration? That
>> gives details of a place that you can upload images for calibration. That's
>> really the right place to upload photos, but since I've lost my password
>> for that image store at the moment I'll take these photos from here.
>>
>> Thanks,
>> Graeme
>>
>>
>> On Mon, 22 Mar 2021, 10:01 Lorenzo Fontanella, <
>> fon...@gm...> wrote:
>>
>>> Good evening,
>>> I took a series of shots at all focal lengths and all apertures for this
>>> lens.
>>> Unfortunately they are taken on a brick wall because I couldn't find
>>> anything better than glass walls considering the wide angle of view of this
>>> lens.
>>>
>>> I think the pictures can still be okay.
>>> I am attaching an image to see if they can be used for calibration.
>>>
>>> I may be able to re-run the shots if they are not adequate.
>>> I can also provide appropriate shots for vignetting and TCA.
>>> I cannot perform the calibration myself as I lack the expertise and time.
>>>
>>> I would like confirmation on the usability of the shots and if I can
>>> have you perform the calibration if you have the time.
>>>
>>> Link image
>>>
>>> https://drive.google.com/drive/folders/1jhPJJmv08gg8jzsyGnvgzwXiymAHiOMh?usp=sharing
>>>
>>> Thank you
>>> Lorenzo Fontanella
>>> -------------------------------
>>> Calcinato Via Monte 2 - cell. 3288145594
>>> _______________________________________________
>>> Lensfun-users mailing list
>>> Len...@li...
>>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>>
>>

OK, I've had a look now that I've got the source in front of me and it
looks like I may have been wrong. The Tamron lens originally didn't have
the "(A005)" part but Torsten added it with the commit message "Fixed one
Tamron lens name" and I don't understand that change at the moment. If you
have the chance, could you check whether your lens is autodetected if you
change the "4.0" to "4" in the name string but leave the "(A005)" part
there? It looks like that would be consistent with how other lenses have
their aperture values written in the database.

The 168 at the end of the Nikon lens is the lens ID, but it's present in
quite a few of the names in that file. Comparing the "model" tag with the
"en" names suggests that the "G" that you see in your exif data should be
in the "model" tag. So, I guess the same question again, if you include the
"G" in the model tag but don't remove the "168" does it still solve your
problem?

Hopefully someone (Torsten?) can say what the correct format for these
names is. Failing that, does anyone else have one of these lenses and could
confirm that making changes to the names won't break the autodetection?

Thanks,
Graeme

On Fri, 26 Mar 2021 at 13:10, Graeme Leese <gn...@gm...> wrote:

> Hi,
>
> Thanks for the report. It looks to me as though the extra bit at the end
> of the names in the database is wrong and should be removed to match what
> you're seeing. I'll have a look and see if I can understand why it's like
> it is, but I guess that changing the XML will be the right fix.
>
> Thanks,
> Graeme
>
>
> On Sun, 21 Mar 2021, 12:55 Johann Maierhofer, <
> joh...@fr...> wrote:
>
>> Hello,
>>
>> I have tree lenses for my Nikon D5500 and use Darktable to edit my RAW
>> file.
>> Only one of these lenses is detected automatically by Darktable. The
>> others I
>> need to select manually from the list.
>>
>> After comparing the data in the XML files with the data reported in the
>> EXIF
>> data I found that the names do not match. After correcting the names
>> Darktable
>> automatically detected the lenses.
>>
>> In slr-nikon.xml it was
>> existing entry:
>> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6 VR 168</model>
>> name according to my EXIF data:
>> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6G VR</model>
>>
>> In slr-tamron.xml it was
>> existing entry:
>> <model>Tamron SP 70-300mm f/4.0-5.6 Di VC USD (A005)</model>
>> name according to EXIF data:
>> <model>Tamron SP 70-300mm f/4-5.6 Di VC USD</model>
>>
>> I do not know whether the issue is with my camera to produce wrong EXIF
>> data
>> or whether the xml entries should be generally changed.
>>
>> Thanks
>> Johann
>>
>>
>>
>>
>> _______________________________________________
>> Lensfun-users mailing list
>> Len...@li...
>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>
>

Over the weekend I will be taking more shots of a different subject. Since
it's a gate, I have the straight line near the top edge of the frame, but I
don't guarantee I'll have the line at 1/3. Unfortunately, I do NOT have
such large glass walls available. After you have uploaded the second set of
shots as well, you will evaluate which you prefer. Thanks
Lorenzo Fontanella

Il ven 26 mar 2021, 14:33 Graeme Leese <gn...@gm...> ha scritto:

> Hi,
>
> To be honest I don't know how well calibration will work on those photos.
> The brick lines wont quite be straight but the distortion is on a much
> larger scale than the brick variation, so it might produce a good answer
> anyway. I can do the calibration for you, but I don't have a lot of time
> and it might be a week or more before I can do it. You mentioned glass
> walls in your mail and they tend to have much larger and more regular
> panels than brick, so if you do run the shots again, that might be better.
>
> Have you had a look at https://wilson.bronger.org/calibration? That gives
> details of a place that you can upload images for calibration. That's
> really the right place to upload photos, but since I've lost my password
> for that image store at the moment I'll take these photos from here.
>
> Thanks,
> Graeme
>
>
> On Mon, 22 Mar 2021, 10:01 Lorenzo Fontanella, <
> fon...@gm...> wrote:
>
>> Good evening,
>> I took a series of shots at all focal lengths and all apertures for this
>> lens.
>> Unfortunately they are taken on a brick wall because I couldn't find
>> anything better than glass walls considering the wide angle of view of this
>> lens.
>>
>> I think the pictures can still be okay.
>> I am attaching an image to see if they can be used for calibration.
>>
>> I may be able to re-run the shots if they are not adequate.
>> I can also provide appropriate shots for vignetting and TCA.
>> I cannot perform the calibration myself as I lack the expertise and time.
>>
>> I would like confirmation on the usability of the shots and if I can have
>> you perform the calibration if you have the time.
>>
>> Link image
>>
>> https://drive.google.com/drive/folders/1jhPJJmv08gg8jzsyGnvgzwXiymAHiOMh?usp=sharing
>>
>> Thank you
>> Lorenzo Fontanella
>> -------------------------------
>> Calcinato Via Monte 2 - cell. 3288145594
>> _______________________________________________
>> Lensfun-users mailing list
>> Len...@li...
>> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>>
>

Hi,

To be honest I don't know how well calibration will work on those photos.
The brick lines wont quite be straight but the distortion is on a much
larger scale than the brick variation, so it might produce a good answer
anyway. I can do the calibration for you, but I don't have a lot of time
and it might be a week or more before I can do it. You mentioned glass
walls in your mail and they tend to have much larger and more regular
panels than brick, so if you do run the shots again, that might be better.

Have you had a look at https://wilson.bronger.org/calibration? That gives
details of a place that you can upload images for calibration. That's
really the right place to upload photos, but since I've lost my password
for that image store at the moment I'll take these photos from here.

Thanks,
Graeme


On Mon, 22 Mar 2021, 10:01 Lorenzo Fontanella, <fon...@gm...>
wrote:

> Good evening,
> I took a series of shots at all focal lengths and all apertures for this
> lens.
> Unfortunately they are taken on a brick wall because I couldn't find
> anything better than glass walls considering the wide angle of view of this
> lens.
>
> I think the pictures can still be okay.
> I am attaching an image to see if they can be used for calibration.
>
> I may be able to re-run the shots if they are not adequate.
> I can also provide appropriate shots for vignetting and TCA.
> I cannot perform the calibration myself as I lack the expertise and time.
>
> I would like confirmation on the usability of the shots and if I can have
> you perform the calibration if you have the time.
>
> Link image
>
> https://drive.google.com/drive/folders/1jhPJJmv08gg8jzsyGnvgzwXiymAHiOMh?usp=sharing
>
> Thank you
> Lorenzo Fontanella
> -------------------------------
> Calcinato Via Monte 2 - cell. 3288145594
> _______________________________________________
> Lensfun-users mailing list
> Len...@li...
> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>

Hi,

Thanks for the report. It looks to me as though the extra bit at the end of
the names in the database is wrong and should be removed to match what
you're seeing. I'll have a look and see if I can understand why it's like
it is, but I guess that changing the XML will be the right fix.

Thanks,
Graeme


On Sun, 21 Mar 2021, 12:55 Johann Maierhofer, <joh...@fr...>
wrote:

> Hello,
>
> I have tree lenses for my Nikon D5500 and use Darktable to edit my RAW
> file.
> Only one of these lenses is detected automatically by Darktable. The
> others I
> need to select manually from the list.
>
> After comparing the data in the XML files with the data reported in the
> EXIF
> data I found that the names do not match. After correcting the names
> Darktable
> automatically detected the lenses.
>
> In slr-nikon.xml it was
> existing entry:
> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6 VR 168</model>
> name according to my EXIF data:
> <model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6G VR</model>
>
> In slr-tamron.xml it was
> existing entry:
> <model>Tamron SP 70-300mm f/4.0-5.6 Di VC USD (A005)</model>
> name according to EXIF data:
> <model>Tamron SP 70-300mm f/4-5.6 Di VC USD</model>
>
> I do not know whether the issue is with my camera to produce wrong EXIF
> data
> or whether the xml entries should be generally changed.
>
> Thanks
> Johann
>
>
>
>
> _______________________________________________
> Lensfun-users mailing list
> Len...@li...
> https://lists.sourceforge.net/lists/listinfo/lensfun-users
>

Good evening,
I took a series of shots at all focal lengths and all apertures for this
lens.
Unfortunately they are taken on a brick wall because I couldn't find
anything better than glass walls considering the wide angle of view of this
lens.

I think the pictures can still be okay.
I am attaching an image to see if they can be used for calibration.

I may be able to re-run the shots if they are not adequate.
I can also provide appropriate shots for vignetting and TCA.
I cannot perform the calibration myself as I lack the expertise and time.

I would like confirmation on the usability of the shots and if I can have
you perform the calibration if you have the time.

Link image
https://drive.google.com/drive/folders/1jhPJJmv08gg8jzsyGnvgzwXiymAHiOMh?usp=sharing

Thank you
Lorenzo Fontanella
-------------------------------
Calcinato Via Monte 2 - cell. 3288145594

Hello,

I have tree lenses for my Nikon D5500 and use Darktable to edit my RAW file. 
Only one of these lenses is detected automatically by Darktable. The others I 
need to select manually from the list.

After comparing the data in the XML files with the data reported in the EXIF 
data I found that the names do not match. After correcting the names Darktable 
automatically detected the lenses.

In slr-nikon.xml it was
existing entry:
<model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6 VR 168</model>
name according to my EXIF data:
<model>Nikon AF-P DX Nikkor 10-20mm f/4.5-5.6G VR</model>

In slr-tamron.xml it was
existing entry:
<model>Tamron SP 70-300mm f/4.0-5.6 Di VC USD (A005)</model>
name according to EXIF data:
<model>Tamron SP 70-300mm f/4-5.6 Di VC USD</model>

I do not know whether the issue is with my camera to produce wrong EXIF data 
or whether the xml entries should be generally changed.

Thanks
Johann

On Friday, 18 September 2020 15:17:49 CEST Dakin White wrote:
> I have run lensfun-update-data on my MX Linux system and both Digikam
> and Darktable still show my Nikkor AF-S 16-80mm f2.8-4 ED lens as ID
> 173.  I use a Nikon D500 and other lenses I use show correctly in both
> softwares used.
> 
> I have updated exiv2 and have confirmed that it is extracting the
> correct information also.
> 
> As this issue has persisted through 2 different Linux distributions with
> the same software installed I believe the issue lies in lensfun somewhere.
> 
> Would appreciate some direction on resolving this issue.


See "CONFIGURATION FILE" at https://www.exiv2.org/manpage.html

	

	Andreas

On Fri, Sep 18, 2020, at 21:12, Dakin White wrote:

> What I don't get is where the lens ID comes from?  From what I've seen
> it's the lens manufacture but I don't see it as part of the exif data.

Most tools, including exiv2 and exiftool, by default print a "friendly" summary, with the literal values "translated" into more human-meaningful ones. If you want exiv2 to show "plain" (untranslated) values for the tags, use the "v" mode with the print option, like this:

 exiv2 -pv <filename>

It's possible that darktable etc could develop more robust methods to get useful values for this field (something like how exiftool derives values for its "composite" tags), but I've never looked very hard at the exiv2 API, and don't really want to at this point. ;-)

-- 
jys

Thanks Jys,

Thanks for your reply.

Below are the two programs and their results for my lens;

Exiv2 reports : AF-S DX Nikkor 16-80mm f/2.8-4E ED VR
Lensfun file  : Nikon AF-S DX Nikkor 16-80mm f/2.8-4E ED VR

What I don't get is where the lens ID comes from?  From what I've seen
it's the lens manufacture but I don't see it as part of the exif data.

Surely if the lens maker assigned the number exiv2 and lensfun could
call the lens whatever they wanted and it would all work because there
is that constant value.

I tried the workaround in the first link but this did not resolve the
issue.  So will try logging the issue with exiv2.


Dakin

On Fri, Sep 18, 2020, at 06:17, Dakin White wrote:
> I have run lensfun-update-data on my MX Linux system and both Digikam
> and Darktable still show my Nikkor AF-S 16-80mm f2.8-4 ED lens as ID
> 173.  I use a Nikon D500 and other lenses I use show correctly in both
> softwares used.
> 
> I have updated exiv2 and have confirmed that it is extracting the
> correct information also.

It may be extracting it, but it obviously isn't delivering it via the API in the way that the software is expecting it to (by substituting a name for the Lens ID number) for whatever reason.
 
> As this issue has persisted through 2 different Linux distributions with
> the same software installed I believe the issue lies in lensfun somewhere.

It's not a Lensfun issue. Lensfun only sees what the software gives it to match against, in this case "173". You could work around it within Lensfun by creating a local copy of the lens profile and replacing the name in the "model" field with the ID number, but it might be nicer to first try something like this:

 http://web.archive.org/web/20190127023419/https://dev.exiv2.org/projects/exiv2/wiki/Lens_Recognition_in_Exiv2_v026_(and_later)/

(Archive link because site seems to have problems lately.)

You could try opening an issue here:

 https://github.com/Exiv2/exiv2/issues

...but you might just end up being pointed to that first link again. ;-)

-- 
jys

I have run lensfun-update-data on my MX Linux system and both Digikam
and Darktable still show my Nikkor AF-S 16-80mm f2.8-4 ED lens as ID
173.  I use a Nikon D500 and other lenses I use show correctly in both
softwares used.

I have updated exiv2 and have confirmed that it is extracting the
correct information also.

As this issue has persisted through 2 different Linux distributions with
the same software installed I believe the issue lies in lensfun somewhere.

Would appreciate some direction on resolving this issue.

Regards
Dakin

Hi all,

Can anyone tell me if there is a build of Lensfun 0.3.95 for Windows that is 
known to work?  The build on Msys2 of 0.3.2 works ok, but the 0.3.95 build 
appears to have fundamental problems - it crashes with memory corruption just 
trying to open the database.

If there is somewhere else to get working Windows binaries for 0.3.95 that 
would be very welcome.

Alternately, if anyone has instructions on how to build it on Windows 
(particularly where to put things so they are found by the configuration 
system), that would also be very handy and save a lot of time.

Many thanks

              -Matthew

-- 
Matthew Donaldson                         John 3:16   <><
Data Deliverance Pty. Ltd.
http://www.datadeliverance.com
http://au.linkedin.com/in/donaldsonmatthew
Phone: +61 8 8265 7976