Page MenuHomePhabricator
Differential D9012

[mempool] Persist unbroadcast set to mempool.dat
ClosedPublic
Actions

Authored by PiRK on Jan 21 2021, 11:41.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat
Summary

Ensure that the unbroadcast set will still be meaningful if the node is
restarted.

This concludes backport of Core PR18807 [7/7]
https://github.com/bitcoin/bitcoin/pull/18038/commits/50fc4df6c4e8a84bdda13ade7bed7a2131796f00
Depends on D9011

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 21 2021, 11:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2021, 11:41
PiRK requested review of this revision.Jan 21 2021, 11:41
teamcity edited the summary of this revision. (Show Details)Jan 21 2021, 11:41
Harbormaster completed remote builds in B14905: Diff 27174.Jan 21 2021, 12:25
majcosta requested changes to this revision.Jan 21 2021, 13:39
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/mempool_persist.py
50 ↗(On Diff #27174)

this isn't added by this PR

194 ↗(On Diff #27174)

comment on its own line

This revision now requires changes to proceed.Jan 21 2021, 13:39
PiRK updated this revision to Diff 27184.Jan 21 2021, 13:50

put a comment on its own line

majcosta accepted this revision.Jan 21 2021, 13:53

discussed off Phab, the wait_until import should be removed in PR19752

This revision is now accepted and ready to land.Jan 21 2021, 13:53
Harbormaster completed remote builds in B14909: Diff 27184.Jan 21 2021, 14:02
Closed by commit rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat (authored by Amiti Uttarwar <[email protected]>, committed by PiRK). · Explain WhyJan 21 2021, 19:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat.

Revision Contents
Changeset List

PathSize
src/
22 lines
test/
functional/
45 lines
3 lines

Diff 27207

View Options

src/validation.cpp

Loading...
View Options

test/functional/mempool_persist.py

Loading...
View Options

test/functional/mempool_unbroadcast.py

Loading...