Differential D8934

tests: don't repeat scriptPubKey value
ClosedPublic
Actions

Authored by PiRK on Jan 17 2021, 09:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC82d1d9deaf18: tests: don't repeat scriptPubKey value

Summary

Use a variable with a meaningful name to improve readability.

See https://reviews.bitcoinabc.org/D8929#204886

This is a partial backport of Core PR11423
364bae5f7a6b16eef63990154e48f19e7e693039

Test Plan

test/functional/test_runner.py p2p_invalid_tx

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 17 2021, 09:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2021, 09:00

PiRK requested review of this revision.Jan 17 2021, 09:00

teamcity edited the summary of this revision. (Show Details)Jan 17 2021, 09:01

assign the variable on the same line as the original PR

Harbormaster completed remote builds in B14807: Diff 27021.Jan 17 2021, 09:14

Harbormaster completed remote builds in B14808: Diff 27022.Jan 17 2021, 09:21

Fabien requested changes to this revision.Jan 18 2021, 08:15

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/p2p_invalid_tx.py
104 ↗	(On Diff #27022)	OP_TRUE is already defined in script.py

This revision now requires changes to proceed.Jan 18 2021, 08:15

don't redefine OP_TRUE, use existing components from script.py

Harbormaster completed remote builds in B14813: Diff 27027.Jan 18 2021, 09:49

Fabien accepted this revision.Jan 18 2021, 11:41

This revision is now accepted and ready to land.Jan 18 2021, 11:41

Closed by commit rABC82d1d9deaf18: tests: don't repeat scriptPubKey value (authored by PiRK). · Explain WhyJan 18 2021, 15:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC82d1d9deaf18: tests: don't repeat scriptPubKey value.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_invalid_tx.py

19 lines

Diff 27044

View Options

test/functional/p2p_invalid_tx.py

tests: don't repeat scriptPubKey valueClosedPublicActions